All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH] x86/debug: Fix macro definitions for DR7 local/global enable bits
Date: Thu, 11 Dec 2025 08:41:55 -0800	[thread overview]
Message-ID: <aTr0UzqE0tWHBa1g@google.com> (raw)
In-Reply-To: <20251126191736.907963-1-seanjc@google.com>

On Wed, Nov 26, 2025, Sean Christopherson wrote:
>  	n = 0;
>  	extern unsigned char hw_bp2;
> -	write_dr0(&hw_bp2);
> +	write_dr2(&hw_bp2);
>  	write_dr6(DR6_BS | DR6_TRAP1);
>  	asm volatile("hw_bp2: nop");
>  	report(n == 1 &&
>  	       db_addr[0] == ((unsigned long)&hw_bp2) &&
> -	       dr6[0] == (DR6_ACTIVE_LOW | DR6_BS | DR6_TRAP0),
> -	       "hw breakpoint (test that dr6.BS is not cleared)");
> +	       dr6[0] == (DR6_ACTIVE_LOW | DR6_BS | DR6_TRAP2),
> +	       "Wanted #DB on 0x%lx w/ DR6 = 0x%lx, got %u #DBs, addr[0] = 0x%lx, DR6 = 0x%lx",
> +	       ((unsigned long)&hw_bp1), DR6_ACTIVE_LOW | DR6_BS | DR6_TRAP2,

Copy+paste fail, this should be hw_bp2.

> +	       n, db_addr[0], dr6[0]);
>  
>  	run_ss_db_test(singlestep_basic);
>  	run_ss_db_test(singlestep_emulated_instructions);
> 
> base-commit: d2dc9294e25a34110feffb497a29c10f7e2a8ceb
> -- 
> 2.52.0.487.g5c8c507ade-goog
> 

  reply	other threads:[~2025-12-11 16:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-26 19:17 [kvm-unit-tests PATCH] x86/debug: Fix macro definitions for DR7 local/global enable bits Sean Christopherson
2025-12-11 16:41 ` Sean Christopherson [this message]
2026-05-19  0:40 ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aTr0UzqE0tWHBa1g@google.com \
    --to=seanjc@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.