From: Ming Lei <ming.lei@redhat.com>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Shuah Khan <shuah@kernel.org>,
linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/8] selftests: ublk: forbid multiple data copy modes
Date: Fri, 12 Dec 2025 19:09:40 +0800 [thread overview]
Message-ID: <aTv39DmuRbhXXekG@fedora> (raw)
In-Reply-To: <20251212051658.1618543-7-csander@purestorage.com>
On Thu, Dec 11, 2025 at 10:16:56PM -0700, Caleb Sander Mateos wrote:
> The kublk mock ublk server allows multiple data copy mode arguments to
> be passed on the command line (--zero_copy, --get_data, and --auto_zc).
> The ublk device will be created with all the requested feature flags,
> however kublk will only use one of the modes to interact with request
> data (arbitrarily preferring auto_zc over zero_copy over get_data). To
> clarify the intent of the test, don't allow multiple data copy modes to
> be specified. --zero_copy and --auto_zc are allowed together for
> --auto_zc_fallback, which uses both copy modes.
> Don't set UBLK_F_USER_COPY for zero_copy, as it's a separate feature.
> Fix the test cases in test_stress_05 passing --get_data along with
> --zero_copy or --auto_zc.
>
> Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Thanks,
Ming
next prev parent reply other threads:[~2025-12-12 11:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 5:16 [PATCH v2 0/8] selftests: ublk: add user copy test cases Caleb Sander Mateos
2025-12-12 5:16 ` [PATCH v2 1/8] selftests: ublk: correct last_rw map type in seq_io.bt Caleb Sander Mateos
2025-12-12 5:16 ` [PATCH v2 2/8] selftests: ublk: remove unused ios map " Caleb Sander Mateos
2025-12-12 5:16 ` [PATCH v2 3/8] selftests: ublk: fix fio arguments in run_io_and_recover() Caleb Sander Mateos
2025-12-12 5:16 ` [PATCH v2 4/8] selftests: ublk: use auto_zc for PER_IO_DAEMON tests in stress_04 Caleb Sander Mateos
2025-12-12 10:21 ` Ming Lei
2025-12-12 10:56 ` Ming Lei
2025-12-12 16:50 ` Caleb Sander Mateos
2025-12-12 5:16 ` [PATCH v2 5/8] selftests: ublk: don't share backing files between ublk servers Caleb Sander Mateos
2025-12-12 5:16 ` [PATCH v2 6/8] selftests: ublk: forbid multiple data copy modes Caleb Sander Mateos
2025-12-12 11:09 ` Ming Lei [this message]
2025-12-12 11:13 ` Ming Lei
2025-12-12 5:16 ` [PATCH v2 7/8] selftests: ublk: add support for user copy to kublk Caleb Sander Mateos
2025-12-12 11:16 ` Ming Lei
2025-12-12 5:16 ` [PATCH v2 8/8] selftests: ublk: add user copy test cases Caleb Sander Mateos
2025-12-12 11:17 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTv39DmuRbhXXekG@fedora \
--to=ming.lei@redhat.com \
--cc=csander@purestorage.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.