Re: [RFC PATCH 0/9] for 11.0 conversion* of get_maintainers.pl to python

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Dec 11, 2025 at 06:01:23PM +0000, Alex Bennée wrote:
> *incomplete
> 
> I wanted to look at adding gitlab tags to MAINTAINERS and baulked
> slightly at figuring out what I would need to change in the perl
> script to cleanly handle it.
> 
> While we imported the perl script from the kernel I'm fairly sure we
> don't use half the features it has and as us grey beards age out less
> people will be willing to tweak it. Consider this a proof-of-concept
> for discussion about if it is worth perusing this path.
> 
> It only supports the two main forms:
> 
>   ./scripts/get_maintainer.py -f path/to/file
>   ./scripts/get_maintainer.py path/to/patch1 path/to/patch2 ...
> 
> But who needs more?

the $QEMU/.gitpublish file contains

cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null

And the .b4-config file contains the same:

send-auto-cc-cmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback


Is trawling the git history to guess at maintainers useful
for regular usage, while undesirable for sending patches,
or should we just pick a behaviour use it unconditionally?

> 
> Future improvements could include some more detailed analysis in
> conjugation with the repo to analysis:
> 
>   - missing areas of coverage
>   - maintainer stats
> 
> Who knows maybe the kernel guys will want to import our script one day
> ;-)
> 
> Alex.
> 
> Alex Bennée (9):
>   MAINTAINERS: fix missing names
>   MAINTAINERS: fix libvirt entry
>   MAINTAINERS: regularise the status fields
>   scripts/get_maintainer.py: minimal argument parsing
>   scripts/get_maintainer.py: resolve the source path
>   scripts/get_maintainer.py: initial parsing of MAINTAINERS
>   scripts/get_maintainer.py: add support for -f
>   scripts/get_maintainer.py: add support reading patch files
>   gitlab: add a check-maintainers task
> 
>  MAINTAINERS                    |  10 +-
>  .gitlab-ci.d/static_checks.yml |   9 +
>  scripts/get_maintainer.py      | 356 +++++++++++++++++++++++++++++++++
>  3 files changed, 370 insertions(+), 5 deletions(-)
>  create mode 100755 scripts/get_maintainer.py
> 
> -- 
> 2.47.3
> 
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|