From: Frank Li <Frank.li@nxp.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-pm@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 2/3] thermal/drivers/imx91: Drop extra spaces
Date: Fri, 12 Dec 2025 12:29:41 -0500 [thread overview]
Message-ID: <aTxRBVKuRAs6fCoZ@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20251212-imx91-thermal-v1-2-c208545b44cb@nxp.com>
On Fri, Dec 12, 2025 at 03:51:15PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Unify the code style, drop extra spaces for the macros.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/thermal/imx91_thermal.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/thermal/imx91_thermal.c b/drivers/thermal/imx91_thermal.c
> index 77e8e6a921c6af308b830c36721293c007256ca6..768c5acc384eca1c2203098bd4749628d9ffb8e6 100644
> --- a/drivers/thermal/imx91_thermal.c
> +++ b/drivers/thermal/imx91_thermal.c
> @@ -22,17 +22,17 @@
> #define REG_TOG 0xc
>
> #define IMX91_TMU_CTRL0 0x0
> -#define IMX91_TMU_CTRL0_THR1_IE BIT(9)
> -#define IMX91_TMU_CTRL0_THR1_MASK GENMASK(3, 2)
> -#define IMX91_TMU_CTRL0_CLR_FLT1 BIT(21)
> +#define IMX91_TMU_CTRL0_THR1_IE BIT(9)
> +#define IMX91_TMU_CTRL0_THR1_MASK GENMASK(3, 2)
> +#define IMX91_TMU_CTRL0_CLR_FLT1 BIT(21)
It is used for register field. Many new driver use this style.
#define REGISTER_NAME
#define REGISTER_FIELD
So register defination looks like tree. Reader can quick search field and
register name.
Frank
>
> #define IMX91_TMU_THR_MODE_LE 0
> #define IMX91_TMU_THR_MODE_GE 1
>
> #define IMX91_TMU_STAT0 0x10
> -#define IMX91_TMU_STAT0_THR1_IF BIT(9)
> -#define IMX91_TMU_STAT0_THR1_STAT BIT(13)
> -#define IMX91_TMU_STAT0_DRDY0_IF_MASK BIT(16)
> +#define IMX91_TMU_STAT0_THR1_IF BIT(9)
> +#define IMX91_TMU_STAT0_THR1_STAT BIT(13)
> +#define IMX91_TMU_STAT0_DRDY0_IF_MASK BIT(16)
>
> #define IMX91_TMU_DATA0 0x20
>
> @@ -42,12 +42,12 @@
> #define IMX91_TMU_CTRL1_STOP BIT(29)
> #define IMX91_TMU_CTRL1_RES_MASK GENMASK(19, 18)
> #define IMX91_TMU_CTRL1_MEAS_MODE_MASK GENMASK(25, 24)
> -#define IMX91_TMU_CTRL1_MEAS_MODE_SINGLE 0
> -#define IMX91_TMU_CTRL1_MEAS_MODE_CONTINUES 1
> -#define IMX91_TMU_CTRL1_MEAS_MODE_PERIODIC 2
> +#define IMX91_TMU_CTRL1_MEAS_MODE_SINGLE 0
> +#define IMX91_TMU_CTRL1_MEAS_MODE_CONTINUES 1
> +#define IMX91_TMU_CTRL1_MEAS_MODE_PERIODIC 2
>
> #define IMX91_TMU_THR_CTRL01 0x30
> -#define IMX91_TMU_THR_CTRL01_THR1_MASK GENMASK(31, 16)
> +#define IMX91_TMU_THR_CTRL01_THR1_MASK GENMASK(31, 16)
>
> #define IMX91_TMU_REF_DIV 0x280
> #define IMX91_TMU_DIV_EN BIT(31)
> @@ -67,7 +67,7 @@
> #define IMX91_TMU_DEFAULT_TRIM2_CONFIG 0x65d4
>
> #define IMX91_TMU_PERIOD_CTRL 0x270
> -#define IMX91_TMU_PERIOD_CTRL_MEAS_MASK GENMASK(23, 0)
> +#define IMX91_TMU_PERIOD_CTRL_MEAS_MASK GENMASK(23, 0)
>
> #define IMX91_TMP_FRAC 64
>
>
> --
> 2.37.1
>
next prev parent reply other threads:[~2025-12-12 17:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 7:51 [PATCH 0/3] thermal/drivers/imx91: minor updates Peng Fan (OSS)
2025-12-12 7:51 ` [PATCH 1/3] thermal/drivers/imx91: Check status before reading data Peng Fan (OSS)
2025-12-12 17:25 ` Frank Li
2025-12-15 1:36 ` Peng Fan
2025-12-12 7:51 ` [PATCH 2/3] thermal/drivers/imx91: Drop extra spaces Peng Fan (OSS)
2025-12-12 17:29 ` Frank Li [this message]
2025-12-12 7:51 ` [PATCH 3/3] thermal/drivers/imx91: Drop macro for continues mode Peng Fan (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTxRBVKuRAs6fCoZ@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=daniel.lezcano@linaro.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.