All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Tom Rini <trini@konsulko.com>
Cc: alison.wang@nxp.com, angelo@kernel-space.org, me@ziyao.cc,
	daniel@0x0f.com, jserv@ccns.ncku.edu.tw, eleanor15x@gmail.com,
	u-boot@lists.denx.de
Subject: Re: [PATCH v2 4/4] CI: Add test jobs for QEMU m68k virt machine
Date: Sat, 27 Dec 2025 02:57:11 +0800	[thread overview]
Message-ID: <aU7ah4cc1maMH1KU@google.com> (raw)
In-Reply-To: <20251226180904.GF710860@bill-the-cat>

Hi Tom,

On Fri, Dec 26, 2025 at 12:09:04PM -0600, Tom Rini wrote:
> On Fri, Dec 26, 2025 at 05:54:00PM +0000, Kuan-Wei Chiu wrote:
> > Enable CI testing for the newly introduced QEMU m68k 'virt' board on
> > both GitLab CI and Azure Pipelines. This ensures the new M68040
> > architecture support is built and booted correctly in the emulated
> > environment.
> > 
> > Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> > ---
> > Changes in v2:
> > - New patch to add CI testing jobs for gitlab and azure pipelines.
> > 
> > Note: This patch depends on a corresponding patch to the
> > u-boot-test-hooks repository to provide the necessary QEMU
> > configuration: "travis-ci: Add config for QEMU m68k virt machine"
> > 
> > The gitlab CI job has been verified locally using gitlab-ci-local tool
> > with a passing result. Azure Pipelines has not been verified.
> > 
> >  .azure-pipelines.yml | 4 ++++
> >  .gitlab-ci.yml       | 7 +++++++
> >  2 files changed, 11 insertions(+)
> > 
> > diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml
> > index e4695f1c55b..41bba8ed0f1 100644
> > --- a/.azure-pipelines.yml
> > +++ b/.azure-pipelines.yml
> > @@ -518,6 +518,10 @@ stages:
> >            TEST_PY_ID: "--id qemu"
> >            TEST_PY_TEST_SPEC: "not sleep and not efi"
> >            OVERRIDE: "-a CONFIG_M68K_QEMU=y -a ~CONFIG_MCFTMR"
> > +        qemu_m68k_virt:
> > +          TEST_PY_BD: "qemu-m68k"
> > +          TEST_PY_ID: "--id qemu"
> 
> I see why you set TEST_PY_ID but that's only used in this manner for
> platforms which can be real or virtualized, for the qemu targets we just
> omit that (and then name the u-boot-test-hooks files to be "_na" or can
> just omit that part. Thanks for adding this!

Thanks for the quick feedback!
I'll fix the TEST_PY_ID usage.

Is there a preferred waiting period (like the 24 hr rule in Linux
netdev) before I send v3? I can send the fix immediately, but I want to
make sure I'm following the proper etiquette, especially during the
Christmas holidays.

Regards,
Kuan-Wei


  reply	other threads:[~2025-12-26 23:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-26 17:53 [PATCH v2 0/4] m68k: Add support for QEMU virt machine Kuan-Wei Chiu
2025-12-26 17:53 ` [PATCH v2 1/4] serial: Add Goldfish TTY driver Kuan-Wei Chiu
2025-12-27  2:07   ` Yao Zi
2025-12-27 14:06     ` Kuan-Wei Chiu
2025-12-26 17:53 ` [PATCH v2 2/4] m68k: Add support for M68040 CPU Kuan-Wei Chiu
2025-12-28  1:28   ` Daniel Palmer
2025-12-28 19:29     ` Kuan-Wei Chiu
2025-12-29  1:54       ` Daniel Palmer
2025-12-29 13:27         ` Kuan-Wei Chiu
2025-12-26 17:53 ` [PATCH v2 3/4] board: Add QEMU m68k virt board support Kuan-Wei Chiu
2025-12-28  1:16   ` Daniel Palmer
2025-12-28 19:13     ` Kuan-Wei Chiu
2025-12-29  1:42       ` Daniel Palmer
2025-12-29 13:44         ` Kuan-Wei Chiu
2025-12-31  3:20           ` Daniel Palmer
2025-12-26 17:54 ` [PATCH v2 4/4] CI: Add test jobs for QEMU m68k virt machine Kuan-Wei Chiu
2025-12-26 18:09   ` Tom Rini
2025-12-26 18:57     ` Kuan-Wei Chiu [this message]
2025-12-26 18:59       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aU7ah4cc1maMH1KU@google.com \
    --to=visitorckw@gmail.com \
    --cc=alison.wang@nxp.com \
    --cc=angelo@kernel-space.org \
    --cc=daniel@0x0f.com \
    --cc=eleanor15x@gmail.com \
    --cc=jserv@ccns.ncku.edu.tw \
    --cc=me@ziyao.cc \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.