From: Florian Westphal <fw@strlen.de>
To: Ricardo Robaina <rrobaina@redhat.com>
Cc: audit@vger.kernel.org, linux-kernel@vger.kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
paul@paul-moore.com, eparis@redhat.com, pablo@netfilter.org,
kadlec@netfilter.org
Subject: Re: [PATCH v7 1/2] audit: add audit_log_nf_skb helper function
Date: Tue, 16 Dec 2025 14:42:34 +0100 [thread overview]
Message-ID: <aUFhyhta7EU8i7iu@strlen.de> (raw)
In-Reply-To: <e5a5be5997fc2b8f7cc5f92e48b6d42158aff2c3.1763122537.git.rrobaina@redhat.com>
Ricardo Robaina <rrobaina@redhat.com> wrote:
> Netfilter code (net/netfilter/nft_log.c and net/netfilter/xt_AUDIT.c)
> have to be kept in sync. Both source files had duplicated versions of
> audit_ip4() and audit_ip6() functions, which can result in lack of
> consistency and/or duplicated work.
>
> This patch adds a helper function in audit.c that can be called by
> netfilter code commonly, aiming to improve maintainability and
> consistency.
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2025-12-16 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 12:36 [PATCH v7 0/2] audit: improve NETFILTER_PKT records Ricardo Robaina
2025-11-14 12:36 ` [PATCH v7 1/2] audit: add audit_log_nf_skb helper function Ricardo Robaina
2025-12-16 13:42 ` Florian Westphal [this message]
2025-11-14 12:36 ` [PATCH v7 2/2] audit: include source and destination ports to NETFILTER_PKT Ricardo Robaina
2025-12-16 13:44 ` Florian Westphal
2025-12-16 2:07 ` [PATCH v7 0/2] audit: improve NETFILTER_PKT records Paul Moore
2025-12-16 16:10 ` Paul Moore
2025-12-17 11:39 ` Ricardo Robaina
-- strict thread matches above, loose matches on Subject: below --
2025-11-15 9:40 [PATCH v7 1/2] audit: add audit_log_nf_skb helper function kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUFhyhta7EU8i7iu@strlen.de \
--to=fw@strlen.de \
--cc=audit@vger.kernel.org \
--cc=coreteam@netfilter.org \
--cc=eparis@redhat.com \
--cc=kadlec@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=paul@paul-moore.com \
--cc=rrobaina@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.