Re: [PATCH v4] xfs: test reproducible builds

[Dave Chinner <david@fromorbit.com>]

On Mon, Dec 15, 2025 at 09:19:06PM -0800, Christoph Hellwig wrote:
> On Tue, Dec 16, 2025 at 09:57:14AM +1100, Dave Chinner wrote:
> > > +_cleanup() {
> > > +	rm -r -f "$PROTO_DIR" "$IMG_FILE"
> > > +}
> > 
> > After test specific cleanup, this needs to call _generic_cleanup()
> > to handle all the internal test state cleanup requirements.
> 
> There's no such thing as _generic_cleanup, and none of the
> _cleanup()-using tests that I've looked at recently hooks into any
> kind of generic cleanup routine.

I forgot to mention: the lack of _generic_cleanup() doesn't mean my
review comment should be ignored - the new custom _cleanup()
function above still needs to do the relevant generic cleanup work
that is done in common/preamble::_cleanup()...

-Dave.
-- 
Dave Chinner
david@fromorbit.com