All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Waiman Long <llong@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] lockdep: Add header and footer to surround warning reports
Date: Wed, 17 Dec 2025 05:26:29 +0000	[thread overview]
Message-ID: <aUI_Bf6ZARxxtGyG@google.com> (raw)
In-Reply-To: <b52e45ad-1495-41ce-ac63-08253d63a978@redhat.com>

On Tue, Dec 16, 2025 at 09:57:30PM -0500, Waiman Long wrote:
> On 12/16/25 7:31 PM, Tzung-Bi Shih wrote:
> > On Tue, Dec 16, 2025 at 11:20:45AM -0500, Waiman Long wrote:
> > > On 12/15/25 2:26 AM, Tzung-Bi Shih wrote:
> > > > @@ -110,6 +111,11 @@ static __init int kernel_lockdep_sysctls_init(void)
> > > >    late_initcall(kernel_lockdep_sysctls_init);
> > > >    #endif /* CONFIG_SYSCTL */
> > > > +static void print_footer(void)
> > > > +{
> > > > +	pr_warn("---[ end trace %016llx ]---\n", 0ULL);
> > > What is the purpose of putting 16 '0' in this "end trace" line? Is it
> > > related to how your parsing script works?
> > Mostly wanted to align to print_oops_end_marker() in kernel/panic.c.  Before
> > e83a4472bf9f ("panic: remove oops_id"), it was an oops ID.  My parsing script
> > doesn't rely on the 16 '0's but existing parsers might.
> > 
> > I have no strong opinion.  Should we just remove the 16 '0's here?
> 
> These are warning messages, not panic. So I would prefer not to have them if
> they serve no useful purpose and can cause confusion.

Ack, fixed in v3[1].

[1] https://lore.kernel.org/all/20251217052353.1489154-1-tzungbi@kernel.org/T/#u

      reply	other threads:[~2025-12-17  5:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20251215072640.2580384-1-tzungbi@kernel.org>
2025-12-16  1:03 ` [PATCH v2] lockdep: Add header and footer to surround warning reports Tzung-Bi Shih
     [not found] ` <0ae3277b-bea5-40ce-8eaa-10bb8b47c46a@redhat.com>
2025-12-17  0:31   ` Tzung-Bi Shih
2025-12-17  2:57     ` Waiman Long
2025-12-17  5:26       ` Tzung-Bi Shih [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aUI_Bf6ZARxxtGyG@google.com \
    --to=tzungbi@kernel.org \
    --cc=boqun.feng@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llong@redhat.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.