From: Baoquan He <bhe@redhat.com>
To: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Vishal Moola <vishal.moola@gmail.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] mm/vmalloc: Add attempt_larger_order_alloc parameter
Date: Wed, 17 Dec 2025 11:54:26 +0800 [thread overview]
Message-ID: <aUIpciUKUeclNk2s@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20251216211921.1401147-2-urezki@gmail.com>
Hi Uladzislau,
On 12/16/25 at 10:19pm, Uladzislau Rezki (Sony) wrote:
> Introduce a module parameter to enable or disable the large-order
> allocation path in vmalloc. High-order allocations are disabled by
> default so far, but users may explicitly enable them at runtime if
> desired.
>
> High-order pages allocated for vmalloc are immediately split into
> order-0 pages and later freed as order-0, which means they do not
> feed the per-CPU page caches. As a result, high-order attempts tend
I don't get why order-0 do not feed the PCP caches.
> to bypass the PCP fastpath and fall back to the buddy allocator that
> can affect performance.
>
> However, when the PCP caches are empty, high-order allocations may
> show better performance characteristics especially for larger
> allocation requests.
And when PCP is empty, high-order alloc show better performance. Could
you please help elaborate a little more about them? Thanks.
Thanks
Baoquan
>
> Since the best strategy is workload-dependent, this patch adds a
> parameter letting users to choose whether vmalloc should try
> high-order allocations or stay strictly on the order-0 fastpath.
>
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
> ---
> mm/vmalloc.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index d3a4725e15ca..f66543896b16 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -43,6 +43,7 @@
> #include <asm/tlbflush.h>
> #include <asm/shmparam.h>
> #include <linux/page_owner.h>
> +#include <linux/moduleparam.h>
>
> #define CREATE_TRACE_POINTS
> #include <trace/events/vmalloc.h>
> @@ -3671,6 +3672,9 @@ vm_area_alloc_pages_large_order(gfp_t gfp, int nid, unsigned int order,
> return nr_allocated;
> }
>
> +static int attempt_larger_order_alloc;
> +module_param(attempt_larger_order_alloc, int, 0644);
> +
> static inline unsigned int
> vm_area_alloc_pages(gfp_t gfp, int nid,
> unsigned int order, unsigned int nr_pages, struct page **pages)
> @@ -3679,8 +3683,9 @@ vm_area_alloc_pages(gfp_t gfp, int nid,
> struct page *page;
> int i;
>
> - nr_allocated = vm_area_alloc_pages_large_order(gfp, nid,
> - order, nr_pages, pages);
> + if (attempt_larger_order_alloc)
> + nr_allocated = vm_area_alloc_pages_large_order(gfp, nid,
> + order, nr_pages, pages);
>
> /*
> * For order-0 pages we make use of bulk allocator, if
> --
> 2.47.3
>
next prev parent reply other threads:[~2025-12-17 3:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 21:19 [PATCH 1/2] mm/vmalloc: Add large-order allocation helper Uladzislau Rezki (Sony)
2025-12-16 21:19 ` [PATCH 2/2] mm/vmalloc: Add attempt_larger_order_alloc parameter Uladzislau Rezki (Sony)
2025-12-16 23:36 ` Andrew Morton
2025-12-17 11:37 ` Uladzislau Rezki
2025-12-17 3:54 ` Baoquan He [this message]
2025-12-17 11:44 ` Uladzislau Rezki
2025-12-17 11:49 ` Dev Jain
2025-12-17 11:53 ` Uladzislau Rezki
2025-12-18 10:34 ` Baoquan He
2025-12-17 8:27 ` Ryan Roberts
2025-12-17 12:02 ` Uladzislau Rezki
2025-12-17 15:20 ` Ryan Roberts
2025-12-17 17:01 ` Ryan Roberts
2025-12-17 19:22 ` Uladzislau Rezki
2025-12-18 11:12 ` Ryan Roberts
2025-12-18 11:33 ` Uladzislau Rezki
2025-12-17 20:08 ` Uladzislau Rezki
2025-12-18 11:14 ` Ryan Roberts
2025-12-18 11:29 ` Uladzislau Rezki
2025-12-18 4:55 ` Dev Jain
2025-12-18 11:53 ` Ryan Roberts
2025-12-18 11:56 ` Ryan Roberts
2025-12-19 8:33 ` David Hildenbrand (Red Hat)
2025-12-19 11:17 ` Ryan Roberts
2025-12-19 0:34 ` Vishal Moola (Oracle)
2025-12-19 11:23 ` Ryan Roberts
2025-12-24 6:35 ` Dev Jain
-- strict thread matches above, loose matches on Subject: below --
2025-12-20 13:46 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUIpciUKUeclNk2s@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dev.jain@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=urezki@gmail.com \
--cc=vishal.moola@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.