All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	Anthony PERARD <anthony.perard@vates.tech>,
	Michal Orzel <michal.orzel@amd.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 2/4] tools/libxc: Delete ENOSYS squashing in xc_domain_claim_pages()
Date: Wed, 17 Dec 2025 17:29:31 +0100	[thread overview]
Message-ID: <aULaa1EVjOYZL7-F@Mac.lan> (raw)
In-Reply-To: <20251216163230.2768186-3-andrew.cooper3@citrix.com>

On Tue, Dec 16, 2025 at 04:32:28PM +0000, Andrew Cooper wrote:
> It's not acceptable to hide this from the caller; the effect of doing so is to
> break an atomicity expectation.
> 
> Only the caller can know what the appropriate safety action is in the case
> that the claim hypercall isn't available.
> 
> Fixes: fc67e9dc0c1f ("xc: use XENMEM_claim_pages hypercall during guest creation.")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


  reply	other threads:[~2025-12-17 16:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-16 16:32 [PATCH 0/4] xen: Memory claims fixes and testing Andrew Cooper
2025-12-16 16:32 ` [PATCH 1/4] xen/domain: Disallow XENMEM_claim_pages on dying domains Andrew Cooper
2025-12-17  8:00   ` Jan Beulich
2025-12-16 16:32 ` [PATCH 2/4] tools/libxc: Delete ENOSYS squashing in xc_domain_claim_pages() Andrew Cooper
2025-12-17 16:29   ` Roger Pau Monné [this message]
2025-12-16 16:32 ` [PATCH 3/4] tools/tests: Sort Makefile Andrew Cooper
2025-12-17 16:30   ` Roger Pau Monné
2025-12-16 16:32 ` [PATCH 4/4] tools/tests: Memory Claims Andrew Cooper
2025-12-17 17:01   ` Roger Pau Monné
2025-12-17 17:22     ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aULaa1EVjOYZL7-F@Mac.lan \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony.perard@vates.tech \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.