From: Johannes Weiner <hannes@cmpxchg.org>
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
Deepanshu Kartikey <kartikey406@gmail.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: retiring laptop_mode? was Re: [PATCH] mm: vmscan: always allow writeback during memcg reclaim
Date: Wed, 17 Dec 2025 14:59:20 -0500 [thread overview]
Message-ID: <aUMLmJ0En24pQBX_@cmpxchg.org> (raw)
In-Reply-To: <gweo3wdh3agfavhiky5cloweu4m2hvgzk2j2euckbka5x7n47e@ezjmx7eq7ks5>
On Tue, Dec 16, 2025 at 03:23:53PM -0800, Shakeel Butt wrote:
> On Tue, Dec 16, 2025 at 01:52:01PM -0500, Johannes Weiner wrote:
> Reviewed-by: Shakeel Butt <shakeel.butt@linux.dev>
Thanks!
> > --- a/include/uapi/linux/sysctl.h
> > +++ b/include/uapi/linux/sysctl.h
> > @@ -183,7 +183,7 @@ enum
> > VM_LOWMEM_RESERVE_RATIO=20,/* reservation ratio for lower memory zones */
> > VM_MIN_FREE_KBYTES=21, /* Minimum free kilobytes to maintain */
> > VM_MAX_MAP_COUNT=22, /* int: Maximum number of mmaps/address-space */
> > - VM_LAPTOP_MODE=23, /* vm laptop mode */
> > +
>
> There are 8 earlier enums here with names like VM_UNUSED* along with
> the information on what were they. Should we have something similar for
> this one? Something like:
>
> VM_UNUSED10=23, /* was vm laptop mode */
The other enums in that file leave holes, the VM ones have a mix of
VM_UNUSED and holes. I don't think it matters either way since the
sysctl syscall has been removed and nothing new should be compiled
against the definitions in this file, right?
next prev parent reply other threads:[~2025-12-17 19:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-13 8:36 [PATCH] mm: vmscan: always allow writeback during memcg reclaim Deepanshu Kartikey
2025-12-14 23:49 ` Andrew Morton
2025-12-15 4:12 ` Johannes Weiner
2025-12-15 4:51 ` Deepanshu Kartikey
2025-12-15 19:42 ` Yuanchu Xie
2025-12-15 20:22 ` Johannes Weiner
2025-12-19 5:13 ` Kairui Song
2025-12-15 6:59 ` retiring laptop_mode? was " Christoph Hellwig
2025-12-15 16:33 ` Jens Axboe
2025-12-15 20:08 ` Johannes Weiner
2025-12-16 2:23 ` Jens Axboe
2025-12-16 7:41 ` Christoph Hellwig
2025-12-16 18:52 ` Johannes Weiner
2025-12-16 18:54 ` Jens Axboe
2025-12-16 23:23 ` Shakeel Butt
2025-12-17 19:59 ` Johannes Weiner [this message]
2025-12-18 7:21 ` Shakeel Butt
2025-12-17 19:34 ` Michal Hocko
2025-12-18 6:00 ` Christoph Hellwig
2025-12-15 17:49 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUMLmJ0En24pQBX_@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=kartikey406@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shakeel.butt@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.