Re: [PATCH] VFS: fix dentry_create() kernel-doc comment

[Bagas Sanjaya <bagasdotme@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 882 bytes --]

On Thu, Dec 18, 2025 at 06:10:56AM +0000, Al Viro wrote:
> The first one might be borderline sane (I'd probably go for O_... instead
> of O_, but whatever); the second is not.

Or O_\* flags?

> 
> Forget kernel-doc; what is that phrase supposed to mean in the
> first place?  "struct file *" (in quotes, for whatever reason)
> would presumably imply a value of mentioned type; a function
> declared as
> struct file *dentry_create(const struct path *path, int flags, umode_t mode,
>                            const struct cred *cred)
> *always* returns a value of that type, TYVM.
> 
> I'm not a native speaker, but I'd suggest something along the lines
> of "a pointer to opened file" as replacement for that (without
> quote marks, obviously).

Ack. Will apply your suggestions in v2.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]