From: Johan Hovold <johan@kernel.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Vladimir Zapolskiy <vz@mleia.com>,
Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>,
Ma Ke <make24@iscas.ac.cn>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] usb: ohci-nxp: clean up probe error labels
Date: Thu, 18 Dec 2025 16:20:05 +0100 [thread overview]
Message-ID: <aUQbpVyfEF0yrWSX@hovoldconsulting.com> (raw)
In-Reply-To: <a23e4407-9017-449c-a514-6e9464ec0266@rowland.harvard.edu>
On Thu, Dec 18, 2025 at 10:09:52AM -0500, Alan Stern wrote:
> On Thu, Dec 18, 2025 at 03:19:45PM +0100, Johan Hovold wrote:
> > Error labels should be named after what they do rather than after from
> > where they are jumped to.
> >
> > Rename the probe error labels for consistency and to improve
> > readability.
> >
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
>
> Johan, in the 3/5 patch you also changed a statement label, which was
> not directly related to that patch's actual purpose, but it is directly
> related to this one's. Can you move that rename from that patch to this
> one?
Sure. The label "fail_disable" didn't make any sense to me but looking
at the driver again now I see that it's named after the usb_disabled()
check and the rename could indeed be done as part of this patch.
I'll address this in a v2.
Johan
prev parent reply other threads:[~2025-12-18 15:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 14:19 [PATCH 0/5] USB: lpc32xx: fix error handling Johan Hovold
2025-12-18 14:19 ` [PATCH 1/5] usb: gadget: lpc32xx_udc: fix clock imbalance in error path Johan Hovold
2025-12-18 14:19 ` [PATCH 2/5] usb: phy: isp1301: fix non-OF device reference imbalance Johan Hovold
2025-12-18 14:19 ` [PATCH 3/5] usb: ohci-nxp: fix device leak on probe failure Johan Hovold
2025-12-18 14:19 ` [PATCH 4/5] usb: gadget: lpc32xx_udc: clean up probe error labels Johan Hovold
2025-12-18 14:19 ` [PATCH 5/5] usb: ohci-nxp: " Johan Hovold
2025-12-18 15:09 ` Alan Stern
2025-12-18 15:20 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUQbpVyfEF0yrWSX@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=piotr.wojtaszczyk@timesys.com \
--cc=stern@rowland.harvard.edu \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.