From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E20E2D0C66; Fri, 19 Dec 2025 05:30:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766122222; cv=none; b=BrW5m56y5lybwbcb/JevstFoqnULvStwcavYp0OTXJgSHRXG/mgOZDTQ5+HKLB+WMBDwIYGdCtwN2BGfYWpOmoIw+53sajWaQV1THtSlZf0N1JY3TQR2uU8GA5R2ULUGFPtQCLL9A3FTV9BooCoOLw2Qmr0jfgFpzE5rbHbwbYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766122222; c=relaxed/simple; bh=3uLlaz4Cn7+HUm7Xt16u1J4mpkJgct757cwKa4FuZko=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NVdszgVJrhlzoXyQ9Nn44Ldp9vbAApt50ixur3lfmB8dOIUhRF12fI9Z9MbP2mNk/3A9yZm4SMwpQAP+NtqBsrBbLyHgAqc2VciDcQkjpwZjtTRcNlecsqu60icti8mxzNsxb0gSKoDqk2LdSyggKK9EnoKBqlk2HNEKRT5rVPg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=rxoP4dEM; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="rxoP4dEM" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yBdvfHBasrnEFTF070cSt/emoT+E7CbdyD7j8s+6u7Q=; b=rxoP4dEMkOJwSZVmdT3KZhBcDW aSF7Qi1XqLcC2/Yx3sl5HWOKYAQVVhU3uvM3w+Ip8tmcMEXMVGuhWugrpmaL72N/J41wlmDy1QPU3 BiKLIXXqMGXHhAxWhdJ7jVZpraDMX98s1V4DAnonFCx6OIrElZlP8/io7XXoxleY+JdPYDtCAJ99j vJtX+r4/VtBxD+qfe6H7i8Scu0isQrNe3xMMTrMMUaffDLtLL9ST4BXMLMFF8lziCUtS9KNFNW0/X vl7rWBCBd+/LXSw4q66w4f+J0fDmRrL8LPNcuaiKiqDYUyxxPZ8s5hwPufIX2miSKipo4VxanK3SP hfSxbYHw==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vWT48-00000009eLX-0v3v; Fri, 19 Dec 2025 05:30:13 +0000 Date: Thu, 18 Dec 2025 21:30:12 -0800 From: Christoph Hellwig To: Joanne Chang Cc: Christoph Hellwig , Zorro Lang , fstests@vger.kernel.org, Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net, Chao Yu , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v1] generic/735: disable for f2fs Message-ID: References: <20251218071717.2573035-1-joannechien@google.com> Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Thu, Dec 18, 2025 at 08:02:48PM +0800, Joanne Chang wrote: > Thank you for the feedback. I will implement a > _require_blocks_in_file helper in the next version. As far as I > know, there isn't a generic way to query the block number limit > across filesystems, so I plan to hardcode the known limit for > F2FS within the helper for now. Oh, the limits is not the file size per se, so the number of blocks? I.e. you can have a 64-bit i_size, but if the file isn't spare it eventually can't fill holes? That really does seem like behavior applications would not not expect, aka a bug. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62EEAD74956 for ; Fri, 19 Dec 2025 05:30:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P3xwDvhEEAGUUCnhwb1PjVPi2E29z1JZMj57oBHlg/8=; b=A4hJPGkL5n16gapEEBxLbzwnuF IHQCAK1lqnbCxze9jE+Vfqf8rsDrPVES3CgFU+FLvQzbvu00EBPQdNl00A04Vmm4k4UJwtUEnopvy K707yuWnAMJ9N9DvzQuzvZBlfNIwphdNd0GCVZug9hp8zoR1g0EBB66jpi+qAOHqM6bk=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vWT4R-0008N4-8q; Fri, 19 Dec 2025 05:30:31 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vWT4G-0008Mr-98 for linux-f2fs-devel@lists.sourceforge.net; Fri, 19 Dec 2025 05:30:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yBdvfHBasrnEFTF070cSt/emoT+E7CbdyD7j8s+6u7Q=; b=LBMVzmwPvAB3Q+omn0wKQJJlDd veFsIoNn1EjR4vmuZCUrwHfn31fkeUqw6oHalBUj/z48Ymq/PZ5i9jCkRNfltaCQ7i8LjWbImnYEL y/nWoDVWqhBA0ftwNICVHXugKkLD6jQsHx2Cheq12o5qsIkvaW1cDE+n7RuF9iKwzVkk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yBdvfHBasrnEFTF070cSt/emoT+E7CbdyD7j8s+6u7Q=; b=IZ/YB7kf/4S0bhb/rbrF2btB1U ozKVFbXUpRX3dNdmoy5KNP0BjKQjHufyjxHGvbtejpUs3FFSEu6Wcrl6wDJMnERW9P8VYsEleuEQz 1N2v5iW+Hryu8UrwAFOYKbtm2OBbZ2DEmkj/TCnITii+M1V79zApP7tbAppJwXO5ryJQ=; Received: from bombadil.infradead.org ([198.137.202.133]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vWT4E-0003o4-VM for linux-f2fs-devel@lists.sourceforge.net; Fri, 19 Dec 2025 05:30:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yBdvfHBasrnEFTF070cSt/emoT+E7CbdyD7j8s+6u7Q=; b=rxoP4dEMkOJwSZVmdT3KZhBcDW aSF7Qi1XqLcC2/Yx3sl5HWOKYAQVVhU3uvM3w+Ip8tmcMEXMVGuhWugrpmaL72N/J41wlmDy1QPU3 BiKLIXXqMGXHhAxWhdJ7jVZpraDMX98s1V4DAnonFCx6OIrElZlP8/io7XXoxleY+JdPYDtCAJ99j vJtX+r4/VtBxD+qfe6H7i8Scu0isQrNe3xMMTrMMUaffDLtLL9ST4BXMLMFF8lziCUtS9KNFNW0/X vl7rWBCBd+/LXSw4q66w4f+J0fDmRrL8LPNcuaiKiqDYUyxxPZ8s5hwPufIX2miSKipo4VxanK3SP hfSxbYHw==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vWT48-00000009eLX-0v3v; Fri, 19 Dec 2025 05:30:13 +0000 Date: Thu, 18 Dec 2025 21:30:12 -0800 From: Christoph Hellwig To: Joanne Chang Message-ID: References: <20251218071717.2573035-1-joannechien@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Headers-End: 1vWT4E-0003o4-VM Subject: Re: [f2fs-dev] [PATCH v1] generic/735: disable for f2fs X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zorro Lang , fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Christoph Hellwig , linux-fsdevel@vger.kernel.org, Jaegeuk Kim Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Thu, Dec 18, 2025 at 08:02:48PM +0800, Joanne Chang wrote: > Thank you for the feedback. I will implement a > _require_blocks_in_file helper in the next version. As far as I > know, there isn't a generic way to query the block number limit > across filesystems, so I plan to hardcode the known limit for > F2FS within the helper for now. Oh, the limits is not the file size per se, so the number of blocks? I.e. you can have a 64-bit i_size, but if the file isn't spare it eventually can't fill holes? That really does seem like behavior applications would not not expect, aka a bug. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel