Re: [PATCH v3 2/2] drm/xe/xe_survivability: Add index bound check

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Dec 19, 2025 at 04:22:27PM +0530, Riana Tauro wrote:
> Fix static analysis tool reported issue. Add index bound check before
> accessing info array to prevent out of bound.
> 
> Fixes: f4e9fc967afd ("drm/xe/xe_survivability: Redesign survivability mode")
> Signed-off-by: Riana Tauro <riana.tauro@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_survivability_mode.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.c b/drivers/gpu/drm/xe/xe_survivability_mode.c
> index e6e326dfb92b..ce55859a9a84 100644
> --- a/drivers/gpu/drm/xe/xe_survivability_mode.c
> +++ b/drivers/gpu/drm/xe/xe_survivability_mode.c
> @@ -258,10 +258,14 @@ static umode_t survivability_info_attrs_visible(struct kobject *kobj, struct att
>  	struct xe_survivability *survivability = &xe->survivability;
>  	u32 *info = survivability->info;
>  
> -	/* FDO mode is visible only when supported */
> -	if (idx >= MAX_SCRATCH_REG && survivability->version >= 2)
> +	/*
> +	 * Last index in survivability_info_attrs is fdo mode and is applicable only in
> +	 * version 2 of survivability mode
> +	 */
> +	if (idx == MAX_SCRATCH_REG && survivability->version >= 2)
>  		return 0400;
> -	else if (info[idx])
> +
> +	if (idx < MAX_SCRATCH_REG && info[idx])
>  		return 0400;
>  
>  	return 0;
> -- 
> 2.47.1
>