From: Sean Christopherson <seanjc@google.com>
To: Alessandro Ratti <alessandro@0x65c.net>
Cc: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>, kvm@vger.kernel.org
Subject: Re: Status of "Drop nested support for CPUs without NRIPS" patch
Date: Fri, 19 Dec 2025 10:44:38 -0800 [thread overview]
Message-ID: <aUWdFmtzhcOKUzIu@google.com> (raw)
In-Reply-To: <CAKiXHKdbs_+yFZGKkKYsHKwAwCZSTzeVdLJXk1amKzm7fGcPNg@mail.gmail.com>
On Sun, Dec 14, 2025, Alessandro Ratti wrote:
> Hi,
>
> I was investigating the TODO in svm_check_intercept() about advertising
> NRIPS unconditionally, and found an old patch by Sean Christopherson
> (with Maciej S. Szmigiero's sign-off) that simply requires NRIPS for
> nested virtualization rather than trying to emulate it.
>
> Link: https://lore.kernel.org/kvm/f0302382cf45d7a9527b4aebbfe694bbcfa7aff5.1651440202.git.maciej.szmigiero@oracle.com/
>
> Is there a reason this approach wasn't taken? Was there pushback on
> dropping support for pre-2009 CPUs, or did it just fall through the
> cracks?
Both Maxim[1] and Maciej lightly objected[2], and in the end dropping support
for CPUs without NRIPS barely moves the needle in terms of complexity.
[1] https://lore.kernel.org/kvm/2327614a18d60a5e1b0d9d3aed754cccebce3117.camel@redhat.com
[2] https://lore.kernel.org/kvm/656aaf33-8c70-8b06-2cdc-fd2685a1348b@maciej.szmigiero.name
> If the approach is still acceptable, I'd be happy to refresh and test
> the patch.
Let's just leave things as-is for now. Dealing with NRIPS=0 CPUs was annoying
when fixing the soft-int reinjection issues, but it hasn't meaningfully impacted
maintenance in the ~3 years since (which isn't suprising give how little code is
saved by ripping it out).
Thank you for the offer though!
prev parent reply other threads:[~2025-12-19 18:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-14 16:08 Status of "Drop nested support for CPUs without NRIPS" patch Alessandro Ratti
2025-12-19 18:44 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUWdFmtzhcOKUzIu@google.com \
--to=seanjc@google.com \
--cc=alessandro@0x65c.net \
--cc=kvm@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.