All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Yuto Hamaguchi <Hamaguchi.Yuto@da.mitsubishielectric.co.jp>,
	kadlec@netfilter.org, netfilter-devel@vger.kernel.org,
	coreteam@netfilter.org, netdev@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nf_conntrack: Add allow_clash to generic protocol handler
Date: Mon, 22 Dec 2025 11:32:31 +0100	[thread overview]
Message-ID: <aUkeP0xzUcPjWwX-@chamomile> (raw)
In-Reply-To: <aUcBp4VuHTPqCdEt@strlen.de>

On Sat, Dec 20, 2025 at 09:05:59PM +0100, Florian Westphal wrote:
> Yuto Hamaguchi <Hamaguchi.Yuto@da.MitsubishiElectric.co.jp> wrote:
> > The upstream commit, 71d8c47fc653711c41bc3282e5b0e605b3727956
> >  ("netfilter: conntrack: introduce clash resolution on insertion race"),
> > sets allow_clash=true in the UDP/UDPLITE protocol handler
> > but does not set it in the generic protocol handler.
> > 
> > As a result, packets composed of connectionless protocols at each layer,
> > such as UDP over IP-in-IP, still drop packets due to conflicts during conntrack insertion.
> > 
> > To resolve this, this patch sets allow_clash in the nf_conntrack_l4proto_generic.
> 
> Makes sense to me, thanks.

Would it be possible to follow a more conservative approach?
ie. restrict this to protocols where we know clashes are possible
such as IPIP.

  reply	other threads:[~2025-12-22 10:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-19 11:53 [PATCH nf] netfilter: nf_conntrack: Add allow_clash to generic protocol handler Yuto Hamaguchi
2025-12-20 20:05 ` Florian Westphal
2025-12-22 10:32   ` Pablo Neira Ayuso [this message]
2025-12-22 11:22     ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aUkeP0xzUcPjWwX-@chamomile \
    --to=pablo@netfilter.org \
    --cc=Hamaguchi.Yuto@da.mitsubishielectric.co.jp \
    --cc=coreteam@netfilter.org \
    --cc=fw@strlen.de \
    --cc=kadlec@netfilter.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.