From: Christoph Hellwig <hch@infradead.org>
To: Anna Schumaker <anna@kernel.org>
Cc: linux-nfs@vger.kernel.org, trond.myklebust@hammerspace.com
Subject: Re: [PATCH] NFS: Fix directory delegation verifier checks
Date: Mon, 22 Dec 2025 14:35:10 -0800 [thread overview]
Message-ID: <aUnHnlnDtwMJGP3u@infradead.org> (raw)
In-Reply-To: <20251219201344.380279-1-anna@kernel.org>
On Fri, Dec 19, 2025 at 03:13:44PM -0500, Anna Schumaker wrote:
> From: Anna Schumaker <anna.schumaker@oracle.com>
>
> Doing this check in nfs_check_verifier() resulted in many, many more
> lookups on the wire when running Christoph's delegation benchmarking
> script. After some experimentation, I found that we can treat directory
> delegations exactly the same as having a delegated verifier when we
> reach nfs4_lookup_revalidate() for the best performance.
>
> Reported-by: Christoph Hellwig <hch@lst.de>
> Fixes: 156b09482933 ("NFS: Request a directory delegation on ACCESS, CREATE, and UNLINK")
> Signed-off-by: Anna Schumaker <anna.schumaker@oracle.com>
I wish I could actually review this, but I don't actually understand
the lookup revalidation logic enough for that. But it does fix the
problem I saw, so at least:
Tested-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-12-22 22:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 20:13 [PATCH] NFS: Fix directory delegation verifier checks Anna Schumaker
2025-12-22 22:35 ` Christoph Hellwig [this message]
2025-12-23 1:06 ` Christoph Hellwig
2025-12-31 21:52 ` Trond Myklebust
2026-01-06 6:21 ` hch@infradead.ori
2026-01-06 18:32 ` Trond Myklebust
2026-01-07 5:23 ` hch@infradead.ori
2026-01-07 15:07 ` Trond Myklebust
2026-01-07 15:30 ` hch@infradead.ori
2026-01-08 9:23 ` hch@infradead.ori
2026-01-07 16:52 ` Anna Schumaker
2026-04-04 18:32 ` Al Viro
2026-04-04 19:07 ` Al Viro
2026-04-05 2:39 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUnHnlnDtwMJGP3u@infradead.org \
--to=hch@infradead.org \
--cc=anna@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.