From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ryota Sakamoto <sakamo.ryota@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <chleroy@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
David Gow <davidgow@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/tests: convert test_min_heap module to KUnit
Date: Tue, 23 Dec 2025 17:03:29 +0800 [thread overview]
Message-ID: <aUpa4UiSPaSgzD3x@google.com> (raw)
In-Reply-To: <20251222171654.6bb93c772166409209275583@linux-foundation.org>
On Mon, Dec 22, 2025 at 05:16:54PM -0800, Andrew Morton wrote:
> On Tue, 23 Dec 2025 00:42:11 +0900 Ryota Sakamoto <sakamo.ryota@gmail.com> wrote:
>
> > The reasons for converting to KUnit are:
> > 1. Standardization:
> > Switching from ad-hoc printk-based reporting to the standard KTAP
> > format makes
> > it easier for CI systems to parse and report test results
> > 2. Better Diagnostics:
> > Using KUNIT_EXPECT_* macros automatically provides detailed
> > diagnostics on failure.
> > 3. Tooling Integration:
> > It allows the test to be managed and executed using standard KUnit tools.
> >
> > Hi Andrew,
> >
> > Since this patch is already in your mm-nonmm-unstable tree, would you
> > prefer me to send
> > a v2 patch with the updated commit message, or could you kindly fold
> > these explanations
> > into the commit log?
>
> I pasted the above into this patch's changelog, thanks.
With the updated commit message:
Acked-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Regards,
Kuan-Wei
prev parent reply other threads:[~2025-12-23 9:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-21 13:35 [PATCH] lib/tests: convert test_min_heap module to KUnit Ryota Sakamoto
2025-12-22 3:50 ` Kuan-Wei Chiu
2025-12-22 15:42 ` Ryota Sakamoto
2025-12-23 1:16 ` Andrew Morton
2025-12-23 9:03 ` Kuan-Wei Chiu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUpa4UiSPaSgzD3x@google.com \
--to=visitorckw@gmail.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@linux.ibm.com \
--cc=chleroy@kernel.org \
--cc=davidgow@google.com \
--cc=geert@linux-m68k.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=sakamo.ryota@gmail.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.