Re: [PATCH 6/6] monitor/hmp: Merge hmp-cmds-target.c within hmp-cmds.c

["Dr. David Alan Gilbert" <dave@treblig.org>]

* Philippe Mathieu-Daudé (philmd@linaro.org) wrote:
> On 24/12/25 15:24, Manos Pitsidianakis wrote:
> > On Wed, Dec 24, 2025 at 3:40 PM Philippe Mathieu-Daudé
> > <philmd@linaro.org> wrote:
> > > 
> > > hmp-cmds-target.c is no more target specific, move its code
> > > in hmp-cmds.c, which is built once for all system binaries.
> > > 
> > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > > ---
> > >   monitor/hmp-cmds-target.c | 383 --------------------------------------
> > >   monitor/hmp-cmds.c        | 354 +++++++++++++++++++++++++++++++++++
> > >   monitor/meson.build       |   2 +-
> > >   3 files changed, 355 insertions(+), 384 deletions(-)
> > >   delete mode 100644 monitor/hmp-cmds-target.c
> 
> 
> > > diff --git a/monitor/meson.build b/monitor/meson.build
> > > index a71523a1ce8..763fcaba6c5 100644
> > > --- a/monitor/meson.build
> > > +++ b/monitor/meson.build
> > > @@ -9,4 +9,4 @@ system_ss.add(files(
> > >   system_ss.add([spice_headers, files('qmp-cmds.c')])
> > > 
> > >   specific_ss.add(when: 'CONFIG_SYSTEM_ONLY',
> > > -               if_true: [files( 'hmp-cmds-target.c', 'hmp-target.c'), spice])
> > > +  if_true: [files('hmp-target.c'), spice])
> > 
> > Nit: Indentation?
> 
> We usually don't use tabs in meson.build files, and indent as 2 spaces,
> but I couldn't find any documented style enforcement :/

Looking at ui/meson.build and audio/meson.build, it looks like if_true: on
separate lines are generally aligned with the (
(ish....)

Dave

> Paolo, Marc-André, any preference?
> 
> > 
> > Otherwise
> > 
> > Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
> 
> Thanks!
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/