All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Fan <peng.fan@oss.nxp.com>
To: Tanmay Kathpalia <tanmay.kathpalia@altera.com>
Cc: u-boot@lists.denx.de, peng.fan@nxp.com, jh80.chung@samsung.com,
	trini@konsulko.com, marex@denx.de, tien.fong.chee@altera.com,
	festevam@gmail.com, ivitro@gmail.com,
	max.merchel@ew.tq-group.com
Subject: Re: [PATCH v1] Revert "mmc: mmc-uclass: Use max-frequency from device tree with default handling"
Date: Thu, 8 Jan 2026 21:21:48 +0800	[thread overview]
Message-ID: <aV+vbNSYV9qlJChg@shlinux89> (raw)
In-Reply-To: <20260108114002.1612-1-tanmay.kathpalia@altera.com>

On Thu, Jan 08, 2026 at 03:40:02AM -0800, Tanmay Kathpalia wrote:
>This reverts commit aebb523a23818a8ee4199c9532b51e3d4020696f.
>
>The change to use dev_read_u32_default() with a default value of 0
>causes regression for host controller drivers that hardcode f_max
>before calling mmc_of_parse().
>
>When the "max-frequency" property is not specified in the device tree,
>dev_read_u32_default() returns 0, which overwrites the previously
>configured f_max value set by the driver. This effectively resets
>the maximum frequency to 0, breaking MMC functionality for those
>controllers.
>
>Revert to the original dev_read_u32() behavior which only updates
>cfg->f_max when the "max-frequency" property is explicitly present
>in the device tree, preserving driver-configured values otherwise.
>
>Signed-off-by: Tanmay Kathpalia <tanmay.kathpalia@altera.com>

Applied.

Thanks,
Peng

  reply	other threads:[~2026-01-08 13:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-08 11:40 [PATCH v1] Revert "mmc: mmc-uclass: Use max-frequency from device tree with default handling" Tanmay Kathpalia
2026-01-08 13:21 ` Peng Fan [this message]
2026-01-08 23:21 ` Marek Vasut
2026-01-15  9:39   ` Tanmay Kathpalia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aV+vbNSYV9qlJChg@shlinux89 \
    --to=peng.fan@oss.nxp.com \
    --cc=festevam@gmail.com \
    --cc=ivitro@gmail.com \
    --cc=jh80.chung@samsung.com \
    --cc=marex@denx.de \
    --cc=max.merchel@ew.tq-group.com \
    --cc=peng.fan@nxp.com \
    --cc=tanmay.kathpalia@altera.com \
    --cc=tien.fong.chee@altera.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.