From: Peng Fan <peng.fan@oss.nxp.com>
To: Marek Vasut <marex@nabladev.com>
Cc: linux-arm-kernel@lists.infradead.org,
Fedor Ross <fedor.ross@ifm.com>,
Christian Eggers <ceggers@arri.de>,
Conor Dooley <conor+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Markus Heidelberg <m.heidelberg@cab.de>,
Rob Herring <robh@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/4] arm64: dts: imx8mn: Add ifm VHIP4 EvalBoard v1 and v2
Date: Tue, 6 Jan 2026 22:37:03 +0800 [thread overview]
Message-ID: <aV0eD4t5uQeAokUF@shlinux89> (raw)
In-Reply-To: <20251230213401.219808-4-marex@nabladev.com>
Hi Marek,
Sorry for jumping in at V4.
On Tue, Dec 30, 2025 at 10:32:34PM +0100, Marek Vasut wrote:
>From: Fedor Ross <fedor.ross@ifm.com>
>
...
>+
>+&ecspi1 {
>+ pinctrl-names = "default", "cs";
>+ pinctrl-0 = <&pinctrl_ecspi1>;
>+ pinctrl-1 = <&pinctrl_ecspi1_cs>;
Not get the point of using a separate pinctrl for "cs",
I not see driver using it, or I may miss someting.
>+ /delete-property/ dmas;
>+ /delete-property/ dma-names;
Why disable DMA here?
>+};
>+
>+&ecspi3 {
>+ pinctrl-names = "default", "cs";
>+ pinctrl-0 = <&pinctrl_ecspi3>;
>+ pinctrl-1 = <&pinctrl_ecspi3_cs>;
>+ /delete-property/ dmas;
>+ /delete-property/ dma-names;
Ditto.
>+};
>+
Regards
Peng
next prev parent reply other threads:[~2026-01-06 14:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 21:32 [PATCH v4 1/4] dt-bindings: vendor-prefixes: Document ifm electronic gmbh Marek Vasut
2025-12-30 21:32 ` [PATCH v4 2/4] dt-bindings: arm: fsl: Document ifm VHIP4 EvalBoard v1 and v2 Marek Vasut
2025-12-30 21:32 ` [PATCH v4 3/4] arm64: dts: imx8mn: Add SNVS LPGPR Marek Vasut
2026-01-06 14:08 ` Peng Fan
2025-12-30 21:32 ` [PATCH v4 4/4] arm64: dts: imx8mn: Add ifm VHIP4 EvalBoard v1 and v2 Marek Vasut
2026-01-06 14:37 ` Peng Fan [this message]
2026-01-06 16:00 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aV0eD4t5uQeAokUF@shlinux89 \
--to=peng.fan@oss.nxp.com \
--cc=ceggers@arri.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fedor.ross@ifm.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.heidelberg@cab.de \
--cc=marex@nabladev.com \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.