All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Prasad Pandit <ppandit@redhat.com>
Cc: Fabiano Rosas <farosas@suse.de>,
	qemu-devel@nongnu.org, Prasad Pandit <pjp@fedoraproject.org>
Subject: Re: [PATCH] migration: introduce MIGRATION_STATUS_FAILING
Date: Tue, 6 Jan 2026 09:53:22 -0500	[thread overview]
Message-ID: <aV0h4siUlTSqJHaG@x1.local> (raw)
In-Reply-To: <CAE8KmOwgDboiN-q=jt0Jic4Gqdsp49nyRC7iwKrQokdP3h9yVg@mail.gmail.com>

On Tue, Jan 06, 2026 at 04:24:23PM +0530, Prasad Pandit wrote:
> Hi,
> 
> On Tue, 23 Dec 2025 at 20:34, Fabiano Rosas <farosas@suse.de> wrote:
> > Yep, 10 years from now someone will look at the code and the commit
> > message and be confused when they don't match. Also, for anyone
> > backporting or searching for bug fixes, it's good to keep things tight.
> >
> 
> * Looking at how we are changing function names, I think it is best to
> avoid stack traces in commit messages.

Please always attach a backtrace when available.  One can always checkout
the specific commit with all the correct function names.  Renaming is never
an issue.

Thanks,

-- 
Peter Xu



  reply	other threads:[~2026-01-06 14:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-22 11:48 [PATCH] migration: introduce MIGRATION_STATUS_FAILING Prasad Pandit
2025-12-22 14:29 ` Fabiano Rosas
2025-12-23 11:17   ` Prasad Pandit
2025-12-23 15:04     ` Fabiano Rosas
2026-01-06 10:54       ` Prasad Pandit
2026-01-06 14:53         ` Peter Xu [this message]
2025-12-23 15:30   ` Peter Xu
2025-12-23 16:01     ` Fabiano Rosas
2026-01-06 11:45     ` Prasad Pandit
2026-01-06 13:47       ` Fabiano Rosas
2026-01-07 10:49         ` Prasad Pandit
2026-01-07 13:23           ` Fabiano Rosas
2026-01-12 13:05             ` Prasad Pandit
2026-01-12 19:45               ` Fabiano Rosas
2026-01-13 11:59                 ` Prasad Pandit
2026-01-14 12:16                   ` Fabiano Rosas
2026-01-06 15:09       ` Peter Xu
2026-01-07 11:11         ` Prasad Pandit
2026-01-07 17:03           ` Peter Xu
2025-12-23 15:17 ` Peter Xu
2025-12-23 15:36   ` Fabiano Rosas
2025-12-23 16:27     ` Peter Xu
2026-01-06 10:49   ` Prasad Pandit
2026-01-06 15:23     ` Peter Xu
2026-01-07 11:01       ` Prasad Pandit
2026-01-07 17:07         ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aV0h4siUlTSqJHaG@x1.local \
    --to=peterx@redhat.com \
    --cc=farosas@suse.de \
    --cc=pjp@fedoraproject.org \
    --cc=ppandit@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.