All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Simon Horman <horms@kernel.org>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Frank Wunderlich <frankwu@gmx.de>,
	Chad Monroe <chad@monroe.io>,
	Cezary Wilmanski <cezary.wilmanski@adtran.com>,
	Avinash Jayaraman <ajayaraman@maxlinear.com>,
	Bing tao Xu <bxu@maxlinear.com>, Liang Xu <lxu@maxlinear.com>,
	Juraj Povazanec <jpovazanec@maxlinear.com>,
	"Fanni (Fang-Yi) Chan" <fchan@maxlinear.com>,
	"Benny (Ying-Tsan) Weng" <yweng@maxlinear.com>,
	"Livia M. Rosu" <lrosu@maxlinear.com>,
	John Crispin <john@phrozen.org>
Subject: Re: [PATCH RFC net-next v4 3/4] net: mdio: add unlocked mdiodev C45 bus accessors
Date: Tue, 6 Jan 2026 17:53:29 +0000	[thread overview]
Message-ID: <aV1MGQirTHyFdv7Q@shell.armlinux.org.uk> (raw)
In-Reply-To: <36fbca0aaa0ca86450c565190931d987931ab958.1767718090.git.daniel@makrotopia.org>

On Tue, Jan 06, 2026 at 05:14:57PM +0000, Daniel Golle wrote:
> +static inline int __mdiodev_c45_write(struct mdio_device *mdiodev, u32 devad,
> +				      u16 regnum, u16 val)
> +{
> +	return __mdiobus_c45_write(mdiodev->bus, mdiodev->addr, devad, regnum,
> +				 val);

Something doesn't look right here - missing a couple of spaces to
correctly align? I suspect checkpatch would spot it?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2026-01-06 17:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-06 17:14 [PATCH RFC net-next v4 0/4] net: dsa: initial support for MaxLinear MxL862xx switches Daniel Golle
2026-01-06 17:14 ` [PATCH RFC net-next v4 1/4] dt-bindings: net: dsa: add MaxLinear MxL862xx Daniel Golle
2026-01-06 17:14 ` [PATCH RFC net-next v4 2/4] net: dsa: add tag format for MxL862xx switches Daniel Golle
2026-01-06 17:14 ` [PATCH RFC net-next v4 3/4] net: mdio: add unlocked mdiodev C45 bus accessors Daniel Golle
2026-01-06 17:53   ` Russell King (Oracle) [this message]
2026-01-06 22:36     ` Daniel Golle
2026-01-07  9:24       ` Liang Xu
2026-02-02 11:02       ` Russell King (Oracle)
2026-01-06 17:15 ` [PATCH RFC net-next v4 4/4] net: dsa: add basic initial driver for MxL862xx switches Daniel Golle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aV1MGQirTHyFdv7Q@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=ajayaraman@maxlinear.com \
    --cc=andrew@lunn.ch \
    --cc=bxu@maxlinear.com \
    --cc=cezary.wilmanski@adtran.com \
    --cc=chad@monroe.io \
    --cc=conor+dt@kernel.org \
    --cc=daniel@makrotopia.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=fchan@maxlinear.com \
    --cc=frankwu@gmx.de \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=john@phrozen.org \
    --cc=jpovazanec@maxlinear.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrosu@maxlinear.com \
    --cc=lxu@maxlinear.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=yweng@maxlinear.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.