All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Leo Yan <leo.yan@arm.com>, Thomas Richter <tmricht@linux.ibm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf test java symbol: Additional libperf-jvmti.so path check
Date: Tue, 6 Jan 2026 19:06:42 -0300	[thread overview]
Message-ID: <aV2HchAKw8gDc74m@x1> (raw)
In-Reply-To: <20251205190135.210864-1-irogers@google.com>

On Fri, Dec 05, 2025 at 11:01:35AM -0800, Ian Rogers wrote:
> If perf is built into an output directory then so is
> libperf-jvmti.so. If `perf test` is run from that directory then PWD
> needn't also be that directory meaning libperf-jvmti.so won't be found
> and the test skipped. Add an additional check for libperf-jvmti.so in
> the same directory as the perf binary for this case, this avoids the
> test skipping.

Thanks, applied to perf-tools-next,

- Arnaldo
 
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>  tools/perf/tests/shell/test_java_symbol.sh | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/perf/tests/shell/test_java_symbol.sh b/tools/perf/tests/shell/test_java_symbol.sh
> index 499539d1c479..63a2cc9bf13f 100755
> --- a/tools/perf/tests/shell/test_java_symbol.sh
> +++ b/tools/perf/tests/shell/test_java_symbol.sh
> @@ -22,10 +22,13 @@ cleanup_files()
>  
>  trap cleanup_files exit term int
>  
> +PERF_DIR=$(dirname "$(which perf)")
>  if [ -e "$PWD/tools/perf/libperf-jvmti.so" ]; then
>  	LIBJVMTI=$PWD/tools/perf/libperf-jvmti.so
>  elif [ -e "$PWD/libperf-jvmti.so" ]; then
>  	LIBJVMTI=$PWD/libperf-jvmti.so
> +elif [ -e "$PERF_DIR/libperf-jvmti.so" ]; then
> +	LIBJVMTI=$PERF_DIR/libperf-jvmti.so
>  elif [ -e "$PREFIX/lib64/libperf-jvmti.so" ]; then
>  	LIBJVMTI=$PREFIX/lib64/libperf-jvmti.so
>  elif [ -e "$PREFIX/lib/libperf-jvmti.so" ]; then
> @@ -34,6 +37,7 @@ elif [ -e "/usr/lib/linux-tools-$(uname -a | awk '{ print $3 }' | sed -r 's/-gen
>  	LIBJVMTI=/usr/lib/linux-tools-$(uname -a | awk '{ print $3 }' | sed -r 's/-generic//')/libperf-jvmti.so
>  else
>  	echo "Fail to find libperf-jvmti.so"
> +
>  	# JVMTI is a build option, skip the test if fail to find lib
>  	exit 2
>  fi
> -- 
> 2.52.0.223.gf5cc29aaa4-goog
> 

      reply	other threads:[~2026-01-06 22:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-05 19:01 [PATCH v1] perf test java symbol: Additional libperf-jvmti.so path check Ian Rogers
2026-01-06 22:06 ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aV2HchAKw8gDc74m@x1 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tmricht@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.