From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, dave@treblig.org, philmd@linaro.org
Subject: Re: [PATCH] hmp-commands-info.hx: Move definition of "info accel"
Date: Thu, 8 Jan 2026 09:14:29 +0000 [thread overview]
Message-ID: <aV91daSxVxvCGMCa@redhat.com> (raw)
In-Reply-To: <20260108083249.1602654-1-armbru@redhat.com>
On Thu, Jan 08, 2026 at 09:32:49AM +0100, Markus Armbruster wrote:
> Commit c10eb740108 (accel/system: Add 'info accel' on human monitor)
> inserted "info accel" in the middle of "info sync-profile". Move it
> behind "info sync-profile".
Opps, we have this kind of mistake over & over again. The .hx format
is really horrible and easy to make this mistake with, and makes me
rather wish we could eliminate it :-(
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hmp-commands-info.hx | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
> diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
> index 41674dcbe1..74c741f80e 100644
> --- a/hmp-commands-info.hx
> +++ b/hmp-commands-info.hx
> @@ -267,18 +267,6 @@ ERST
> .cmd = hmp_info_sync_profile,
> },
>
> - {
> - .name = "accel",
> - .args_type = "",
> - .params = "",
> - .help = "show accelerator statistics",
> - },
> -
> -SRST
> - ``info accel``
> - Show accelerator statistics.
> -ERST
> -
> SRST
> ``info sync-profile [-m|-n]`` [*max*]
> Show synchronization profiling info, up to *max* entries (default: 10),
> @@ -294,6 +282,18 @@ SRST
> being coalesced.
> ERST
>
> + {
> + .name = "accel",
> + .args_type = "",
> + .params = "",
> + .help = "show accelerator statistics",
> + },
> +
> +SRST
> + ``info accel``
> + Show accelerator statistics.
> +ERST
> +
> {
> .name = "kvm",
> .args_type = "",
> --
> 2.52.0
>
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2026-01-08 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 8:32 [PATCH] hmp-commands-info.hx: Move definition of "info accel" Markus Armbruster
2026-01-08 9:14 ` Daniel P. Berrangé [this message]
2026-01-08 9:32 ` Markus Armbruster
2026-01-08 13:27 ` Dr. David Alan Gilbert
2026-01-08 12:48 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aV91daSxVxvCGMCa@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=dave@treblig.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.