Re: [PATCH 03/10] pc-bios/s390-ccw: Split virtio-ccw and generic virtio

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Jan 08, 2026 at 07:02:47AM +0100, Thomas Huth wrote:
> On 07/01/2026 17.38, Jared Rossi wrote:
> > 
> > 
> > On 1/7/26 4:40 AM, Thomas Huth wrote:
> > > On 10/12/2025 21.54, jrossi@linux.ibm.com wrote:
> > > > From: Jared Rossi <jrossi@linux.ibm.com>
> ...
> > > > diff --git a/pc-bios/s390-ccw/virtio.c b/pc-bios/s390-ccw/virtio.c
> > > > index 0f4f201038..0488b3a07e 100644
> > > > --- a/pc-bios/s390-ccw/virtio.c
> > > > +++ b/pc-bios/s390-ccw/virtio.c
> > > > @@ -2,6 +2,7 @@
> > > >    * Virtio driver bits
> > > >    *
> > > >    * Copyright (c) 2013 Alexander Graf <agraf@suse.de>
> > > > + * Copyright 2025 IBM Corp. Author(s): Jared Rossi <jrossi@linux.ibm.com>
> > > 
> > > I assume you wanted to put Authors on a separate line?
> > 
> > I don't quite understand what you are asking about here.  Or maybe I
> > don't understand how to attribute the authors in this case?
> > 
> > Much of this was just copy/pasted to the new file, so I included the
> > existing byline too.  Should I format things differently?
> 
> No, you don't have to change it, I was just surprised to see "Copyright" and
> "Author(s):" in the same line. People normally put it on separate lines, see
> e.g. cio.c, menu.c or virtio-scsi.c in the pc-ios/s390-ccw/ directory.

The reason for the usual separation is that they have different effects.

Any text that is part of a  "Copyright" line is legally associated with,
and their presence is protected by the license terms.

Lists of authors have no legal effects, they're merely credits, and are
not protected by the license.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|