From: Christoph Hellwig <hch@infradead.org>
To: NeilBrown <neil@brown.name>
Cc: Chuck Lever <cel@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Jeff Layton <jlayton@kernel.org>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
linux-nfs@vger.kernel.org,
"Matthew Wilcox (Oracle)" <willy@infradead.org>
Subject: Re: [PATCH v5] NFSD: Track SCSI Persistent Registration Fencing per Client with xarray
Date: Thu, 8 Jan 2026 01:26:29 -0800 [thread overview]
Message-ID: <aV94RS0QkITrBdIC@infradead.org> (raw)
In-Reply-To: <176783380243.16766.17752014824707434037@noble.neil.brown.name>
On Thu, Jan 08, 2026 at 11:56:42AM +1100, NeilBrown wrote:
> > > Only in the most abstract way, xa_store actually stores the new
> > > entry/value and returns the old one. In other words, this does
> > > quite a bit of work for the non-initial GETDEVICEINFO.
> >
> > The comment is misleading then, and should be clarified.
> >
> > But should the code use xa_insert instead of xa_store ?
>
> or xa_cmpxchg() to replace NULL with a value??
xa_insert seems like a lot less heavy handed.
prev parent reply other threads:[~2026-01-08 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-27 4:24 [PATCH v5] NFSD: Track SCSI Persistent Registration Fencing per Client with xarray Chuck Lever
2026-01-03 19:46 ` Dai Ngo
2026-01-07 16:17 ` Christoph Hellwig
2026-01-08 0:26 ` Chuck Lever
2026-01-08 0:56 ` NeilBrown
2026-01-08 9:26 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aV94RS0QkITrBdIC@infradead.org \
--to=hch@infradead.org \
--cc=cel@kernel.org \
--cc=dai.ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.