From: Zhao Liu <zhao1.liu@intel.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-ppc@nongnu.org,
Pierrick Bouvier <pierrick.bouvier@linaro.org>,
qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,
qemu-arm@nongnu.org, Riku Voipio <riku.voipio@iki.fi>,
Eduardo Habkost <eduardo@habkost.net>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Yanan Wang <wangyanan55@huawei.com>,
Peter Maydell <peter.maydell@linaro.org>,
Nicholas Piggin <npiggin@gmail.com>,
Chinmay Rath <rathc@linux.ibm.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <alistair.francis@wdc.com>,
Weiwei Li <liwei1518@gmail.com>,
Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,
Ilya Leoshkevich <iii@linux.ibm.com>,
David Hildenbrand <david@kernel.org>,
Thomas Huth <thuth@redhat.com>, Max Filippov <jcmvbkbc@gmail.com>
Subject: Re: [PATCH 5/5] accel/tcg: Unify watchpoint API
Date: Thu, 8 Jan 2026 15:14:08 +0800 [thread overview]
Message-ID: <aV9ZQJhvaNcKOfJ7@intel.com> (raw)
In-Reply-To: <20260106231908.16756-6-philmd@linaro.org>
On Wed, Jan 07, 2026 at 12:19:07AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 7 Jan 2026 00:19:07 +0100
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> Subject: [PATCH 5/5] accel/tcg: Unify watchpoint API
> X-Mailer: git-send-email 2.52.0
>
> Currently "exec/breakpoint.h" contains both BreakPoint *and*
> WatchPoint APIs, however very few files requires the former,
> and more the latter:
>
> $ git grep -l CPUBreakpoint | wc -l
> 12
> $ git grep -l CPUWatchpoint | wc -l
> 25
>
> So extracting the WatchPoint API to its own header will reduce
> compilation pressure.
>
> But more importantly, the API is scattered in two distinct headers.
> Unify them ("accel/tcg/cpu-ops.h" and "exec/watchpoint.h") to the
> new "accel/tcg/watchpoint.h" header, making the emphasis the API is
> specific to TCG.
>
> Have accel/tcg/watchpoint.c absorb system/watchpoint.c code.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> MAINTAINERS | 1 -
> include/accel/tcg/cpu-ops.h | 28 +-------
> include/accel/tcg/watchpoint.h | 57 ++++++++++++++++
> include/exec/breakpoint.h | 10 ---
> include/exec/watchpoint.h | 18 -----
> include/hw/core/cpu.h | 3 +-
> target/arm/internals.h | 2 +-
> target/ppc/internal.h | 2 +-
> target/riscv/debug.h | 2 +-
> accel/tcg/cputlb.c | 1 +
> accel/tcg/tcg-accel-ops.c | 2 +-
> accel/tcg/user-exec-stub.c | 3 +-
> accel/tcg/watchpoint.c | 83 +++++++++++++++++++++-
> system/watchpoint.c | 102 ----------------------------
> target/arm/debug_helper.c | 2 +-
> target/arm/tcg/mte_helper.c | 2 +-
> target/arm/tcg/sve_helper.c | 2 +-
> target/i386/cpu.c | 2 +-
> target/i386/machine.c | 2 +-
> target/i386/tcg/system/bpt_helper.c | 2 +-
> target/ppc/cpu.c | 2 +-
> target/ppc/cpu_init.c | 2 +-
> target/riscv/cpu_helper.c | 2 +-
> target/riscv/debug.c | 2 +-
> target/s390x/helper.c | 2 +-
> target/s390x/tcg/debug.c | 2 +-
> target/s390x/tcg/excp_helper.c | 2 +-
> target/s390x/tcg/mem_helper.c | 1 +
> target/xtensa/dbg_helper.c | 2 +-
> system/meson.build | 1 -
> 30 files changed, 162 insertions(+), 182 deletions(-)
> create mode 100644 include/accel/tcg/watchpoint.h
> delete mode 100644 include/exec/watchpoint.h
> delete mode 100644 system/watchpoint.c
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
next prev parent reply other threads:[~2026-01-08 6:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 23:19 [PATCH 0/5] accel/tcg: Restrict WatchPoint API to TCG Philippe Mathieu-Daudé
2026-01-06 23:19 ` [PATCH 1/5] target/i386: " Philippe Mathieu-Daudé
2026-01-08 0:54 ` Pierrick Bouvier
2026-01-08 7:10 ` Zhao Liu
2026-01-06 23:19 ` [PATCH 2/5] target/ppc: " Philippe Mathieu-Daudé
2026-01-08 0:55 ` Pierrick Bouvier
2026-01-08 8:33 ` Chinmay Rath
2026-01-06 23:19 ` [PATCH 3/5] target/s390x: " Philippe Mathieu-Daudé
2026-01-07 5:28 ` Thomas Huth
2026-01-08 0:56 ` Pierrick Bouvier
2026-01-06 23:19 ` [PATCH 4/5] accel/tcg: Un-inline WatchPoint API user-emulation stubs Philippe Mathieu-Daudé
2026-01-08 0:57 ` Pierrick Bouvier
2026-01-06 23:19 ` [PATCH 5/5] accel/tcg: Unify watchpoint API Philippe Mathieu-Daudé
2026-01-08 0:58 ` Pierrick Bouvier
2026-01-08 7:14 ` Zhao Liu [this message]
2026-01-09 23:56 ` [PATCH 0/5] accel/tcg: Restrict WatchPoint API to TCG Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aV9ZQJhvaNcKOfJ7@intel.com \
--to=zhao1.liu@intel.com \
--cc=alistair.francis@wdc.com \
--cc=david@kernel.org \
--cc=dbarboza@ventanamicro.com \
--cc=eduardo@habkost.net \
--cc=iii@linux.ibm.com \
--cc=jcmvbkbc@gmail.com \
--cc=liwei1518@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rathc@linux.ibm.com \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.