From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DAE51E9270E for ; Sat, 27 Dec 2025 19:35:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 70E391131C2; Sat, 27 Dec 2025 19:35:56 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="W2QyQPuF"; dkim-atps=neutral Received: from mail-yx1-f51.google.com (mail-yx1-f51.google.com [74.125.224.51]) by gabe.freedesktop.org (Postfix) with ESMTPS id E4B301131C2 for ; Sat, 27 Dec 2025 19:35:55 +0000 (UTC) Received: by mail-yx1-f51.google.com with SMTP id 956f58d0204a3-6446c1a7a1cso6666472d50.3 for ; Sat, 27 Dec 2025 11:35:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766864155; x=1767468955; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZscOEY94JtpqTuF2Rte0ITMRfXFqnWcGnNUyPWqzXog=; b=W2QyQPuFiXSJhkcSjIQP//1Ccl6cuYhEONxIVW0ReHvpyN8miU/5EwTFm2bGVu+ZnZ Ga84mpXs+WgPXnnCqTEc2pMAoUG5buTzJ/B5hkbPCjiDGlOdnk+8xzSvzRY141eh/cOa KKbLuT42lHgCwura+mztU9HgBRhTnjm6zw1c+zvMujdfceFnXpNG780F6wK7w9Pb6iTT gO3fgvTsZO7jCAvjRT+dFrk5THy13rj6x8oouJIZ+6bq3QTR/mSDJxowhYnIIC8hs2K3 bxfIhLGd2znLQOmFPr7LIHlGQKGf9vAwMlDgwA/PiFMYvnr9TO1fGswee9FlWgbMee21 6L3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766864155; x=1767468955; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZscOEY94JtpqTuF2Rte0ITMRfXFqnWcGnNUyPWqzXog=; b=h1gxCnpcyAiv6fbrQbD+T5F+UuW5FWzkWYQMdYvFjKPmiKmFRzXJTA9L1dEnd/XnxP hAUDcJ5fH+frFvl0XNAoiY5xISE0X1z/lcvWb8O6kbggJEDgB7Yh6VxdUaLIYzC+OEqa M7uMa/CiJiUk/f/4JLWE/0GsV4Jyvcx2zgRSUW7txjshT/9D89OrI4mEeGFCJQ/XClnt SiYKuC79Du7fIqFaBT5DhmlSgdEDtg8AGu9I3lpA+siNnRz9Ox6P8lDQzeh4qN6vzAFO 5SymJYToTf5MhZHWUeVX2KQ2lQ3k4qOEKez/xEQPUfvMmR370TkczZZX3z9ZLRZPJhki 4msA== X-Forwarded-Encrypted: i=1; AJvYcCUBF3VlQ5YAFBw9hOHVHzMyBVCZF4lJECu74kQPmRQ0NY40RdNZlwoPfrNa1rGkEIcAZhIye41cLCY=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxTdVv8iBmKM89PDLrON07PAX6GJe6uHIy4GQWp+s8IJ/Ov6GkZ xTJOS2H2FJYV4C4O9QtY40L4d5v5uL5SpNFtw+xuN35Kq+1J/1lKXVxk X-Gm-Gg: AY/fxX4ey/6Ekb47nqXXaGOMevG20oB5NnvKsZb+BW16pirML7/51Atp1SDJP3PRqg6 VPVIShyxIO5WEOzMXDb7Aw/FbsqpcfTodmnI2ehwQeWNpbPHt4KRtIqR31GeXhmJMQAMSDqwVEE IocAm58a7zRMrXDzzeOtzethTZfaa7MWarwaBQfv/eDCm7A4MzZyLW7jOG3CBEtGm6CmJUlb1an DVhyECbU43C+Pb5TTjrYjmEUx84O5ScOGzzU8QmaqtWHqxBskVrq/1xXFQ7Hk9DjWoEjMDynEd8 Fhcd/VXfP/TEArX6Lse4+Ircc6QpHRvDX/sBycDNecogxTeqoTy/6JVgFUdYGWxczRNnARsTQDS fNabOIwM6CMQgyKk3oBF7RJj/bTVe0WcmHpbyPdXpYg7qkXk6KBGbrHt+YtepjcCB/lguoKit+6 1Lx6eajQs= X-Google-Smtp-Source: AGHT+IFTyqtO8AIMR6I5RrW0NJVOngvdnp5kCSpfYPRgSEcWGvPmUWwG/Vuj1vc27aG6932toBOBHQ== X-Received: by 2002:a05:690e:4106:b0:644:60d9:865e with SMTP id 956f58d0204a3-6466a8ede93mr19913042d50.97.1766864154604; Sat, 27 Dec 2025 11:35:54 -0800 (PST) Received: from localhost ([2601:346:0:79bd:f47d:8af8:869d:704b]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6466a8bd4c3sm12689811d50.8.2025.12.27.11.35.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Dec 2025 11:35:53 -0800 (PST) Date: Sat, 27 Dec 2025 14:35:52 -0500 From: Yury Norov To: Steven Rostedt Cc: Andy Shevchenko , Andrew Morton , Masami Hiramatsu , Mathieu Desnoyers , Christophe Leroy , Randy Dunlap , Ingo Molnar , Jani Nikula , Joonas Lahtinen , David Laight , Petr Pavlu , Andi Shyti , Rodrigo Vivi , Tvrtko Ursulin , Daniel Gomez , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH v4 7/7] kernel.h: drop trace_printk.h Message-ID: References: <20251225170930.1151781-1-yury.norov@gmail.com> <20251225170930.1151781-8-yury.norov@gmail.com> <20251226115848.298465d4@gandalf.local.home> <20251227105701.5cbeb47e@robin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251227105701.5cbeb47e@robin> X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sat, Dec 27, 2025 at 10:57:01AM -0500, Steven Rostedt wrote: > On Sat, 27 Dec 2025 16:45:47 +0200 > Andy Shevchenko wrote: > > > > I'm fine for trying other ways to speed up the compilation, but removing > > > full access to trace_printk() isn't one of them. OK, then let's keep trace_printk() available for kernel.h users. Andrew, can you take the first 6 patches of the series, if no other objections? > > I interpreted this as if the header inclusion should be moved from kernel.h > > to printk.h as a compromise that satisfies all (?) stakeholders. Is it possible > > approach? > > I'm fine with putting the include of trace_printk.h into printk.h. If > you remove printk.h from kernel.h I would expect a lot more people to > complain about it. Including Linus himself. The difference is that printk() is not a debugging tool. It is used widely to report errors and info messages. Normally, I want to cleanup all debugging code from my module after finishing development. If trace_printk.h will be a part of printk.h, there's always a chance to miss trace_printk() somewhere. I'd prefer to keep them separate. Thanks, Yury