From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BA2E3233FA for ; Sat, 27 Dec 2025 16:01:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766851272; cv=none; b=SRf/DDi4F3J8YD1EBFmNGCNA2ACKpg/aZp9FAh1OFSNEmVGF+t18ERcZ/PYikJk3ptzB9S4Anyt7iCVIrRCEHSmKSyjZTX13vAhh6zFlxUQifT/y9SSxkqak7X7eYviyTOCFgYzhbKe5GBcGNBZtiGoUCgDqZgKfJ7LJnXS9xjU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766851272; c=relaxed/simple; bh=tunhNbz8xF4puSnNt518AI6lXZ6uaOF8kSWvGpQKU7c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=od/YOxCNqfXhZbHNxUu3G7+/JXDW8MmHxjXnUuKMerXMxkw058NSUFfspKrp2xoMRTES0x8o9Maqy3O/7w/zeCmWptU4BiUmuv0udrATmHQq+Yeh9/pieW95xJNBJR3tPg2Vkqq/5BLl0ieiWLZER95sA0anVcqAHyd8Dq0qFqM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=iLqWRLmX; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="iLqWRLmX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1766851271; x=1798387271; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=tunhNbz8xF4puSnNt518AI6lXZ6uaOF8kSWvGpQKU7c=; b=iLqWRLmXerMqSoTfm+Igzn6Gj2FwOP5iBTI4Vx7+gunvKPWObqOELLpM g+CO2NBpqMLZjob4cttE9X/FuQy8PoxGNrliUqHGZMBR7qoxepTJUU/YI 8bTNUrzmaz7CUzPWIQaihoZtgokHVwbfZC+mdD0PjckGqUVN4Bg31HQfM oAEcDM+yg+E6i+k0XyFPkP29nUbLLxzzyaTulALWDlRUSpQPoyYRVlqKx V1KtWHyF3l2rSfaNVqwJhFMB5Coeyc2CE071ufxuIpOvl/TGZrc7lej8S EfDxhn3Y8LMMUdVa6pJ1Qv2F+3vY+Hxoq8qFAB2G/1TCdTqA0Sbeam4by w==; X-CSE-ConnectionGUID: zfcdWytBSGCRKYbBiDc+ig== X-CSE-MsgGUID: fmk2mw7zRiuG9ndOgmj6sw== X-IronPort-AV: E=McAfee;i="6800,10657,11654"; a="68302368" X-IronPort-AV: E=Sophos;i="6.21,180,1763452800"; d="scan'208";a="68302368" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Dec 2025 08:01:10 -0800 X-CSE-ConnectionGUID: G8mDV/ZfTLanAFJP3SeYdg== X-CSE-MsgGUID: 242fuiA/Tg+1zELyXHDleA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,180,1763452800"; d="scan'208";a="200539911" Received: from egrumbac-mobl6.ger.corp.intel.com (HELO localhost) ([10.245.244.211]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Dec 2025 08:01:07 -0800 Date: Sat, 27 Dec 2025 18:01:05 +0200 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Thomas Fourier , Andy Shevchenko , Linus Walleij , Russell King , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: 6214/2: fix release_mem_region() size Message-ID: References: <20251216174715.57547-2-fourier.thomas@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Dec 17, 2025 at 08:28:27AM +0100, Geert Uytterhoeven wrote: > Hi Thomas, > > Thanks for your patch! > > The patch prefix should be "auxdisplay: arm-charlcd:", not an rmk > patch tracker ID. > > On Tue, 16 Dec 2025 at 18:49, Thomas Fourier wrote: > > It seems like, after the request_mem_region(), the corresponding > > release_mem_region() must take the same size. This was done > > in charlcd_remove() but not in the error path in charlcd_probe(). > > Unfortunately charlcd_remove() was removed in one of these silly > "make explicitly non-modular" patches... > > > Fixes: ce8962455e90 ("ARM: 6214/2: driver for the character LCD found in ARM refdesigns") > > Signed-off-by: Thomas Fourier > > > --- a/drivers/auxdisplay/arm-charlcd.c > > +++ b/drivers/auxdisplay/arm-charlcd.c > > @@ -323,7 +323,7 @@ static int __init charlcd_probe(struct platform_device *pdev) > > out_no_irq: > > iounmap(lcd->virtbase); > > out_no_memregion: > > Looks like the first "goto out_no_memregion" is incorrect, and should be > "goto out_no_resource". Should it be in this change or in a separate change? I'm not sure I got what should be done about this. > > - release_mem_region(lcd->phybase, SZ_4K); > > + release_mem_region(lcd->phybase, lcd->physize); > > out_no_resource: > > kfree(lcd); > > return ret; > > The actual change LGTM to me, so > Reviewed-by: Geert Uytterhoeven Reading between the lines, should I alter the commit message to mention that there is no more charlcd_remove()? Something like: It seems like, after the request_mem_region(), the corresponding release_mem_region() must take the same size. This was done in recently dropped charlcd_remove() but not in the error path in charlcd_probe(). (and Subject line)? -- With Best Regards, Andy Shevchenko