Re: [PATCH v2] virtio: Describe @map and @vmap members in virtio_device struct

[Bagas Sanjaya <bagasdotme@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1303 bytes --]

On Fri, Dec 26, 2025 at 02:13:00PM -0500, Michael S. Tsirkin wrote:
> > diff --git a/include/linux/virtio.h b/include/linux/virtio.h
> > index 132a474e59140a..68ead8fda9c921 100644
> > --- a/include/linux/virtio.h
> > +++ b/include/linux/virtio.h
> > @@ -150,11 +150,13 @@ struct virtio_admin_cmd {
> >   * @id: the device type identification (used to match it with a driver).
> >   * @config: the configuration ops for this device.
> >   * @vringh_config: configuration ops for host vrings.
> > + * @map: configuration ops for device's mapping buffer
> 
> there's no "mapping buffer" that needs configuration.
> the type tells it all:
>  * struct virtio_map_ops - operations for mapping buffer for a virtio device
> 
> 
> >   * @vqs: the list of virtqueues for this device.
> >   * @features: the 64 lower features supported by both driver and device.
> >   * @features_array: the full features space supported by both driver and
> >   *		    device.
> >   * @priv: private pointer for the driver's use.
> > + * @vmap: device virtual map
> 
> this one is not a "virtual map" either.
> more a "device or domain used for mapping memory"

Thanks for the suggestions! I'll apply them in v3 (should be out in Monday).

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]