All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Eichenberger <eichest@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	horms@kernel.org,
	Stefan Eichenberger <stefan.eichenberger@toradex.com>
Subject: Re: [PATCH v1 2/2] dt-bindings: net: micrel: Convert micrel-ksz90x1.txt to DT schema
Date: Mon, 29 Dec 2025 10:38:37 +0100	[thread overview]
Message-ID: <aVJMHQZYugDoWHD3@eichest-laptop> (raw)
In-Reply-To: <84bd049b-3c60-47e0-a404-be764758f5b1@lunn.ch>

On Tue, Dec 23, 2025 at 03:39:24PM +0100, Andrew Lunn wrote:
> > +      patternProperties:
> > +        '^([rt]xd[0-3]|[rt]xc|rxdv|txen)-skew-ps$':
> > +          description: |
> > +            Skew control of the pad in picoseconds. A value of 0 equals to a
> > +            skew of -840ps.
> > +            The actual increment on the chip is 120ps ranging from -840ps to
> > +            960ps, this mismatch comes from a documentation error before
> > +            datasheet revision 1.2 (Feb 2014):
> 
> > -  Device Tree Value	Delay	Pad Skew Register Value
> > -  -----------------------------------------------------
> > -	0   		-840ps		0000
> > -	200 		-720ps		0001
> > -	400 		-600ps		0010
> > -	600 		-480ps		0011
> > -	800 		-360ps		0100
> > -	1000		-240ps		0101
> > -	1200		-120ps		0110
> > -	1400		   0ps		0111
> > -	1600		 120ps		1000
> > -	1800		 240ps		1001
> > -	2000		 360ps		1010
> > -	2200		 480ps		1011
> > -	2400		 600ps		1100
> > -	2600		 720ps		1101
> > -	2800		 840ps		1110
> > -	3000		 960ps		1111
> 
> I think this table is more readable? But maybe without the register
> value, which is an implementation detail.

Thanks, you are right. I will add a table again in the next version and
drop the register values as suggested.

Regards,
Stefan

      reply	other threads:[~2025-12-29  9:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-23 13:33 [PATCH v1 0/2] Convert the Micrel bindings to DT schema Stefan Eichenberger
2025-12-23 13:33 ` [PATCH v1 1/2] dt-bindings: net: micrel: Convert " Stefan Eichenberger
2025-12-23 14:34   ` Andrew Lunn
2025-12-29  9:36     ` Stefan Eichenberger
2025-12-23 14:44   ` Rob Herring (Arm)
2025-12-28 15:36   ` Rob Herring
2025-12-29  9:37     ` Stefan Eichenberger
2025-12-23 13:33 ` [PATCH v1 2/2] dt-bindings: net: micrel: Convert micrel-ksz90x1.txt " Stefan Eichenberger
2025-12-23 14:39   ` Andrew Lunn
2025-12-29  9:38     ` Stefan Eichenberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aVJMHQZYugDoWHD3@eichest-laptop \
    --to=eichest@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=stefan.eichenberger@toradex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.