From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0FC62F7AAB for ; Mon, 29 Dec 2025 11:08:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767006513; cv=none; b=VzhFQ8bOAQFiXvhD/lQGh+4Nfe3FROQNgxjGZouqtJkTZYNqUhKGemncBYwcvRL/KcuHBVnf2cxCRov1FBSR5KfUK94+H7lK3cIB0W7EbsaHCo5fLlczX09R2UZD55XKR0fmCgnZSXQ7+eVyUuou1etuovuKgVzknaLQhl0gMbQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767006513; c=relaxed/simple; bh=mvTRMMCL5RZ4BZ6ReS6eys7tkGj6CcSCpfSOhXlEW4U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ohh/4pj/QI8tGtPpRdSxQ499iRWzoxcXgG3msdJQdS2F/mj4M2HjAgS9FXFEwQSufRG0vj+6qynDqJPKg0a3jKK2QbNR/imLbqPzZFb7TfsUp0Ow8FHXzOPuaGwAty1P0u2Y9AaQhrmiKpShZd87WvBYPEtYQXlSUVofWl4zafY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=icdti6Ls; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="icdti6Ls" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-64b81ec3701so14142281a12.1 for ; Mon, 29 Dec 2025 03:08:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767006508; x=1767611308; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=EDNpH0M3uSivXuXT5U5j0XwxOr48cVPii2SiJVOuw30=; b=icdti6LsWw/+HVAON6tthsJrH+7zWnGbaXLy/O6kgmqgAUpIo0a2txy/M6eyF2KSVK TldkctQTplXkYmPqAHLUZBbl16S8pzXtse18TV1fENnabFjxx8uNdeeGsDRZsZfy+HJ2 ZAlAHGet5N1gT8uf6t6US3mHFKZ/IdnAIEySPQ+dkKIbhH8KiSdQqtNneZEg1OWDGAhu QE+ZdLIlzY35V0bPgMHxpMobtDsb57tRQSsV/oh/sQAkpclVNmu22RhIhuiuucsJvsrV e/hCWbGYhQ4v7Icjub2Yny6cm6a6PRoQqO6jlXbA2CelkRQLDR5pxVTGxqpWw9jJPvuE 1xbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767006508; x=1767611308; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EDNpH0M3uSivXuXT5U5j0XwxOr48cVPii2SiJVOuw30=; b=aOHMhId7SvuzPJdm4yF9soOUusO+y7FY9kYCbtolkiJ3Bmcu56Gr7pgojDuv3LDBVB Y4fnsIWQWnVgFAZ+DvLwStYEhbQIGWRehTDz3GpCN8O91pe9n0arelf1z4xvNza6DpYX Xk4R2DiMkq3iaSWB5k2jediAgc6jslBYF7CQPxylB9G4QiujMRBAAxP6eFATXPPo+6TQ OJmfpgJ76a2QpgsRL+1cNI/aR3/d2zAbDIKtgorpDRO5cNuuwVpBp/hElCDakt80CVzA v5swo4RSrI9oePFt8PWEonEhZ00UIRktT0Qzo1YGeAO1LKk8Zudxi1h+7JgmOuF9mVpd 6W6g== X-Forwarded-Encrypted: i=1; AJvYcCXHCVxFNAxXABnmoqmV1CfQabWqPb17Sh6Aq+3asrKWq/uAw4vYhqpb8fZl0gD2pKu8cQczJN7eKcXplEe4@vger.kernel.org X-Gm-Message-State: AOJu0YwKV8snu22gr27jkNAy9m1IhgnUt8Y2obgjpx3hsdkjcPu0+iBZ ut4JpkO15SjfSJVMSbjWmgkuHCN334CtDhqHAgBHurLpmbVTTJPa3ANUHUR6JbyWT/c= X-Gm-Gg: AY/fxX5uMczXWE5nkyistuzUZT6UTAZqDj4n+iApP5ATCZLyyckMGqKu/KuCEm7875V DLf/4hysncLsV4mjWuMAx6+cl/NvQv9bFHDFQiZyHg1q82+X6hz+gOL3UQKK4C2qcKoHL8h6Jn/ BdQC03Dvhhiriu9WpC/ksZAIhG/buw8XuF4hAMSuTRUP/PWLs4qna8cjY/gi5vo49lc37GZRVAt 9D+ZpV6kQtjRvLp23Hw5DmsfLrSMgWkz8V3fDhhhSjqM9awSEpSrYxTlTuKWJMQqL9rqAF1akYq o9cPhAkmBDVyQ8gGDP2b4L/sBCkVt+ccM3jbasRfve34nyorh+9zB8zG+TV86XjiUOLZRWvQg7U rZUFJ+FPCOrVW42t+1alg8Aq/EUU+rz3i4H8uJWPDplWltKaRQXlm86Of+pHeayA74z2ZR/dqfd FkltbYLm7rhS2+b8nR X-Google-Smtp-Source: AGHT+IFdqvRMDU+1HShKXzvNt54ZV5MxDiUe71q1HsCeGk+c7DD7LsfJqZBS0W+l8rfo3mlbyZkzHQ== X-Received: by 2002:a17:907:d87:b0:b73:5d8c:dd0d with SMTP id a640c23a62f3a-b80371d69e5mr3256854366b.52.1767006508045; Mon, 29 Dec 2025 03:08:28 -0800 (PST) Received: from linaro.org ([77.64.146.193]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b91494c03sm31698752a12.18.2025.12.29.03.08.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Dec 2025 03:08:27 -0800 (PST) Date: Mon, 29 Dec 2025 12:08:15 +0100 From: Stephan Gerhold To: =?iso-8859-1?B?QmFybmFi4XMgQ3rpbeFu?= Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephan Gerhold , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/8] remoteproc: qcom_q6v5_mss: Add MSM8917 Message-ID: References: <20251228-mss-v1-0-aeb36b1f7a3f@mainlining.org> <20251228-mss-v1-4-aeb36b1f7a3f@mainlining.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251228-mss-v1-4-aeb36b1f7a3f@mainlining.org> On Sun, Dec 28, 2025 at 03:21:54PM +0100, Barnabás Czémán wrote: > Add support for MSM8917 MSS it is similar for MDM9607 MSS > only difference is the mss power domain. > > Signed-off-by: Barnabás Czémán > --- > drivers/remoteproc/qcom_q6v5_mss.c | 46 ++++++++++++++++++++++++++++++++++++-- > 1 file changed, 44 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c > index ffafbe501a05..2579558fb567 100644 > --- a/drivers/remoteproc/qcom_q6v5_mss.c > +++ b/drivers/remoteproc/qcom_q6v5_mss.c > @@ -259,6 +259,7 @@ enum { > MSS_MSM8226, > MSS_MSM8909, > MSS_MSM8916, > + MSS_MSM8917, > MSS_MSM8926, > MSS_MSM8953, > MSS_MSM8974, > @@ -749,13 +750,15 @@ static int q6v5proc_reset(struct q6v5 *qproc) > goto pbl_wait; > } else if (qproc->version == MSS_MDM9607 || > qproc->version == MSS_MSM8909 || > + qproc->version == MSS_MSM8917 || > qproc->version == MSS_MSM8953 || > qproc->version == MSS_MSM8996 || > qproc->version == MSS_MSM8998 || > qproc->version == MSS_SDM660) { > > /* Override the ACC value if required */ > - if (qproc->version == MSS_MDM9607) > + if (qproc->version == MSS_MDM9607 || > + qproc->version == MSS_MSM8917) > writel(QDSP6SS_ACC_OVERRIDE_VAL_9607, > qproc->reg_base + QDSP6SS_STRAP_ACC); > else if (qproc->version != MSS_MSM8909 && > @@ -817,6 +820,7 @@ static int q6v5proc_reset(struct q6v5 *qproc) > > /* Turn on L1, L2, ETB and JU memories 1 at a time */ > if (qproc->version == MSS_MDM9607 || > + qproc->version == MSS_MSM8917 || > qproc->version == MSS_MSM8953 || > qproc->version == MSS_MSM8996) { > mem_pwr_ctl = QDSP6SS_MEM_PWR_CTL; > @@ -826,7 +830,8 @@ static int q6v5proc_reset(struct q6v5 *qproc) > * Set first 5 bits in reverse to avoid > * "inrush current" issues. > */ > - if (qproc->version == MSS_MDM9607) > + if (qproc->version == MSS_MDM9607 || > + qproc->version == MSS_MSM8917) > reverse = 6; > } else { > /* MSS_MSM8998, MSS_SDM660 */ > @@ -2538,6 +2543,42 @@ static const struct rproc_hexagon_res msm8916_mss = { > .version = MSS_MSM8916, > }; > > +static const struct rproc_hexagon_res msm8917_mss = { > + .hexagon_mba_image = "mba.mbn", > + .proxy_supply = (struct qcom_mss_reg_res[]) { > + { > + .supply = "pll", > + .uA = 100000, > + }, > + {} > + }, > + .proxy_clk_names = (char*[]){ > + "xo", > + NULL > + }, > + .active_clk_names = (char*[]){ > + "iface", > + "bus", > + "mem", > + NULL > + }, > + .proxy_pd_names = (char*[]) { > + "cx", > + "mx", > + "mss", Are you sure mss/pm8937_s1 also works as a power domain? It seems to be a plain regulator downstream (similar to msm8226/msm8974). Same thing applies to MSM8953 as well though and there we seem to have decided to model it as a power domain ... > + NULL > + }, > + .need_mem_protection = false, > + .has_alt_reset = false, > + .has_mba_logs = false, > + .has_spare_reg = false, > + .has_qaccept_regs = false, > + .has_ext_bhs_reg = false, > + .has_ext_cntl_regs = false, > + .has_vq6 = false, > + .version = MSS_MSM8917, You could set MSS_MDM9607 here to drop the extra diff above (but not sure if that would be clearer). Thanks, Stephan