All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marijn Suijten <marijn.suijten@somainline.org>
To: Linus Walleij <linusw@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	 Sam Ravnborg <sam@ravnborg.org>,
	David Airlie <airlied@gmail.com>,
	 Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Andy Gross <agross@kernel.org>,
	 Bjorn Andersson <andersson@kernel.org>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	 Thomas Zimmermann <tzimmermann@suse.de>,
	Simona Vetter <simona@ffwll.ch>,
	 Casey Connolly <casey.connolly@linaro.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Simona Vetter <simona.vetter@ffwll.ch>,
	 ~postmarketos/upstreaming@lists.sr.ht,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@somainline.org>,
	Martin Botka <martin.botka@somainline.org>,
	 Jami Kettunen <jami.kettunen@somainline.org>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	 devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	 Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Kuogee Hsieh <quic_khsieh@quicinc.com>,
	 Jessica Zhang <quic_jesszhan@quicinc.com>,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	 Konrad Dybcio <konradybcio@kernel.org>,
	Dmitry Baryshkov <lumag@kernel.org>
Subject: Re: [PATCH v2 04/11] dt-bindings: display: panel: Describe Samsung SOFEF01-M DDIC
Date: Mon, 29 Dec 2025 12:52:55 +0100	[thread overview]
Message-ID: <aVJpbJEymWWQLK6O@SoMainline.org> (raw)
In-Reply-To: <CAD++jL=HDRAcwDVUeYUKFbamqVnOADqz5qpbSr1XVsr3M1iNoQ@mail.gmail.com>

On 2025-12-26 18:38:56, Linus Walleij wrote:
> On Fri, Dec 26, 2025 at 2:48 PM Marijn Suijten
> <marijn.suijten@somainline.org> wrote:
> > On 2025-12-26 14:25:04, Linus Walleij wrote:
> 
> > > They are clearly using the S0FEF01-M display controller.
> >
> > So you're implying or certain that these panel names here are always bundled
> > with exactly the same controller (making the SOFEF01 part "redundant" in the
> > compatible)?
> 
> Yes that's what I suspect.

Do you still want me to drop it from the compatible, but definitely keep it in
the driver filename unless we unify all of the drivers (hopefully in a later
patch)?

> > Also, divergence of the driver commands got significant with the last two panels
> > / three phones, though that might be down to vendor configuration/calibration.
> 
> That's kind of normal. The defaults suffice for a while, then engineers
> want to start poking at different voltages to the display to improve
> and tweak things.

Makes one wonder if the changes are down to the panel used, or vendor tuning
when they started using these panels in their phones.  To note, I think I booted
all these phones on the "original" SOFEF01 driver without problems, before
ultimately implementing all diverging commands because I don't know if they're
defaults, related to color tuning, timings, thermals, manufacturer tolerances or
anything else.

- Marijn

  reply	other threads:[~2025-12-29 11:52 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-21 23:32 [PATCH v2 00/11] drm/panel: Add 5 DDIC panel drivers for 14 Sony phones Marijn Suijten
2025-12-21 23:32 ` [PATCH v2 01/11] drm/panel: Clean up SOFEF00 config dependencies Marijn Suijten
2026-02-23 22:28   ` David Heidelberg
2025-12-21 23:32 ` [PATCH v2 02/11] dt-bindings: display: panel: Describe LGD LH599QH3-EDB1 panel Marijn Suijten
2025-12-21 23:32 ` [PATCH v2 03/11] drm/panel: Add LGD LH599QH3-EDB1 panel driver for Sony Xperia XZ3 Marijn Suijten
2025-12-24  1:12   ` Dmitry Baryshkov
2025-12-26 13:12   ` Linus Walleij
2025-12-29 11:21     ` Marijn Suijten
2025-12-29 12:33       ` Linus Walleij
2025-12-21 23:32 ` [PATCH v2 04/11] dt-bindings: display: panel: Describe Samsung SOFEF01-M DDIC Marijn Suijten
2025-12-26 13:25   ` Linus Walleij
2025-12-26 13:48     ` Marijn Suijten
2025-12-26 17:38       ` Linus Walleij
2025-12-29 11:52         ` Marijn Suijten [this message]
2025-12-29 12:37           ` Linus Walleij
2025-12-30  1:51   ` Rob Herring
2025-12-21 23:32 ` [PATCH v2 05/11] drm/panel: Add panel driver for Samsung SOFEF01 DDIC Marijn Suijten
2025-12-24  1:12   ` Dmitry Baryshkov
2025-12-24 16:13   ` kernel test robot
2025-12-26 13:21   ` Linus Walleij
2025-12-26 14:16     ` Marijn Suijten
2025-12-26 14:23       ` Marijn Suijten
2025-12-26 17:43       ` Linus Walleij
2025-12-29 11:43         ` Marijn Suijten
2025-12-29 12:39           ` Linus Walleij
2025-12-21 23:32 ` [PATCH v2 06/11] dt-bindings: display: panel: Describe Samsung SOFEF03-M DDIC Marijn Suijten
2025-12-22  3:51   ` Rob Herring (Arm)
2025-12-22  8:33   ` Krzysztof Kozlowski
2025-12-22  8:36     ` Krzysztof Kozlowski
2025-12-28 22:49       ` Marijn Suijten
2025-12-30  1:53         ` Rob Herring
2025-12-28 22:31     ` Marijn Suijten
2025-12-21 23:32 ` [PATCH v2 07/11] drm/panel: Add panel driver for " Marijn Suijten
2025-12-24  1:15   ` Dmitry Baryshkov
2025-12-24  9:43   ` Marijn Suijten
2025-12-21 23:32 ` [PATCH v2 08/11] dt-bindings: display: panel: Describe Samsung SOUXP00-A DDIC Marijn Suijten
2025-12-22  3:51   ` Rob Herring (Arm)
2025-12-21 23:32 ` [PATCH v2 09/11] drm/panel: Add panel driver for " Marijn Suijten
2025-12-24  1:15   ` Dmitry Baryshkov
2025-12-24 17:26   ` kernel test robot
2026-02-26 12:04   ` David Heidelberg
2025-12-21 23:32 ` [PATCH v2 10/11] dt-bindings: display: panel: Describe Samsung ANA6707 DDIC Marijn Suijten
2025-12-22  3:51   ` Rob Herring (Arm)
2025-12-21 23:32 ` [PATCH v2 11/11] drm/panel: Add panel driver for " Marijn Suijten
2025-12-24  1:16   ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aVJpbJEymWWQLK6O@SoMainline.org \
    --to=marijn.suijten@somainline.org \
    --cc=agross@kernel.org \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=casey.connolly@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jami.kettunen@somainline.org \
    --cc=jesszhan0024@gmail.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=martin.botka@somainline.org \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_jesszhan@quicinc.com \
    --cc=quic_khsieh@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=simona.vetter@ffwll.ch \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.