From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2ECB9E94120 for ; Tue, 30 Dec 2025 08:55:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 842A210E171; Tue, 30 Dec 2025 08:55:17 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="UQvhw2Cb"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8076F10E171; Tue, 30 Dec 2025 08:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1767084916; x=1798620916; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=DIUWg89A9uqjQJSa8uU7nqynCwHKpJnUH0bwlQIa0Eo=; b=UQvhw2Cbv2YT/2coDI+Mw0yCBBTUMIluEfYbATBi8KahLbtCUwb5jEYg uGg/UjPKibJoIg3HWzRmyViKY2EMYT9Egw7D8C8ECo/WtoElDVkqE09Wd /vPjhzROex7gMKJnZ9yWXuVSfD0jD14oxIf9codPJZjsFnGKsW1gbAfg7 gpN1NonfjgKzeDZTfA9d1bm4O7Yjf4gUoY8/FOUWYMHwMxtX9mOwuw1xB bsQVL5SJLV9cTh++XYXzBI1G+r84cCxIxzRcErvN51AF8hxv+05HP0/t/ QyD3K3ahflR79Ws8Lvbisvm49Zy4WkzSK8uB+LykfbuihtqCEaJVlQ9t0 Q==; X-CSE-ConnectionGUID: gl5lroi6SiSLoC3rnQLpBA== X-CSE-MsgGUID: gdWzpY22Qam/4Z1+NqexUw== X-IronPort-AV: E=McAfee;i="6800,10657,11656"; a="56248180" X-IronPort-AV: E=Sophos;i="6.21,188,1763452800"; d="scan'208";a="56248180" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Dec 2025 00:55:16 -0800 X-CSE-ConnectionGUID: LM6UUyFmSBmENn61vwtC3A== X-CSE-MsgGUID: WjgB+I+XRlqqfcoeZHvIGA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,188,1763452800"; d="scan'208";a="201161436" Received: from egrumbac-mobl6.ger.corp.intel.com (HELO localhost) ([10.245.245.103]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Dec 2025 00:55:10 -0800 Date: Tue, 30 Dec 2025 10:55:08 +0200 From: Andy Shevchenko To: Mathieu Desnoyers Cc: Steven Rostedt , Andrew Morton , "Yury Norov (NVIDIA)" , Masami Hiramatsu , Christophe Leroy , Randy Dunlap , Ingo Molnar , Jani Nikula , Joonas Lahtinen , David Laight , Petr Pavlu , Andi Shyti , Rodrigo Vivi , Tvrtko Ursulin , Daniel Gomez , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH v4 7/7] kernel.h: drop trace_printk.h Message-ID: References: <20251225170930.1151781-1-yury.norov@gmail.com> <20251225170930.1151781-8-yury.norov@gmail.com> <20251226115848.298465d4@gandalf.local.home> <20251228133150.1d5731d04bc1b685b0fe81c1@linux-foundation.org> <20251229111748.3ba66311@gandalf.local.home> <9833cb61-1ec5-4cc1-ad9d-3e07f3deff80@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9833cb61-1ec5-4cc1-ad9d-3e07f3deff80@efficios.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Dec 29, 2025 at 05:25:08PM -0500, Mathieu Desnoyers wrote: ... > One possible compromise would be to move it to its own header file, > and introduce a CONFIG_TRACE_PRINTK Kconfig option (default Y) that > would surround an include from linux/kernel.h with a preprocessor > conditional. But please make sure the default stays as it is today: > include the trace printk header by default. "by default" where exactly? The problem is that kernel.h is a total mess and it's included in a lot of mysterious ways (indirectly), and in C you _must_ include a header anyway for a custom API, just define *which* one. Based on the Steven's first replies I see a compromise in having it inside printk.h. If you want to debug something with printf() (in general) the same header should provide all species. Do you agree? -- With Best Regards, Andy Shevchenko