From: Niklas Cassel <cassel@kernel.org>
To: manivannan.sadhasivam@oss.qualcomm.com
Cc: "Manivannan Sadhasivam" <mani@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, "Chen-Yu Tsai" <wens@kernel.org>,
"Brian Norris" <briannorris@chromium.org>,
"Krishna Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com>,
"Alex Elder" <elder@riscstar.com>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v3 6/7] PCI: qcom: Drop the assert_perst() callbacks
Date: Tue, 30 Dec 2025 13:42:54 +0100 [thread overview]
Message-ID: <aVPIzp97pEFjIYBr@ryzen> (raw)
In-Reply-To: <aVPGMJkleqTJezpX@ryzen>
On Tue, Dec 30, 2025 at 01:31:50PM +0100, Niklas Cassel wrote:
> On Mon, Dec 29, 2025 at 10:56:57PM +0530, Manivannan Sadhasivam via B4 Relay wrote:
>
> Now when all pwrctrl drivers have been converted to new pwrctrl design,
> there is no need for the .assert_perst() callback in the controller drivers,
> because with the new design, the actual work by the pwrctrl driver will have
> been done before the controller driver enumerates the bus. There is thus no
> longer any need for .assert_perst() callbacks in the controller drivers.
s/before the controller driver enumerates the bus/before the controller driver
asserts + desserts PERST# and starts link training/
Kind regards,
Niklas
next prev parent reply other threads:[~2025-12-30 12:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 17:26 [PATCH v3 0/7] PCI/pwrctrl: Major rework to integrate pwrctrl devices with controller drivers Manivannan Sadhasivam
2025-12-29 17:26 ` Manivannan Sadhasivam via B4 Relay
2025-12-29 17:26 ` [PATCH v3 1/7] PCI/pwrctrl: tc9563: Use put_device() instead of i2c_put_adapter() Manivannan Sadhasivam
2025-12-29 17:26 ` Manivannan Sadhasivam via B4 Relay
2026-01-02 13:42 ` Bartosz Golaszewski
2025-12-29 17:26 ` [PATCH v3 2/7] PCI/pwrctrl: Add 'struct pci_pwrctrl::power_{on/off}' callbacks Manivannan Sadhasivam
2025-12-29 17:26 ` Manivannan Sadhasivam via B4 Relay
2026-01-02 13:58 ` Bartosz Golaszewski
2025-12-29 17:26 ` [PATCH v3 3/7] PCI/pwrctrl: Add APIs for explicitly creating and destroying pwrctrl devices Manivannan Sadhasivam
2025-12-29 17:26 ` Manivannan Sadhasivam via B4 Relay
2026-01-02 13:46 ` Bartosz Golaszewski
2025-12-29 17:26 ` [PATCH v3 4/7] PCI/pwrctrl: Add APIs to power on/off the " Manivannan Sadhasivam
2025-12-29 17:26 ` Manivannan Sadhasivam via B4 Relay
2025-12-29 17:26 ` [PATCH v3 5/7] PCI/pwrctrl: Switch to the new pwrctrl APIs Manivannan Sadhasivam
2025-12-29 17:26 ` Manivannan Sadhasivam via B4 Relay
2026-01-02 13:56 ` Bartosz Golaszewski
2025-12-29 17:26 ` [PATCH v3 6/7] PCI: qcom: Drop the assert_perst() callbacks Manivannan Sadhasivam
2025-12-29 17:26 ` Manivannan Sadhasivam via B4 Relay
2025-12-30 12:31 ` Niklas Cassel
2025-12-30 12:42 ` Niklas Cassel [this message]
2025-12-29 17:26 ` [PATCH v3 7/7] PCI: qcom: Rename PERST# assert/deassert helpers for uniformity Manivannan Sadhasivam
2025-12-29 17:26 ` Manivannan Sadhasivam via B4 Relay
2026-01-02 13:58 ` Bartosz Golaszewski
2025-12-30 10:35 ` [PATCH v3 0/7] PCI/pwrctrl: Major rework to integrate pwrctrl devices with controller drivers Niklas Cassel
2025-12-30 10:52 ` Manivannan Sadhasivam
2025-12-30 11:31 ` Niklas Cassel
2025-12-30 12:33 ` Manivannan Sadhasivam
2025-12-30 12:35 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVPIzp97pEFjIYBr@ryzen \
--to=cassel@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=briannorris@chromium.org \
--cc=elder@riscstar.com \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.