From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/nolibc: drop NOLIBC_SYSROOT=0 logic
Date: Sun, 4 Jan 2026 17:43:17 +0100 [thread overview]
Message-ID: <aVqYpdCpD8jAAA2X@1wt.eu> (raw)
In-Reply-To: <20260104-nolibc-nolibc_sysroot-v1-1-98025ad99add@weissschuh.net>
On Sun, Jan 04, 2026 at 03:57:51PM +0100, Thomas Weißschuh wrote:
> This logic was added in commit 850fad7de827 ("selftests/nolibc: allow
> test -include /path/to/nolibc.h") to allow the testing of -include
> /path/to/nolibc.h. As it requires as special variable to activate, this
> code is nearly never used. Furthermore it complicates the logic a bit.
>
> Since commit a6a054c8ad32 ("tools/nolibc: add target to check header
> usability") and commit 443c6467fcd6 ("selftests/nolibc: always run
> nolibc header check") the usability of -include /path/to/nolibc.h is
> always checked anyways, making NOLIBC_SYSROOT=0 pointless.
>
> Drop the special logic.
I think that it was historically needed when we used to build by doing
-include nolibc.h but now that we've adopted most of the common headers,
we no longer build that way and instead use the sysroot, so yes, let's
drop this.
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Acked-by: Willy Tarreau <w@1wt.eu>
Willy
prev parent reply other threads:[~2026-01-04 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-04 14:57 [PATCH] selftests/nolibc: drop NOLIBC_SYSROOT=0 logic Thomas Weißschuh
2026-01-04 16:43 ` Willy Tarreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVqYpdCpD8jAAA2X@1wt.eu \
--to=w@1wt.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.