From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.trustedfirmware.org (lists.trustedfirmware.org [18.214.241.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45323C2A075 for ; Mon, 5 Jan 2026 08:48:32 +0000 (UTC) Received: from lists.trustedfirmware.org (localhost [127.0.0.1]) by lists.trustedfirmware.org (Postfix) with ESMTP id 81C7141A35 for ; Mon, 5 Jan 2026 08:48:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.trustedfirmware.org; s=2024; t=1767602911; bh=FNWHsoQrO0c4Fkjgbh6dsTo4+7nALwInUCL2MnuM+1o=; h=Date:To:Subject:References:In-Reply-To:CC:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Reply-To:From; b=vYW0g3J3iFmAChE6vgSSLMCQA7kGOtgEUowm2nrj7A8UmhGedj0vFJuuiOeEhjC3+ RLK78poqahKyqLKskzLna5an7XxwZqoP47kX9Yc7hgIcNK/OW1EFr8avtmeFxsQXFZ rQquElx+spwvyhbv2Wtk0j0E4ZASL4/+P7NZ7BdZrVb3aeE/06bfxBvv4OX1CepZt0 8UuB7zyETW0uI0xqWcP5/B3G+rlvWFg+rb9rA6T18C9cE2a5C/AYwN+F90dp7wbi4Q 5k+G8RJEZNJV1iY0ISrOycHOqeEWRHORkgqIbNGA05QZEgemmwcJ94j/oScgiCp3xh lFAEyWSVWaVOg== Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by lists.trustedfirmware.org (Postfix) with ESMTPS id 0798841A35 for ; Mon, 5 Jan 2026 08:48:12 +0000 (UTC) Authentication-Results: lists.trustedfirmware.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=QfoPWOm9; dkim-atps=neutral Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 442E543817; Mon, 5 Jan 2026 08:48:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE4D8C116D0; Mon, 5 Jan 2026 08:48:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767602891; bh=2JJa9XU/T6ZAbGv1R8f4336fBzCc7cHmcaC1Xb76Tfk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QfoPWOm9r5GyzBrMvmG4+OI8F3ikEIB/upouzk9Xuq+ni4TRGnW4v8ZUeZiv+6ocq H6irmrDIzfWLK7YVVMU8NboHeQTd6kGwmAcGEHNq5ALf070xayb09zm5tembNR647h UdfdSF20Avt71lWJ8rPa+QUjpStpNZ3830vBT8YS9o5iZ8ACpUPclJd4uhFxCdv9B5 pyfFmh4oXohqM+CvPZ06UeJZaE0wjbQKc/fLOF7iMsAvrvqXi9FitaAGwpU/89vzbW jb5LlFMCIx83RJYKQ4McDsgS7encF8ca/03zVACe5FGXbTdzE5J5YVA+t3W2log27E qk0UccE7bY1Hg== Date: Mon, 5 Jan 2026 14:18:04 +0530 To: Aristo Chen Subject: Re: [PATCH v4 2/2] tee: optee: store OS revision for TEE core Message-ID: References: <20251226131920.64582-1-aristo.chen@canonical.com> <20251230051804.6230-1-aristo.chen@canonical.com> <20251230051804.6230-2-aristo.chen@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: base64 In-Reply-To: X-Rspamd-Action: no action X-Spamd-Result: default: False [-2.00 / 15.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; DMARC_POLICY_ALLOW(-0.50)[kernel.org,quarantine]; MID_RHS_NOT_FQDN(0.50)[]; R_SPF_ALLOW(-0.20)[+ip4:172.234.252.31]; R_DKIM_ALLOW(-0.20)[kernel.org:s=k20201202]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:63949, ipnet:172.234.224.0/19, country:SG]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; DWL_DNSWL_BLOCKED(0.00)[kernel.org:dkim]; RCPT_COUNT_SEVEN(0.00)[9]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; ALIAS_RESOLVED(0.00)[]; DKIM_TRACE(0.00)[kernel.org:+] X-Rspamd-Server: lists.trustedfirmware.org X-Rspamd-Queue-Id: 0798841A35 X-Spamd-Bar: -- Message-ID-Hash: GKZJ2YONV253FB5QRR63IZKRZMC6B75F X-Message-ID-Hash: GKZJ2YONV253FB5QRR63IZKRZMC6B75F X-MailFrom: sumit.garg@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-op-tee.lists.trustedfirmware.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: linux-kernel@vger.kernel.org, op-tee@lists.trustedfirmware.org, harshal.dev@oss.qualcomm.com, mario.limonciello@amd.com, Rijo-john.Thomas@amd.com, amirreza.zarrabi@oss.qualcomm.com, Aristo Chen X-Mailman-Version: 3.3.5 Precedence: list List-Id: Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Sumit Garg via OP-TEE Reply-To: Sumit Garg T24gTW9uLCBKYW4gMDUsIDIwMjYgYXQgMDQ6MTM6NTJQTSArMDgwMCwgQXJpc3RvIENoZW4gd3Jv dGU6DQo+IEhpIFN1bWl0LA0KPiANCj4gU3VtaXQgR2FyZyA8c3VtaXQuZ2FyZ0BrZXJuZWwub3Jn PiDmlrwgMjAyNuW5tDHmnIg15pel6YCx5LiAIOS4i+WNiDE6MjDlr6vpgZPvvJoNCj4gPg0KPiA+ IE9uIFR1ZSwgRGVjIDMwLCAyMDI1IGF0IDAxOjE3OjU5UE0gKzA4MDAsIEFyaXN0byBDaGVuIHdy b3RlOg0KPiA+ID4gQ29sbGVjdCBPUC1URUUgT1MgcmV2aXNpb24gZnJvbSBzZWN1cmUgd29ybGQg Zm9yIGJvdGggU01DIGFuZCBGRi1BIEFCSXMsDQo+ID4gPiBzdG9yZSBpdCBpbiB0aGUgT1AtVEVF IGRyaXZlciwgYW5kIGV4cG9zZSBpdCB0aHJvdWdoIHRoZSBnZW5lcmljDQo+ID4gPiBnZXRfdGVl X3JldmlzaW9uKCkgY2FsbGJhY2suDQo+ID4gPg0KPiA+ID4gU2lnbmVkLW9mZi1ieTogQXJpc3Rv IENoZW4gPGFyaXN0by5jaGVuQGNhbm9uaWNhbC5jb20+DQo+ID4gPiAtLS0NCj4gPiA+ICBkcml2 ZXJzL3RlZS9vcHRlZS9jb3JlLmMgICAgICAgICAgfCAyMyArKysrKysrKysrKysrKysrKysrKysr Kw0KPiA+ID4gIGRyaXZlcnMvdGVlL29wdGVlL2ZmYV9hYmkuYyAgICAgICB8IDE0ICsrKysrKysr KysrKy0tDQo+ID4gPiAgZHJpdmVycy90ZWUvb3B0ZWUvb3B0ZWVfcHJpdmF0ZS5oIHwgMTkgKysr KysrKysrKysrKysrKysrKw0KPiA+ID4gIGRyaXZlcnMvdGVlL29wdGVlL3NtY19hYmkuYyAgICAg ICB8IDE1ICsrKysrKysrKysrKystLQ0KPiA+ID4gIDQgZmlsZXMgY2hhbmdlZCwgNjcgaW5zZXJ0 aW9ucygrKSwgNCBkZWxldGlvbnMoLSkNCj4gPiA+DQo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy90ZWUvb3B0ZWUvY29yZS5jIGIvZHJpdmVycy90ZWUvb3B0ZWUvY29yZS5jDQo+ID4gPiBpbmRl eCA1YjYyMTM5NzE0Y2UuLjJkODA3YmM3NDhiYyAxMDA2NDQNCj4gPiA+IC0tLSBhL2RyaXZlcnMv dGVlL29wdGVlL2NvcmUuYw0KPiA+ID4gKysrIGIvZHJpdmVycy90ZWUvb3B0ZWUvY29yZS5jDQo+ ID4gPiBAQCAtNjMsNiArNjMsMjkgQEAgaW50IG9wdGVlX3NldF9kbWFfbWFzayhzdHJ1Y3Qgb3B0 ZWUgKm9wdGVlLCB1X2ludCBwYV93aWR0aCkNCj4gPiA+ICAgICAgIHJldHVybiBkbWFfY29lcmNl X21hc2tfYW5kX2NvaGVyZW50KCZvcHRlZS0+dGVlZGV2LT5kZXYsIG1hc2spOw0KPiA+ID4gIH0N Cj4gPiA+DQo+ID4gPiAraW50IG9wdGVlX2dldF9yZXZpc2lvbihzdHJ1Y3QgdGVlX2RldmljZSAq dGVlZGV2LCBjaGFyICpidWYsIHNpemVfdCBsZW4pDQo+ID4gPiArew0KPiA+ID4gKyAgICAgc3Ry dWN0IG9wdGVlICpvcHRlZSA9IHRlZV9nZXRfZHJ2ZGF0YSh0ZWVkZXYpOw0KPiA+ID4gKyAgICAg dTY0IGJ1aWxkX2lkOw0KPiA+ID4gKw0KPiA+ID4gKyAgICAgaWYgKCFvcHRlZSkNCj4gPiA+ICsg ICAgICAgICAgICAgcmV0dXJuIC1FTk9ERVY7DQo+ID4gPiArICAgICBpZiAoIWJ1ZiB8fCAhbGVu KQ0KPiA+ID4gKyAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsNCj4gPiA+ICsNCj4gPiA+ICsg ICAgIGJ1aWxkX2lkID0gb3B0ZWUtPnJldmlzaW9uLm9zX2J1aWxkX2lkOw0KPiA+ID4gKyAgICAg aWYgKGJ1aWxkX2lkKQ0KPiA+ID4gKyAgICAgICAgICAgICBzY25wcmludGYoYnVmLCBsZW4sICIl dS4ldSAoJTAxNmxseCkiLA0KPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgb3B0ZWUtPnJl dmlzaW9uLm9zX21ham9yLA0KPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgb3B0ZWUtPnJl dmlzaW9uLm9zX21pbm9yLA0KPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgKHVuc2lnbmVk IGxvbmcgbG9uZylidWlsZF9pZCk7DQo+ID4gPiArICAgICBlbHNlDQo+ID4gPiArICAgICAgICAg ICAgIHNjbnByaW50ZihidWYsIGxlbiwgIiV1LiV1Iiwgb3B0ZWUtPnJldmlzaW9uLm9zX21ham9y LA0KPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgb3B0ZWUtPnJldmlzaW9uLm9zX21pbm9y KTsNCj4gPiA+ICsNCj4gPiA+ICsgICAgIHJldHVybiAwOw0KPiA+ID4gK30NCj4gPiA+ICsNCj4g PiA+ICBzdGF0aWMgdm9pZCBvcHRlZV9idXNfc2NhbihzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmsp DQo+ID4gPiAgew0KPiA+ID4gICAgICAgV0FSTl9PTihvcHRlZV9lbnVtZXJhdGVfZGV2aWNlcyhQ VEFfQ01EX0dFVF9ERVZJQ0VTX1NVUFApKTsNCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3Rl ZS9vcHRlZS9mZmFfYWJpLmMgYi9kcml2ZXJzL3RlZS9vcHRlZS9mZmFfYWJpLmMNCj4gPiA+IGlu ZGV4IGJmODM5MDc4OWVjZi4uZDY3Y2ExZWM5NTA2IDEwMDY0NA0KPiA+ID4gLS0tIGEvZHJpdmVy cy90ZWUvb3B0ZWUvZmZhX2FiaS5jDQo+ID4gPiArKysgYi9kcml2ZXJzL3RlZS9vcHRlZS9mZmFf YWJpLmMNCj4gPiA+IEBAIC03NzYsNyArNzc2LDggQEAgc3RhdGljIGludCBvcHRlZV9mZmFfcmVj bGFpbV9wcm90bWVtKHN0cnVjdCBvcHRlZSAqb3B0ZWUsDQo+ID4gPiAgICovDQo+ID4gPg0KPiA+ ID4gIHN0YXRpYyBib29sIG9wdGVlX2ZmYV9hcGlfaXNfY29tcGF0aWJsZShzdHJ1Y3QgZmZhX2Rl dmljZSAqZmZhX2RldiwNCj4gPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgY29uc3Qgc3RydWN0IGZmYV9vcHMgKm9wcykNCj4gPiA+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGZmYV9vcHMgKm9wcywNCj4gPiA+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IG9wdGVlX3JldmlzaW9uICpy ZXZpc2lvbikNCj4gPiA+ICB7DQo+ID4gPiAgICAgICBjb25zdCBzdHJ1Y3QgZmZhX21zZ19vcHMg Km1zZ19vcHMgPSBvcHMtPm1zZ19vcHM7DQo+ID4gPiAgICAgICBzdHJ1Y3QgZmZhX3NlbmRfZGly ZWN0X2RhdGEgZGF0YSA9IHsNCj4gPiA+IEBAIC04MDYsNiArODA3LDExIEBAIHN0YXRpYyBib29s IG9wdGVlX2ZmYV9hcGlfaXNfY29tcGF0aWJsZShzdHJ1Y3QgZmZhX2RldmljZSAqZmZhX2RldiwN Cj4gPiA+ICAgICAgICAgICAgICAgcHJfZXJyKCJVbmV4cGVjdGVkIGVycm9yICVkXG4iLCByYyk7 DQo+ID4gPiAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsNCj4gPiA+ICAgICAgIH0NCj4gPiA+ ICsgICAgIGlmIChyZXZpc2lvbikgew0KPiA+ID4gKyAgICAgICAgICAgICByZXZpc2lvbi0+b3Nf bWFqb3IgPSBkYXRhLmRhdGEwOw0KPiA+ID4gKyAgICAgICAgICAgICByZXZpc2lvbi0+b3NfbWlu b3IgPSBkYXRhLmRhdGExOw0KPiA+ID4gKyAgICAgICAgICAgICByZXZpc2lvbi0+b3NfYnVpbGRf aWQgPSBkYXRhLmRhdGEyOw0KPiA+ID4gKyAgICAgfQ0KPiA+ID4gICAgICAgaWYgKGRhdGEuZGF0 YTIpDQo+ID4gPiAgICAgICAgICAgICAgIHByX2luZm8oInJldmlzaW9uICVsdS4lbHUgKCUwOGx4 KSIsDQo+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgZGF0YS5kYXRhMCwgZGF0YS5kYXRhMSwg ZGF0YS5kYXRhMik7DQo+ID4gPiBAQCAtOTAwLDYgKzkwNiw3IEBAIHN0YXRpYyBpbnQgb3B0ZWVf ZmZhX29wZW4oc3RydWN0IHRlZV9jb250ZXh0ICpjdHgpDQo+ID4gPg0KPiA+ID4gIHN0YXRpYyBj b25zdCBzdHJ1Y3QgdGVlX2RyaXZlcl9vcHMgb3B0ZWVfZmZhX2NsbnRfb3BzID0gew0KPiA+ID4g ICAgICAgLmdldF92ZXJzaW9uID0gb3B0ZWVfZmZhX2dldF92ZXJzaW9uLA0KPiA+ID4gKyAgICAg LmdldF90ZWVfcmV2aXNpb24gPSBvcHRlZV9nZXRfcmV2aXNpb24sDQo+ID4gPiAgICAgICAub3Bl biA9IG9wdGVlX2ZmYV9vcGVuLA0KPiA+ID4gICAgICAgLnJlbGVhc2UgPSBvcHRlZV9yZWxlYXNl LA0KPiA+ID4gICAgICAgLm9wZW5fc2Vzc2lvbiA9IG9wdGVlX29wZW5fc2Vzc2lvbiwNCj4gPiA+ IEBAIC05MTgsNiArOTI1LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCB0ZWVfZGVzYyBvcHRlZV9m ZmFfY2xudF9kZXNjID0gew0KPiA+ID4NCj4gPiA+ICBzdGF0aWMgY29uc3Qgc3RydWN0IHRlZV9k cml2ZXJfb3BzIG9wdGVlX2ZmYV9zdXBwX29wcyA9IHsNCj4gPiA+ICAgICAgIC5nZXRfdmVyc2lv biA9IG9wdGVlX2ZmYV9nZXRfdmVyc2lvbiwNCj4gPiA+ICsgICAgIC5nZXRfdGVlX3JldmlzaW9u ID0gb3B0ZWVfZ2V0X3JldmlzaW9uLA0KPiA+ID4gICAgICAgLm9wZW4gPSBvcHRlZV9mZmFfb3Bl biwNCj4gPiA+ICAgICAgIC5yZWxlYXNlID0gb3B0ZWVfcmVsZWFzZV9zdXBwLA0KPiA+ID4gICAg ICAgLnN1cHBfcmVjdiA9IG9wdGVlX3N1cHBfcmVjdiwNCj4gPiA+IEBAIC0xMDM0LDYgKzEwNDIs NyBAQCBzdGF0aWMgaW50IG9wdGVlX2ZmYV9wcm9iZShzdHJ1Y3QgZmZhX2RldmljZSAqZmZhX2Rl dikNCj4gPiA+ICB7DQo+ID4gPiAgICAgICBjb25zdCBzdHJ1Y3QgZmZhX25vdGlmaWVyX29wcyAq bm90aWZfb3BzOw0KPiA+ID4gICAgICAgY29uc3Qgc3RydWN0IGZmYV9vcHMgKmZmYV9vcHM7DQo+ ID4gPiArICAgICBzdHJ1Y3Qgb3B0ZWVfcmV2aXNpb24gcmV2aXNpb24gPSB7IH07DQo+ID4NCj4g PiBObyBuZWVkIGZvciB0aGlzIHJlZHVuZGFudCB2YXJpYWJsZSBvbiBzdGFjayB3aGVuLi4uDQo+ ID4NCj4gPiA+ICAgICAgIHVuc2lnbmVkIGludCBtYXhfbm90aWZfdmFsdWU7DQo+ID4gPiAgICAg ICB1bnNpZ25lZCBpbnQgcnBjX3BhcmFtX2NvdW50Ow0KPiA+ID4gICAgICAgc3RydWN0IHRlZV9z aG1fcG9vbCAqcG9vbDsNCj4gPiA+IEBAIC0xMDQ3LDcgKzEwNTYsNyBAQCBzdGF0aWMgaW50IG9w dGVlX2ZmYV9wcm9iZShzdHJ1Y3QgZmZhX2RldmljZSAqZmZhX2RldikNCj4gPiA+ICAgICAgIGZm YV9vcHMgPSBmZmFfZGV2LT5vcHM7DQo+ID4gPiAgICAgICBub3RpZl9vcHMgPSBmZmFfb3BzLT5u b3RpZmllcl9vcHM7DQo+ID4gPg0KPiA+ID4gLSAgICAgaWYgKCFvcHRlZV9mZmFfYXBpX2lzX2Nv bXBhdGlibGUoZmZhX2RldiwgZmZhX29wcykpDQo+ID4gPiArICAgICBpZiAoIW9wdGVlX2ZmYV9h cGlfaXNfY29tcGF0aWJsZShmZmFfZGV2LCBmZmFfb3BzLCAmcmV2aXNpb24pKQ0KPiA+DQo+ID4g Li4ueW91IGNhbiBqdXN0IGludm9rZSB0aGlzIEFQSSBhcyByYXRoZXI6DQo+ID4NCj4gPiAgICAg ICAgIGlmICghb3B0ZWVfZmZhX2FwaV9pc19jb21wYXRpYmxlKGZmYV9kZXYsIGZmYV9vcHMsICZv cHRlZS0+cmV2aXNpb24pKQ0KPiA+DQo+IFRoYW5rcyBmb3IgdGhlIHJldmlldy4gVG8gYXZvaWQg dGhlIHRlbXBvcmFyeSBzdHJ1Y3Qgb3B0ZWVfcmV2aXNpb24sDQo+IEkgbmVlZCB0byBtb3ZlIHRo ZSBvcHRlZSBhbGxvY2F0aW9uIGVhcmxpZXIgc28gd2UgY2FuIHBhc3MNCj4gJm9wdGVlLT5yZXZp c2lvbiBpbnRvIG9wdGVlX2ZmYV9hcGlfaXNfY29tcGF0aWJsZSgpLg0KDQpJIHdvdWxkIHJhdGhl ciBzdWdnZXN0IHRvIHNwbGl0IHRoaXMgQVBJIHRvIGFkZCBhIG5ldyBvbmUgbGlrZQ0Kb3B0ZWVf ZmZhX2dldF9vc19yZXZpc2lvbigpIGFuZCB0aGVuIG1vdmUgaXQncyBpbnZvY2F0aW9uIG9uY2Ug b3B0ZWUNCnN0cnVjdCBoYXMgYmVlbiBhbGxvY2F0ZWQuDQoNCj4gDQo+IEFGQUlDVCwgdGhlcmUg YXJlbuKAmXQga2VybmVsIHNlbGZ0ZXN0cyBjb3ZlcmluZyB0aGlzLCB0aGUgb25seSB0ZXN0IHRo YXQNCj4gSSBhbSBhd2FyZSBvZiBpcyB0aGUgeHRlc3QsIHNvIEnigJltIHNsaWdodGx5IGNhdXRp b3VzIGFib3V0IHRvdWNoaW5nDQo+IHByb2JlIG9yZGVyaW5nLiBJZiB5b3UgcHJlZmVyIHRvIGF2 b2lkIHRoZSBlYXJseSBhbGxvY2F0aW9uLCBJIGNhbiBrZWVwDQo+IHRoZSBvcmlnaW5hbCBvcmRl ciBhbmQgdXNlIGEgbG9jYWwgc3RydWN0IG9wdGVlX3JldmlzaW9uIGluc3RlYWQuDQoNCldpdGgg YWJvdmUgc3VnZ2VzdGlvbiwgdGhlIHByb2JlIG9yZGVyaW5nIHdvbid0IGNoYW5nZSBtdWNoIGJ1 dCByYXRoZXINCnRoZSBwb2ludCBjaGFuZ2VzIHdoZW4geW91IGFzayBPUC1URUUgZm9yIGl0J3Mg cmV2aXNpb24uDQoNCi1TdW1pdA0KDQo+IA0KPiBQbGVhc2UgbGV0IG1lIGtub3cgd2hpY2ggeW91 4oCZZCBwcmVmZXINCj4gDQo+ID4gPiAgICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPiA+ ID4NCj4gPiA+ICAgICAgIGlmICghb3B0ZWVfZmZhX2V4Y2hhbmdlX2NhcHMoZmZhX2RldiwgZmZh X29wcywgJnNlY19jYXBzLA0KPiA+ID4gQEAgLTEwNTksNiArMTA2OCw3IEBAIHN0YXRpYyBpbnQg b3B0ZWVfZmZhX3Byb2JlKHN0cnVjdCBmZmFfZGV2aWNlICpmZmFfZGV2KQ0KPiA+ID4gICAgICAg b3B0ZWUgPSBremFsbG9jKHNpemVvZigqb3B0ZWUpLCBHRlBfS0VSTkVMKTsNCj4gPiA+ICAgICAg IGlmICghb3B0ZWUpDQo+ID4gPiAgICAgICAgICAgICAgIHJldHVybiAtRU5PTUVNOw0KPiA+ID4g KyAgICAgb3B0ZWUtPnJldmlzaW9uID0gcmV2aXNpb247DQo+ID4gPg0KPiA+ID4gICAgICAgcG9v bCA9IG9wdGVlX2ZmYV9zaG1fcG9vbF9hbGxvY19wYWdlcygpOw0KPiA+ID4gICAgICAgaWYgKElT X0VSUihwb29sKSkgew0KPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdGVlL29wdGVlL29wdGVl X3ByaXZhdGUuaCBiL2RyaXZlcnMvdGVlL29wdGVlL29wdGVlX3ByaXZhdGUuaA0KPiA+ID4gaW5k ZXggZGI5ZWE2NzNmYmNhLi5hY2QzMDUxYzQ4NzkgMTAwNjQ0DQo+ID4gPiAtLS0gYS9kcml2ZXJz L3RlZS9vcHRlZS9vcHRlZV9wcml2YXRlLmgNCj4gPiA+ICsrKyBiL2RyaXZlcnMvdGVlL29wdGVl L29wdGVlX3ByaXZhdGUuaA0KPiA+ID4gQEAgLTE3MSw2ICsxNzEsMjQgQEAgc3RydWN0IG9wdGVl X2ZmYSB7DQo+ID4gPg0KPiA+ID4gIHN0cnVjdCBvcHRlZTsNCj4gPiA+DQo+ID4gPiArLyoqDQo+ ID4gPiArICogc3RydWN0IG9wdGVlX3JldmlzaW9uIC0gT1AtVEVFIE9TIHJldmlzaW9uIHJlcG9y dGVkIGJ5IHNlY3VyZSB3b3JsZA0KPiA+ID4gKyAqIEBvc19tYWpvcjogICAgICAgICAgICAgICAg T1AtVEVFIE9TIG1ham9yIHZlcnNpb24NCj4gPiA+ICsgKiBAb3NfbWlub3I6ICAgICAgICAgICAg ICAgIE9QLVRFRSBPUyBtaW5vciB2ZXJzaW9uDQo+ID4gPiArICogQG9zX2J1aWxkX2lkOiAgICAg T1AtVEVFIE9TIGJ1aWxkIGlkZW50aWZpZXIgKDAgaWYgdW5zcGVjaWZpZWQpDQo+ID4gPiArICoN Cj4gPiA+ICsgKiBWYWx1ZXMgY29tZSBmcm9tIE9QVEVFX1NNQ19DQUxMX0dFVF9PU19SRVZJU0lP TiAoU01DIEFCSSkgb3INCj4gPiA+ICsgKiBPUFRFRV9GRkFfR0VUX09TX1ZFUlNJT04gKEZGLUEg QUJJKTsgdGhpcyBpcyB0aGUgdHJ1c3RlZCBPUyByZXZpc2lvbiwgbm90IGFuDQo+ID4gPiArICog RkYtQSBBQkkgdmVyc2lvbi4NCj4gPiA+ICsgKi8NCj4gPiA+ICtzdHJ1Y3Qgb3B0ZWVfcmV2aXNp b24gew0KPiA+ID4gKyAgICAgdTMyIG9zX21ham9yOw0KPiA+ID4gKyAgICAgdTMyIG9zX21pbm9y Ow0KPiA+ID4gKyAgICAgdTY0IG9zX2J1aWxkX2lkOw0KPiA+ID4gK307DQo+ID4gPiArDQo+ID4g PiAraW50IG9wdGVlX2dldF9yZXZpc2lvbihzdHJ1Y3QgdGVlX2RldmljZSAqdGVlZGV2LCBjaGFy ICpidWYsIHNpemVfdCBsZW4pOw0KPiA+ID4gKw0KPiA+ID4gIC8qKg0KPiA+ID4gICAqIHN0cnVj dCBvcHRlZV9vcHMgLSBPUC1URUUgZHJpdmVyIGludGVybmFsIG9wZXJhdGlvbnMNCj4gPiA+ICAg KiBAZG9fY2FsbF93aXRoX2FyZzogICAgICAgIGVudGVycyBPUC1URUUgaW4gc2VjdXJlIHdvcmxk DQo+ID4gPiBAQCAtMjQ5LDYgKzI2Nyw3IEBAIHN0cnVjdCBvcHRlZSB7DQo+ID4gPiAgICAgICBi b29sIGluX2tlcm5lbF9ycG1iX3JvdXRpbmc7DQo+ID4gPiAgICAgICBzdHJ1Y3Qgd29ya19zdHJ1 Y3Qgc2Nhbl9idXNfd29yazsNCj4gPiA+ICAgICAgIHN0cnVjdCB3b3JrX3N0cnVjdCBycG1iX3Nj YW5fYnVzX3dvcms7DQo+ID4gPiArICAgICBzdHJ1Y3Qgb3B0ZWVfcmV2aXNpb24gcmV2aXNpb247 DQo+ID4gPiAgfTsNCj4gPiA+DQo+ID4gPiAgc3RydWN0IG9wdGVlX3Nlc3Npb24gew0KPiA+ID4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvdGVlL29wdGVlL3NtY19hYmkuYyBiL2RyaXZlcnMvdGVlL29w dGVlL3NtY19hYmkuYw0KPiA+ID4gaW5kZXggMGJlNjYzZmNkNTJiLi4wYmFhZjc5ODZhMzUgMTAw NjQ0DQo+ID4gPiAtLS0gYS9kcml2ZXJzL3RlZS9vcHRlZS9zbWNfYWJpLmMNCj4gPiA+ICsrKyBi L2RyaXZlcnMvdGVlL29wdGVlL3NtY19hYmkuYw0KPiA+ID4gQEAgLTEyNDIsNiArMTI0Miw3IEBA IHN0YXRpYyBpbnQgb3B0ZWVfc21jX29wZW4oc3RydWN0IHRlZV9jb250ZXh0ICpjdHgpDQo+ID4g Pg0KPiA+ID4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgdGVlX2RyaXZlcl9vcHMgb3B0ZWVfY2xudF9v cHMgPSB7DQo+ID4gPiAgICAgICAuZ2V0X3ZlcnNpb24gPSBvcHRlZV9nZXRfdmVyc2lvbiwNCj4g PiA+ICsgICAgIC5nZXRfdGVlX3JldmlzaW9uID0gb3B0ZWVfZ2V0X3JldmlzaW9uLA0KPiA+ID4g ICAgICAgLm9wZW4gPSBvcHRlZV9zbWNfb3BlbiwNCj4gPiA+ICAgICAgIC5yZWxlYXNlID0gb3B0 ZWVfcmVsZWFzZSwNCj4gPiA+ICAgICAgIC5vcGVuX3Nlc3Npb24gPSBvcHRlZV9vcGVuX3Nlc3Np b24sDQo+ID4gPiBAQCAtMTI2MSw2ICsxMjYyLDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCB0ZWVf ZGVzYyBvcHRlZV9jbG50X2Rlc2MgPSB7DQo+ID4gPg0KPiA+ID4gIHN0YXRpYyBjb25zdCBzdHJ1 Y3QgdGVlX2RyaXZlcl9vcHMgb3B0ZWVfc3VwcF9vcHMgPSB7DQo+ID4gPiAgICAgICAuZ2V0X3Zl cnNpb24gPSBvcHRlZV9nZXRfdmVyc2lvbiwNCj4gPiA+ICsgICAgIC5nZXRfdGVlX3JldmlzaW9u ID0gb3B0ZWVfZ2V0X3JldmlzaW9uLA0KPiA+ID4gICAgICAgLm9wZW4gPSBvcHRlZV9zbWNfb3Bl biwNCj4gPiA+ICAgICAgIC5yZWxlYXNlID0gb3B0ZWVfcmVsZWFzZV9zdXBwLA0KPiA+ID4gICAg ICAgLnN1cHBfcmVjdiA9IG9wdGVlX3N1cHBfcmVjdiwNCj4gPiA+IEBAIC0xMzIzLDcgKzEzMjUs OCBAQCBzdGF0aWMgYm9vbCBvcHRlZV9tc2dfYXBpX3VpZF9pc19vcHRlZV9pbWFnZV9sb2FkKG9w dGVlX2ludm9rZV9mbiAqaW52b2tlX2ZuKQ0KPiA+ID4gIH0NCj4gPiA+ICAjZW5kaWYNCj4gPiA+ DQo+ID4gPiAtc3RhdGljIHZvaWQgb3B0ZWVfbXNnX2dldF9vc19yZXZpc2lvbihvcHRlZV9pbnZv a2VfZm4gKmludm9rZV9mbikNCj4gPiA+ICtzdGF0aWMgdm9pZCBvcHRlZV9tc2dfZ2V0X29zX3Jl dmlzaW9uKG9wdGVlX2ludm9rZV9mbiAqaW52b2tlX2ZuLA0KPiA+ID4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgc3RydWN0IG9wdGVlX3JldmlzaW9uICpyZXZpc2lvbikNCj4g PiA+ICB7DQo+ID4gPiAgICAgICB1bmlvbiB7DQo+ID4gPiAgICAgICAgICAgICAgIHN0cnVjdCBh cm1fc21jY2NfcmVzIHNtY2NjOw0KPiA+ID4gQEAgLTEzMzcsNiArMTM0MCwxMiBAQCBzdGF0aWMg dm9pZCBvcHRlZV9tc2dfZ2V0X29zX3JldmlzaW9uKG9wdGVlX2ludm9rZV9mbiAqaW52b2tlX2Zu KQ0KPiA+ID4gICAgICAgaW52b2tlX2ZuKE9QVEVFX1NNQ19DQUxMX0dFVF9PU19SRVZJU0lPTiwg MCwgMCwgMCwgMCwgMCwgMCwgMCwNCj4gPiA+ICAgICAgICAgICAgICAgICAmcmVzLnNtY2NjKTsN Cj4gPiA+DQo+ID4gPiArICAgICBpZiAocmV2aXNpb24pIHsNCj4gPiA+ICsgICAgICAgICAgICAg cmV2aXNpb24tPm9zX21ham9yID0gcmVzLnJlc3VsdC5tYWpvcjsNCj4gPiA+ICsgICAgICAgICAg ICAgcmV2aXNpb24tPm9zX21pbm9yID0gcmVzLnJlc3VsdC5taW5vcjsNCj4gPiA+ICsgICAgICAg ICAgICAgcmV2aXNpb24tPm9zX2J1aWxkX2lkID0gcmVzLnJlc3VsdC5idWlsZF9pZDsNCj4gPiA+ ICsgICAgIH0NCj4gPiA+ICsNCj4gPiA+ICAgICAgIGlmIChyZXMucmVzdWx0LmJ1aWxkX2lkKQ0K PiA+ID4gICAgICAgICAgICAgICBwcl9pbmZvKCJyZXZpc2lvbiAlbHUuJWx1ICglMCpseCkiLCBy ZXMucmVzdWx0Lm1ham9yLA0KPiA+ID4gICAgICAgICAgICAgICAgICAgICAgIHJlcy5yZXN1bHQu bWlub3IsIChpbnQpc2l6ZW9mKHJlcy5yZXN1bHQuYnVpbGRfaWQpICogMiwNCj4gPiA+IEBAIC0x NzI3LDYgKzE3MzYsNyBAQCBzdGF0aWMgaW50IG9wdGVlX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9k ZXZpY2UgKnBkZXYpDQo+ID4gPiAgICAgICB1bnNpZ25lZCBpbnQgdGhyZWFkX2NvdW50Ow0KPiA+ ID4gICAgICAgc3RydWN0IHRlZV9kZXZpY2UgKnRlZWRldjsNCj4gPiA+ICAgICAgIHN0cnVjdCB0 ZWVfY29udGV4dCAqY3R4Ow0KPiA+ID4gKyAgICAgc3RydWN0IG9wdGVlX3JldmlzaW9uIHJldmlz aW9uID0geyB9Ow0KPiA+DQo+ID4gRGl0dG8gaGVyZS4NCj4gPg0KPiA+IC1TdW1pdA0KPiA+DQo+ ID4gPiAgICAgICB1MzIgbWF4X25vdGlmX3ZhbHVlOw0KPiA+ID4gICAgICAgdTMyIGFyZ19jYWNo ZV9mbGFnczsNCj4gPiA+ICAgICAgIHUzMiBzZWNfY2FwczsNCj4gPiA+IEBAIC0xNzQ1LDcgKzE3 NTUsNyBAQCBzdGF0aWMgaW50IG9wdGVlX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpDQo+ID4gPiAgICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPiA+ID4gICAgICAgfQ0K PiA+ID4NCj4gPiA+IC0gICAgIG9wdGVlX21zZ19nZXRfb3NfcmV2aXNpb24oaW52b2tlX2ZuKTsN Cj4gPiA+ICsgICAgIG9wdGVlX21zZ19nZXRfb3NfcmV2aXNpb24oaW52b2tlX2ZuLCAmcmV2aXNp b24pOw0KPiA+ID4NCj4gPiA+ICAgICAgIGlmICghb3B0ZWVfbXNnX2FwaV9yZXZpc2lvbl9pc19j b21wYXRpYmxlKGludm9rZV9mbikpIHsNCj4gPiA+ICAgICAgICAgICAgICAgcHJfd2FybigiYXBp IHJldmlzaW9uIG1pc21hdGNoXG4iKTsNCj4gPiA+IEBAIC0xODM3LDYgKzE4NDcsNyBAQCBzdGF0 aWMgaW50IG9wdGVlX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpDQo+ID4gPiAg ICAgICAgICAgICAgIGdvdG8gZXJyX3VucmVnX3RlZWRldjsNCj4gPiA+ICAgICAgIH0NCj4gPiA+ ICAgICAgIG9wdGVlLT5zdXBwX3RlZWRldiA9IHRlZWRldjsNCj4gPiA+ICsgICAgIG9wdGVlLT5y ZXZpc2lvbiA9IHJldmlzaW9uOw0KPiA+ID4NCj4gPiA+ICAgICAgIG9wdGVlX3NldF9kZXZfZ3Jv dXAob3B0ZWUpOw0KPiA+ID4NCj4gPiA+IC0tDQo+ID4gPiAyLjQzLjANCj4gPiA+DQo+IA0KPiBC ZXN0IHJlZ2FyZHMsDQo+IEFyaXN0bw0K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C34832572E for ; Mon, 5 Jan 2026 08:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767602892; cv=none; b=VnmPwt6ZRC7HtjXHHdw1Ud8OZeO0bmCEuTyV/IvTnAGG8MzaUNYBVvMm/vudvmhZt+2bfeyhCW3H+MNSpsCpQA1ki5lh5YxERCspaLQiB82INWWf1HEJpvCvJSQUxov4Lcguh/SeiEkOlppG1KLO+Oz3CafSw22tqLOS/ZtSUkI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767602892; c=relaxed/simple; bh=2JJa9XU/T6ZAbGv1R8f4336fBzCc7cHmcaC1Xb76Tfk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mUqImC0WefZbvoDQQPcLd5sW9yssu4/cASe/n68ft91wp0j/77BJ7ySvwT3b+tIBfaTs0+bAm4hP0XzjNVRx9Sr4c663NEnRqHEl1cXuHIV6IcaS4n/Kv7g8J9OXYrz9QYIXU4TybBPhBnZnzrqkFLtIIbTVYWvl84Udj1i8sLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QfoPWOm9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QfoPWOm9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE4D8C116D0; Mon, 5 Jan 2026 08:48:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767602891; bh=2JJa9XU/T6ZAbGv1R8f4336fBzCc7cHmcaC1Xb76Tfk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QfoPWOm9r5GyzBrMvmG4+OI8F3ikEIB/upouzk9Xuq+ni4TRGnW4v8ZUeZiv+6ocq H6irmrDIzfWLK7YVVMU8NboHeQTd6kGwmAcGEHNq5ALf070xayb09zm5tembNR647h UdfdSF20Avt71lWJ8rPa+QUjpStpNZ3830vBT8YS9o5iZ8ACpUPclJd4uhFxCdv9B5 pyfFmh4oXohqM+CvPZ06UeJZaE0wjbQKc/fLOF7iMsAvrvqXi9FitaAGwpU/89vzbW jb5LlFMCIx83RJYKQ4McDsgS7encF8ca/03zVACe5FGXbTdzE5J5YVA+t3W2log27E qk0UccE7bY1Hg== Date: Mon, 5 Jan 2026 14:18:04 +0530 From: Sumit Garg To: Aristo Chen Cc: linux-kernel@vger.kernel.org, jens.wiklander@linaro.org, op-tee@lists.trustedfirmware.org, harshal.dev@oss.qualcomm.com, mario.limonciello@amd.com, Rijo-john.Thomas@amd.com, amirreza.zarrabi@oss.qualcomm.com, Aristo Chen Subject: Re: [PATCH v4 2/2] tee: optee: store OS revision for TEE core Message-ID: References: <20251226131920.64582-1-aristo.chen@canonical.com> <20251230051804.6230-1-aristo.chen@canonical.com> <20251230051804.6230-2-aristo.chen@canonical.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jan 05, 2026 at 04:13:52PM +0800, Aristo Chen wrote: > Hi Sumit, > > Sumit Garg 於 2026年1月5日週一 下午1:20寫道： > > > > On Tue, Dec 30, 2025 at 01:17:59PM +0800, Aristo Chen wrote: > > > Collect OP-TEE OS revision from secure world for both SMC and FF-A ABIs, > > > store it in the OP-TEE driver, and expose it through the generic > > > get_tee_revision() callback. > > > > > > Signed-off-by: Aristo Chen > > > --- > > > drivers/tee/optee/core.c | 23 +++++++++++++++++++++++ > > > drivers/tee/optee/ffa_abi.c | 14 ++++++++++++-- > > > drivers/tee/optee/optee_private.h | 19 +++++++++++++++++++ > > > drivers/tee/optee/smc_abi.c | 15 +++++++++++++-- > > > 4 files changed, 67 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c > > > index 5b62139714ce..2d807bc748bc 100644 > > > --- a/drivers/tee/optee/core.c > > > +++ b/drivers/tee/optee/core.c > > > @@ -63,6 +63,29 @@ int optee_set_dma_mask(struct optee *optee, u_int pa_width) > > > return dma_coerce_mask_and_coherent(&optee->teedev->dev, mask); > > > } > > > > > > +int optee_get_revision(struct tee_device *teedev, char *buf, size_t len) > > > +{ > > > + struct optee *optee = tee_get_drvdata(teedev); > > > + u64 build_id; > > > + > > > + if (!optee) > > > + return -ENODEV; > > > + if (!buf || !len) > > > + return -EINVAL; > > > + > > > + build_id = optee->revision.os_build_id; > > > + if (build_id) > > > + scnprintf(buf, len, "%u.%u (%016llx)", > > > + optee->revision.os_major, > > > + optee->revision.os_minor, > > > + (unsigned long long)build_id); > > > + else > > > + scnprintf(buf, len, "%u.%u", optee->revision.os_major, > > > + optee->revision.os_minor); > > > + > > > + return 0; > > > +} > > > + > > > static void optee_bus_scan(struct work_struct *work) > > > { > > > WARN_ON(optee_enumerate_devices(PTA_CMD_GET_DEVICES_SUPP)); > > > diff --git a/drivers/tee/optee/ffa_abi.c b/drivers/tee/optee/ffa_abi.c > > > index bf8390789ecf..d67ca1ec9506 100644 > > > --- a/drivers/tee/optee/ffa_abi.c > > > +++ b/drivers/tee/optee/ffa_abi.c > > > @@ -776,7 +776,8 @@ static int optee_ffa_reclaim_protmem(struct optee *optee, > > > */ > > > > > > static bool optee_ffa_api_is_compatible(struct ffa_device *ffa_dev, > > > - const struct ffa_ops *ops) > > > + const struct ffa_ops *ops, > > > + struct optee_revision *revision) > > > { > > > const struct ffa_msg_ops *msg_ops = ops->msg_ops; > > > struct ffa_send_direct_data data = { > > > @@ -806,6 +807,11 @@ static bool optee_ffa_api_is_compatible(struct ffa_device *ffa_dev, > > > pr_err("Unexpected error %d\n", rc); > > > return false; > > > } > > > + if (revision) { > > > + revision->os_major = data.data0; > > > + revision->os_minor = data.data1; > > > + revision->os_build_id = data.data2; > > > + } > > > if (data.data2) > > > pr_info("revision %lu.%lu (%08lx)", > > > data.data0, data.data1, data.data2); > > > @@ -900,6 +906,7 @@ static int optee_ffa_open(struct tee_context *ctx) > > > > > > static const struct tee_driver_ops optee_ffa_clnt_ops = { > > > .get_version = optee_ffa_get_version, > > > + .get_tee_revision = optee_get_revision, > > > .open = optee_ffa_open, > > > .release = optee_release, > > > .open_session = optee_open_session, > > > @@ -918,6 +925,7 @@ static const struct tee_desc optee_ffa_clnt_desc = { > > > > > > static const struct tee_driver_ops optee_ffa_supp_ops = { > > > .get_version = optee_ffa_get_version, > > > + .get_tee_revision = optee_get_revision, > > > .open = optee_ffa_open, > > > .release = optee_release_supp, > > > .supp_recv = optee_supp_recv, > > > @@ -1034,6 +1042,7 @@ static int optee_ffa_probe(struct ffa_device *ffa_dev) > > > { > > > const struct ffa_notifier_ops *notif_ops; > > > const struct ffa_ops *ffa_ops; > > > + struct optee_revision revision = { }; > > > > No need for this redundant variable on stack when... > > > > > unsigned int max_notif_value; > > > unsigned int rpc_param_count; > > > struct tee_shm_pool *pool; > > > @@ -1047,7 +1056,7 @@ static int optee_ffa_probe(struct ffa_device *ffa_dev) > > > ffa_ops = ffa_dev->ops; > > > notif_ops = ffa_ops->notifier_ops; > > > > > > - if (!optee_ffa_api_is_compatible(ffa_dev, ffa_ops)) > > > + if (!optee_ffa_api_is_compatible(ffa_dev, ffa_ops, &revision)) > > > > ...you can just invoke this API as rather: > > > > if (!optee_ffa_api_is_compatible(ffa_dev, ffa_ops, &optee->revision)) > > > Thanks for the review. To avoid the temporary struct optee_revision, > I need to move the optee allocation earlier so we can pass > &optee->revision into optee_ffa_api_is_compatible(). I would rather suggest to split this API to add a new one like optee_ffa_get_os_revision() and then move it's invocation once optee struct has been allocated. > > AFAICT, there aren’t kernel selftests covering this, the only test that > I am aware of is the xtest, so I’m slightly cautious about touching > probe ordering. If you prefer to avoid the early allocation, I can keep > the original order and use a local struct optee_revision instead. With above suggestion, the probe ordering won't change much but rather the point changes when you ask OP-TEE for it's revision. -Sumit > > Please let me know which you’d prefer > > > > return -EINVAL; > > > > > > if (!optee_ffa_exchange_caps(ffa_dev, ffa_ops, &sec_caps, > > > @@ -1059,6 +1068,7 @@ static int optee_ffa_probe(struct ffa_device *ffa_dev) > > > optee = kzalloc(sizeof(*optee), GFP_KERNEL); > > > if (!optee) > > > return -ENOMEM; > > > + optee->revision = revision; > > > > > > pool = optee_ffa_shm_pool_alloc_pages(); > > > if (IS_ERR(pool)) { > > > diff --git a/drivers/tee/optee/optee_private.h b/drivers/tee/optee/optee_private.h > > > index db9ea673fbca..acd3051c4879 100644 > > > --- a/drivers/tee/optee/optee_private.h > > > +++ b/drivers/tee/optee/optee_private.h > > > @@ -171,6 +171,24 @@ struct optee_ffa { > > > > > > struct optee; > > > > > > +/** > > > + * struct optee_revision - OP-TEE OS revision reported by secure world > > > + * @os_major: OP-TEE OS major version > > > + * @os_minor: OP-TEE OS minor version > > > + * @os_build_id: OP-TEE OS build identifier (0 if unspecified) > > > + * > > > + * Values come from OPTEE_SMC_CALL_GET_OS_REVISION (SMC ABI) or > > > + * OPTEE_FFA_GET_OS_VERSION (FF-A ABI); this is the trusted OS revision, not an > > > + * FF-A ABI version. > > > + */ > > > +struct optee_revision { > > > + u32 os_major; > > > + u32 os_minor; > > > + u64 os_build_id; > > > +}; > > > + > > > +int optee_get_revision(struct tee_device *teedev, char *buf, size_t len); > > > + > > > /** > > > * struct optee_ops - OP-TEE driver internal operations > > > * @do_call_with_arg: enters OP-TEE in secure world > > > @@ -249,6 +267,7 @@ struct optee { > > > bool in_kernel_rpmb_routing; > > > struct work_struct scan_bus_work; > > > struct work_struct rpmb_scan_bus_work; > > > + struct optee_revision revision; > > > }; > > > > > > struct optee_session { > > > diff --git a/drivers/tee/optee/smc_abi.c b/drivers/tee/optee/smc_abi.c > > > index 0be663fcd52b..0baaf7986a35 100644 > > > --- a/drivers/tee/optee/smc_abi.c > > > +++ b/drivers/tee/optee/smc_abi.c > > > @@ -1242,6 +1242,7 @@ static int optee_smc_open(struct tee_context *ctx) > > > > > > static const struct tee_driver_ops optee_clnt_ops = { > > > .get_version = optee_get_version, > > > + .get_tee_revision = optee_get_revision, > > > .open = optee_smc_open, > > > .release = optee_release, > > > .open_session = optee_open_session, > > > @@ -1261,6 +1262,7 @@ static const struct tee_desc optee_clnt_desc = { > > > > > > static const struct tee_driver_ops optee_supp_ops = { > > > .get_version = optee_get_version, > > > + .get_tee_revision = optee_get_revision, > > > .open = optee_smc_open, > > > .release = optee_release_supp, > > > .supp_recv = optee_supp_recv, > > > @@ -1323,7 +1325,8 @@ static bool optee_msg_api_uid_is_optee_image_load(optee_invoke_fn *invoke_fn) > > > } > > > #endif > > > > > > -static void optee_msg_get_os_revision(optee_invoke_fn *invoke_fn) > > > +static void optee_msg_get_os_revision(optee_invoke_fn *invoke_fn, > > > + struct optee_revision *revision) > > > { > > > union { > > > struct arm_smccc_res smccc; > > > @@ -1337,6 +1340,12 @@ static void optee_msg_get_os_revision(optee_invoke_fn *invoke_fn) > > > invoke_fn(OPTEE_SMC_CALL_GET_OS_REVISION, 0, 0, 0, 0, 0, 0, 0, > > > &res.smccc); > > > > > > + if (revision) { > > > + revision->os_major = res.result.major; > > > + revision->os_minor = res.result.minor; > > > + revision->os_build_id = res.result.build_id; > > > + } > > > + > > > if (res.result.build_id) > > > pr_info("revision %lu.%lu (%0*lx)", res.result.major, > > > res.result.minor, (int)sizeof(res.result.build_id) * 2, > > > @@ -1727,6 +1736,7 @@ static int optee_probe(struct platform_device *pdev) > > > unsigned int thread_count; > > > struct tee_device *teedev; > > > struct tee_context *ctx; > > > + struct optee_revision revision = { }; > > > > Ditto here. > > > > -Sumit > > > > > u32 max_notif_value; > > > u32 arg_cache_flags; > > > u32 sec_caps; > > > @@ -1745,7 +1755,7 @@ static int optee_probe(struct platform_device *pdev) > > > return -EINVAL; > > > } > > > > > > - optee_msg_get_os_revision(invoke_fn); > > > + optee_msg_get_os_revision(invoke_fn, &revision); > > > > > > if (!optee_msg_api_revision_is_compatible(invoke_fn)) { > > > pr_warn("api revision mismatch\n"); > > > @@ -1837,6 +1847,7 @@ static int optee_probe(struct platform_device *pdev) > > > goto err_unreg_teedev; > > > } > > > optee->supp_teedev = teedev; > > > + optee->revision = revision; > > > > > > optee_set_dev_group(optee); > > > > > > -- > > > 2.43.0 > > > > > Best regards, > Aristo