From: Sean Christopherson <seanjc@google.com>
To: Yosry Ahmed <yosry.ahmed@linux.dev>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Andrew Jones <andrew.jones@linux.dev>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH] x86: Increase the timeout for vmx_pf_{vpid/no_vpid/invvpid}_test
Date: Mon, 5 Jan 2026 09:54:13 -0800 [thread overview]
Message-ID: <aVv6xaI0hYwgB0ce@google.com> (raw)
In-Reply-To: <20260102183039.496725-1-yosry.ahmed@linux.dev>
On Fri, Jan 02, 2026, Yosry Ahmed wrote:
> When running the tests on some older CPUs (e.g. Skylake) on a kernel
> with some debug config options enabled (e.g. CONFIG_DEBUG_VM,
> CONFIG_PROVE_LOCKING, ..), the tests timeout. In this specific setup,
> the tests take between 4 and 5 minutes, so pump the timeout from 4 to 6
> minutes.
Ugh. Can anyone think of a not-insane way to skip these tests when running in
an environment that is going to be sloooooow? Because (a) a 6 minute timeout
could very well hide _real_ KVM bugs, e.g. if is being too aggressive with TLB
flushes (speaking from experience) and (b) running a 5+ minute test is a likely
a waste of time/resources.
> Signed-off-by: Yosry Ahmed <yosry.ahmed@linux.dev>
> ---
> x86/unittests.cfg | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/x86/unittests.cfg b/x86/unittests.cfg
> index 522318d32bf6..bb2b9f033b11 100644
> --- a/x86/unittests.cfg
> +++ b/x86/unittests.cfg
> @@ -427,7 +427,7 @@ test_args = "vmx_pf_vpid_test"
> qemu_params = -cpu max,+vmx
> arch = x86_64
> groups = vmx nested_exception nodefault
> -timeout = 240
> +timeout = 360
>
> [vmx_pf_invvpid_test]
> file = vmx.flat
> @@ -435,7 +435,7 @@ test_args = "vmx_pf_invvpid_test"
> qemu_params = -cpu max,+vmx
> arch = x86_64
> groups = vmx nested_exception nodefault
> -timeout = 240
> +timeout = 360
>
> [vmx_pf_no_vpid_test]
> file = vmx.flat
> @@ -443,7 +443,7 @@ test_args = "vmx_pf_no_vpid_test"
> qemu_params = -cpu max,+vmx
> arch = x86_64
> groups = vmx nested_exception nodefault
> -timeout = 240
> +timeout = 360
>
> [vmx_pf_exception_test_reduced_maxphyaddr]
> file = vmx.flat
> --
> 2.52.0.351.gbe84eed79e-goog
>
next prev parent reply other threads:[~2026-01-05 17:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 18:30 [kvm-unit-tests PATCH] x86: Increase the timeout for vmx_pf_{vpid/no_vpid/invvpid}_test Yosry Ahmed
2026-01-05 17:54 ` Sean Christopherson [this message]
2026-01-05 18:23 ` Yosry Ahmed
2026-01-05 19:19 ` Sean Christopherson
2026-01-05 19:42 ` Yosry Ahmed
2026-01-05 21:16 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVv6xaI0hYwgB0ce@google.com \
--to=seanjc@google.com \
--cc=andrew.jones@linux.dev \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.