From: Yohei Kojima <yk@y-koj.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Breno Leitao <leitao@debian.org>,
Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2 1/2] net: netdevsim: fix inconsistent carrier state after link/unlink
Date: Tue, 6 Jan 2026 00:36:09 +0900 [thread overview]
Message-ID: <aVvaaeoutGR0Fk7W@desktop.y-koj.net> (raw)
In-Reply-To: <20260104105422.57542bd4@kernel.org>
On Sun, Jan 04, 2026 at 10:54:22AM -0800, Jakub Kicinski wrote:
> On Wed, 31 Dec 2025 01:03:29 +0900 yk@y-koj.net wrote:
> > + netif_carrier_on(dev_a);
> > + netif_carrier_on(dev_b);
>
> if (netif_running(dev_a) && netif_running(dev_b)) {
> /// your code
> }
>
> right? If one side is down there should be no carrier.
That's right. I have updated the first patch with netif_running()
checks accordingly.
Here is the v3 series including the fix:
https://lore.kernel.org/netdev/cover.1767624906.git.yk@y-koj.net/T/
Thank you,
Yohei Kojima
> --
> pw-bot: cr
next prev parent reply other threads:[~2026-01-05 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 16:03 [PATCH net v2 0/2] net: netdevsim: fix inconsistent carrier state after link/unlink yk
2025-12-30 16:03 ` [PATCH net v2 1/2] " yk
2025-12-31 10:16 ` Breno Leitao
2025-12-31 16:06 ` Yohei Kojima
2026-01-04 18:54 ` Jakub Kicinski
2026-01-05 15:36 ` Yohei Kojima [this message]
2025-12-30 16:03 ` [PATCH net v2 2/2] selftests: netdevsim: add carrier state consistency test yk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVvaaeoutGR0Fk7W@desktop.y-koj.net \
--to=yk@y-koj.net \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.