From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Yao Zi <me@ziyao.cc>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Frank <Frank.Sae@motor-comm.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Choong Yong Liang <yong.liang.choong@linux.intel.com>,
Chen-Yu Tsai <wens@csie.org>, Jisheng Zhang <jszhang@kernel.org>,
Furong Xu <0x1207@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Mingcong Bai <jeffbai@aosc.io>,
Kexy Biscuit <kexybiscuit@aosc.io>, Runhua He <hua@aosc.io>,
Xi Ruoyao <xry111@xry111.site>
Subject: Re: [RFC PATCH net-next v5 2/3] net: stmmac: Add glue driver for Motorcomm YT6801 ethernet controller
Date: Mon, 5 Jan 2026 16:54:03 +0000 [thread overview]
Message-ID: <aVvsq7HKOJ0RKwrA@shell.armlinux.org.uk> (raw)
In-Reply-To: <20251225071914.1903-3-me@ziyao.cc>
On Thu, Dec 25, 2025 at 07:19:13AM +0000, Yao Zi wrote:
> +struct dwmac_motorcomm_priv {
> + void __iomem *base;
> + struct device *dev;
This is only setup in the probe function, and then only used when
reading the MAC address to print error messages - which is called
from the probe function. Would it make more sense to pass the struct
device into motorcomm_efuse_read_mac(), especially as it uses
dev_err_probe() which suggests this function can only be called from
the probe path.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2026-01-05 16:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-25 7:19 [RFC PATCH net-next v5 0/3] Add DWMAC glue driver for Motorcomm YT6801 Yao Zi
2025-12-25 7:19 ` [RFC PATCH net-next v5 1/3] net: phy: motorcomm: Support YT8531S PHY in YT6801 Ethernet controller Yao Zi
2025-12-25 10:23 ` Andrew Lunn
2025-12-25 7:19 ` [RFC PATCH net-next v5 2/3] net: stmmac: Add glue driver for Motorcomm YT6801 ethernet controller Yao Zi
2026-01-05 16:54 ` Russell King (Oracle) [this message]
2025-12-25 7:19 ` [RFC PATCH net-next v5 3/3] MAINTAINERS: Assign myself as maintainer of Motorcomm DWMAC glue driver Yao Zi
[not found] ` <aVvnsuklPxbFna20@pie>
2026-01-05 16:58 ` [RFC PATCH net-next v5 0/3] Add DWMAC glue driver for Motorcomm YT6801 Russell King (Oracle)
2026-01-07 3:03 ` Yao Zi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVvsq7HKOJ0RKwrA@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=0x1207@gmail.com \
--cc=Frank.Sae@motor-comm.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=hua@aosc.io \
--cc=jeffbai@aosc.io \
--cc=jszhang@kernel.org \
--cc=kexybiscuit@aosc.io \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@ziyao.cc \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=wens@csie.org \
--cc=xry111@xry111.site \
--cc=yong.liang.choong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.