From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, berrange@redhat.com,
Mark Kanda <mark.kanda@oracle.com>,
Ben Chaney <bchaney@akamai.com>
Subject: Re: [PATCH v2 22/25] migration: Free cpr-transfer MigrationAddress along with gsource
Date: Mon, 5 Jan 2026 16:03:41 -0500 [thread overview]
Message-ID: <aVwnLQ-4Hp8NGdbR@x1.local> (raw)
In-Reply-To: <20260105190644.14072-23-farosas@suse.de>
On Mon, Jan 05, 2026 at 04:06:39PM -0300, Fabiano Rosas wrote:
> When setting a callback on a Glib source and giving it a data pointer,
> it's natural to also provide the destructor for the data in question.
>
> Since migrate_hup_add() already needs to clone the MigrationAddress
> when setting the qmp_migrate_finish_cb callback, also pass the
> qapi_free_MigrationAddress as the GDestroyNotify callback.
>
> With this the address doesn't need to be freed at the callback body,
> making the management of that memory slight simpler.
>
> (also fix the indentation of migrate_hup_add)
>
> Cc: Mark Kanda <mark.kanda@oracle.com>
> Cc: Ben Chaney <bchaney@akamai.com>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2026-01-05 21:04 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 19:06 [PATCH v2 00/25] migration: Cleanup early connection code Fabiano Rosas
2026-01-05 19:06 ` [PATCH v2 01/25] migration: Remove redundant state change Fabiano Rosas
2026-01-05 19:06 ` [PATCH v2 02/25] migration: Fix state change at migration_channel_process_incoming Fabiano Rosas
2026-01-05 19:06 ` [PATCH v2 03/25] migration/tls: Remove unused parameter Fabiano Rosas
2026-01-05 19:06 ` [PATCH v2 04/25] migration: Cleanup TLS handshake hostname passing Fabiano Rosas
2026-01-05 19:06 ` [PATCH v2 05/25] migration: Move postcopy_try_recover into migration_incoming_process Fabiano Rosas
2026-01-05 19:06 ` [PATCH v2 06/25] migration: Use migrate_mode() to query for cpr-transfer Fabiano Rosas
2026-01-05 19:06 ` [PATCH v2 07/25] migration: Free the error earlier in the resume case Fabiano Rosas
2026-01-05 19:06 ` [PATCH v2 08/25] migration: Move error reporting out of migration_cleanup Fabiano Rosas
2026-01-05 19:06 ` [PATCH v2 09/25] migration: Expand migration_connect_error_propagate to cover cancelling Fabiano Rosas
2026-01-05 19:06 ` [PATCH v2 10/25] migration: yank: Move register instance earlier Fabiano Rosas
2026-01-05 19:06 ` [PATCH v2 11/25] migration: Fold migration_cleanup() into migration_connect_error_propagate() Fabiano Rosas
2026-01-05 19:06 ` [PATCH v2 12/25] migration: Handle error in the early async paths Fabiano Rosas
2026-01-05 19:06 ` [PATCH v2 13/25] migration: Move setting of QEMUFile into migration_outgoing|incoming_setup Fabiano Rosas
2026-01-05 19:30 ` Peter Xu
2026-01-05 19:06 ` [PATCH v2 14/25] migration/rdma: Use common connection paths Fabiano Rosas
2026-01-05 19:37 ` Peter Xu
2026-01-05 19:06 ` [PATCH v2 15/25] migration: Start incoming from channel.c Fabiano Rosas
2026-01-05 19:41 ` Peter Xu
2026-01-05 19:06 ` [PATCH v2 16/25] migration/channel: Rename migration_channel_connect Fabiano Rosas
2026-01-05 19:44 ` Peter Xu
2026-01-05 19:06 ` [PATCH v2 17/25] migration: Rename instances of start Fabiano Rosas
2026-01-05 19:46 ` Peter Xu
2026-01-05 19:06 ` [PATCH v2 18/25] migration: Move channel code to channel.c Fabiano Rosas
2026-01-05 19:47 ` Peter Xu
2026-01-05 19:06 ` [PATCH v2 19/25] migration: Move transport connection code into channel.c Fabiano Rosas
2026-01-05 19:49 ` Peter Xu
2026-01-05 19:06 ` [PATCH v2 20/25] migration: Move channel parsing to channel.c Fabiano Rosas
2026-01-05 21:00 ` Peter Xu
2026-01-05 19:06 ` [PATCH v2 21/25] migration: Move URI " Fabiano Rosas
2026-01-05 21:01 ` Peter Xu
2026-01-05 19:06 ` [PATCH v2 22/25] migration: Free cpr-transfer MigrationAddress along with gsource Fabiano Rosas
2026-01-05 21:03 ` Peter Xu [this message]
2026-01-05 19:06 ` [PATCH v2 23/25] migration: Move CPR HUP watch to cpr-transfer.c Fabiano Rosas
2026-01-05 21:05 ` Peter Xu
2026-01-05 19:06 ` [PATCH v2 24/25] migration: Remove qmp_migrate_finish Fabiano Rosas
2026-01-05 21:18 ` Peter Xu
2026-01-05 19:06 ` [PATCH v2 25/25] migration/channel: Centralize calling migration_channel_connect_outgoing Fabiano Rosas
2026-01-05 21:32 ` Peter Xu
2026-01-06 13:55 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVwnLQ-4Hp8NGdbR@x1.local \
--to=peterx@redhat.com \
--cc=bchaney@akamai.com \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=mark.kanda@oracle.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.