From: Mike Rapoport <rppt@kernel.org>
To: "David Hildenbrand (Red Hat)" <david@kernel.org>
Cc: "Michal Hocko" <mhocko@suse.com>,
"mingzhu.wang(王明珠)" <mingzhu.wang@transsion.com>,
"kees@kernel.org" <kees@kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"dietmar.eggemann@arm.com" <dietmar.eggemann@arm.com>,
"mgorman@suse.de" <mgorman@suse.de>,
"vbabka@suse.cz" <vbabka@suse.cz>,
"surenb@google.com" <surenb@google.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Jiazi Li" <jqqlijiazi@gmail.com>
Subject: Re: [PATCH RESEND] kernel/fork: Update obsolete use_mm references to kthread_use_mm
Date: Tue, 6 Jan 2026 13:53:34 +0200 [thread overview]
Message-ID: <aVz3vlG2PlQ9JX_Z@kernel.org> (raw)
In-Reply-To: <cbcc95f1-5039-4fe3-bc7a-c8edc29f5b11@kernel.org>
On Tue, Jan 06, 2026 at 10:29:03AM +0100, David Hildenbrand (Red Hat) wrote:
> On 1/6/26 10:26, Michal Hocko wrote:
> > On Tue 06-01-26 07:05:28, mingzhu.wang(王明珠) wrote:
> > > The comment for get_task_mm() in kernel/fork.c incorrectly references the deprecated function `use_mm()`, which has been renamed to `kthread_use_mm()` in kernel/kthread.c.
> > > This patch updates the documentation to reflect the current function names, ensuring accuracy when developers refer to the kernel thread memory context API.
> > > No functional changes were introduced.
> > >
> > > Signed-off-by: mingzhu.wang <mingzhu.wang@transsion.com>
> > > ---
> > > kernel/fork.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/kernel/fork.c b/kernel/fork.c index c4ada32598bd..64e228c541bc 100644
> > > --- a/kernel/fork.c
> > > +++ b/kernel/fork.c
> > > @@ -1312,7 +1312,7 @@ struct file *get_task_exe_file(struct task_struct *task)
> > > * @task: The task.
> > > *
> > > * Returns %NULL if the task has no mm. Checks PF_KTHREAD (meaning
> > > - * this kernel workthread has transiently adopted a user mm with use_mm,
> > > + * this kernel workthread has transiently adopted a user mm with
> > > + kthread_use_mm,
> >
> > Please do not wrap the line here.
>
> But please do so in the patch description, where the maximum should usually
> be 72 characters per line. :)
75 ;-P
https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
> --
> Cheers
> David
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-01-06 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 7:05 [PATCH RESEND] kernel/fork: Update obsolete use_mm references to kthread_use_mm mingzhu.wang(王明珠)
2026-01-06 9:26 ` Michal Hocko
2026-01-06 9:29 ` David Hildenbrand (Red Hat)
2026-01-06 11:53 ` Mike Rapoport [this message]
2026-01-06 14:52 ` David Hildenbrand (Red Hat)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVz3vlG2PlQ9JX_Z@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=jqqlijiazi@gmail.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=mingzhu.wang@transsion.com \
--cc=peterz@infradead.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.