All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, "John Snow" <jsnow@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH] scripts: Allow sha512 in clean_functional_cache.py, too
Date: Tue, 20 Jan 2026 14:44:05 +0000	[thread overview]
Message-ID: <aW-UtVdnLwPUv7_H@redhat.com> (raw)
In-Reply-To: <4bee294c-e529-4e05-9bdb-48533aeff4f9@redhat.com>

On Tue, Jan 20, 2026 at 03:10:34PM +0100, Thomas Huth wrote:
> On 20/01/2026 14.02, Daniel P. Berrangé wrote:
> > On Tue, Jan 20, 2026 at 01:18:49PM +0100, Thomas Huth wrote:
> > > From: Thomas Huth <thuth@redhat.com>
> > > 
> > > The functional testing frameworks also supports assets that are
> > > identified by their sha512 checksum (instead of only using sha25),
> > > and at least one of the tests (tests/functional/ppc64/test_fadump.py)
> > > is already using such a checksum, so adjust the clean_functional_cache
> > > script to support these checksums, too.
> > 
> > I wrote this code to match what we had in Avocado, but now I'm really
> > struggling to justify why we should choose different checksum algorithms
> > per asset. With only 1 test diverging from sha256, I'd rather we just
> > dropped sha512 support
> 
> Fine for me, too ... could you suggest a patch, or want me to do it?

I'll let you do it

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



      reply	other threads:[~2026-01-20 14:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-20 12:18 [PATCH] scripts: Allow sha512 in clean_functional_cache.py, too Thomas Huth
2026-01-20 13:02 ` Daniel P. Berrangé
2026-01-20 14:10   ` Thomas Huth
2026-01-20 14:44     ` Daniel P. Berrangé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aW-UtVdnLwPUv7_H@redhat.com \
    --to=berrange@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.