From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, <anatoly.burakov@intel.com>
Subject: Re: [PATCH 2/3] test/eal_flags: add line numbers to error messages
Date: Tue, 20 Jan 2026 15:22:18 +0000 [thread overview]
Message-ID: <aW-dqgtWe6CBz8We@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260120070358.56bf69f0@phoenix.local>
On Tue, Jan 20, 2026 at 07:03:58AM -0800, Stephen Hemminger wrote:
> On Tue, 20 Jan 2026 11:25:51 +0000
> Bruce Richardson <bruce.richardson@intel.com> wrote:
>
> > To aid in debugging any problems, and because there are sometimes
> > multiple very similar error messages in tests, add line numbers to the
> > error message printouts.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Alternative but not required would be to the TEST_ASSERT macros
> which have file and line.
Yep. Agreed it would be better. However, for this patch I decided just to
add line numbers directly to minize churn to the code.
/Bruce
next prev parent reply other threads:[~2026-01-20 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 11:25 [PATCH 0/3] improve debug output for EAL flags unit tests Bruce Richardson
2026-01-20 11:25 ` [PATCH 1/3] app/test: add extra logging for recursive calls Bruce Richardson
2026-01-20 11:25 ` [PATCH 2/3] test/eal_flags: add line numbers to error messages Bruce Richardson
2026-01-20 15:03 ` Stephen Hemminger
2026-01-20 15:22 ` Bruce Richardson [this message]
2026-01-20 11:25 ` [PATCH 3/3] test/eal_flags: add extra logging for file prefix tests Bruce Richardson
2026-01-21 9:14 ` [PATCH 0/3] improve debug output for EAL flags unit tests David Marchand
2026-01-23 11:08 ` David Marchand
2026-01-23 11:28 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW-dqgtWe6CBz8We@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.