All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 2/5] Clean up header guards that don't match their file name
Date: Mon, 19 Jan 2026 10:35:03 +0000	[thread overview]
Message-ID: <aW4I1-Ro9R5l2bqK@redhat.com> (raw)
In-Reply-To: <20260119100537.463312-3-armbru@redhat.com>

On Mon, Jan 19, 2026 at 11:05:34AM +0100, Markus Armbruster wrote:
> Header guard symbols should match their file name to make guard
> collisions less likely.
> 
> Cleaned up with scripts/clean-header-guards.pl, followed by some
> renaming of new guard symbols picked by the script to better ones.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  accel/accel-internal.h                    | 2 +-
>  accel/tcg/tb-internal.h                   | 4 ++--
>  crypto/tlscredsbox.h                      | 6 +++---
>  hw/i386/tdvf-hob.h                        | 4 ++--
>  hw/riscv/riscv-iommu.h                    | 4 ++--
>  include/exec/page-protection.h            | 5 +++--
>  include/exec/replay-core.h                | 4 ++--
>  include/hw/acpi/ich9_tco.h                | 6 +++---
>  include/hw/audio/virtio-snd.h             | 4 ++--
>  include/hw/core/hw-error.h                | 4 ++--
>  include/hw/core/qdev.h                    | 4 ++--
>  include/hw/core/sysemu-cpu-ops.h          | 6 +++---
>  include/hw/loongarch/virt.h               | 4 ++--
>  include/hw/misc/sifive_e_aon.h            | 4 ++--
>  include/hw/misc/xlnx-versal-cfu.h         | 5 +++--
>  include/hw/net/xlnx-versal-canfd.h        | 4 ++--
>  include/hw/pci-bridge/cxl_upstream_port.h | 7 ++++---
>  include/hw/pci-host/fsl_imx8m_phy.h       | 4 ++--
>  include/hw/ppc/pnv_nest_pervasive.h       | 6 +++---
>  include/hw/ssi/pnv_spi_regs.h             | 4 ++--
>  include/hw/virtio/vdpa-dev.h              | 5 +++--
>  include/io/channel-null.h                 | 4 ++--
>  include/qapi/qmp-registry.h               | 4 ++--
>  include/qemu/target-info-qapi.h           | 4 ++--
>  include/system/cpu-timers-internal.h      | 6 +++---
>  include/system/dirtylimit.h               | 5 +++--
>  include/system/spdm-socket.h              | 4 ++--
>  include/user/tswap-target.h               | 5 +++--
>  target/arm/cpu-features.h                 | 4 ++--
>  target/arm/tcg/mte_helper.h               | 6 +++---
>  target/i386/confidential-guest.h          | 5 +++--
>  target/i386/emulate/x86.h                 | 4 ++--
>  target/i386/emulate/x86_decode.h          | 4 ++--
>  target/i386/emulate/x86_flags.h           | 6 +++---
>  target/sparc/translate.h                  | 5 +++--
>  target/xtensa/core-lx106/core-isa.h       | 7 +++----
>  36 files changed, 88 insertions(+), 81 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2026-01-19 10:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-19 10:05 [PATCH 0/5] Clean up header guards again Markus Armbruster
2026-01-19 10:05 ` [PATCH 1/5] scripts/clean-header-guards: Update exclusions Markus Armbruster
2026-01-19 10:33   ` Daniel P. Berrangé
2026-01-19 10:05 ` [PATCH 2/5] Clean up header guards that don't match their file name Markus Armbruster
2026-01-19 10:35   ` Daniel P. Berrangé [this message]
2026-01-19 10:05 ` [PATCH 3/5] Clean up ill-advised or unusual header guards Markus Armbruster
2026-01-19 10:35   ` Daniel P. Berrangé
2026-01-19 15:09   ` Warner Losh
2026-01-19 10:05 ` [PATCH 4/5] Normalize header guard symbol definition Markus Armbruster
2026-01-19 10:35   ` Daniel P. Berrangé
2026-01-19 10:05 ` [PATCH 5/5] Clean up decorations and whitespace around header guards Markus Armbruster
2026-01-19 10:36   ` Daniel P. Berrangé
2026-01-19 10:46 ` [PATCH 0/5] Clean up header guards again Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aW4I1-Ro9R5l2bqK@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.