All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Thompson <daniel@riscstar.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-trace-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Will Deacon <will@kernel.org>
Subject: Re: [PATCH] iommu: Fix NULL pointer deref when io_page_fault tracepoint fires
Date: Mon, 19 Jan 2026 14:39:28 +0000	[thread overview]
Message-ID: <aW5CIA1aCC8FVyFl@aspen.lan> (raw)
In-Reply-To: <fca8f2cd-c3e5-40b0-a793-bded109e37bc@web.de>

On Fri, Jan 16, 2026 at 05:02:35PM +0100, Markus Elfring wrote:
> …
> > Fix this by adding logic to the tracepoint to safely propagate NULL.
>
> * How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?

I could add a

Fixes: f8f934c180f6 ("iommu/arm-smmu: Add support for driver IOMMU fault handlers")

However, who do you think I neglected to Cc:?


> * Would a summary phrase like “Prevent null pointer dereference for a tracepoint”
>   be a bit nicer?

I don't understand what is wrong with the original phrasing. Can you
explain why this change matters to you?


Daniel.


  reply	other threads:[~2026-01-19 14:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-16 12:09 [PATCH] iommu: Fix NULL pointer deref when io_page_fault tracepoint fires Daniel Thompson
2026-01-16 16:02 ` Markus Elfring
2026-01-19 14:39   ` Daniel Thompson [this message]
2026-01-19 15:56     ` Markus Elfring
2026-01-19 16:15       ` Daniel Thompson
2026-01-21 21:26         ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aW5CIA1aCC8FVyFl@aspen.lan \
    --to=daniel@riscstar.com \
    --cc=Markus.Elfring@web.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=rostedt@goodmis.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.