From: Chao Gao <chao.gao@intel.com>
To: Dave Hansen <dave.hansen@linux.intel.com>
Cc: <linux-kernel@vger.kernel.org>, <sohil.mehta@intel.com>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Ingo Molnar <mingo@redhat.com>, Jon Kohler <jon@nutanix.com>,
Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Thomas Gleixner <tglx@kernel.org>,
Tony Luck <tony.luck@intel.com>, <x86@kernel.org>
Subject: Re: [PATCH 3/6] x86/microcode: Refactor platform ID enumeration into a helper
Date: Tue, 20 Jan 2026 11:07:35 +0800 [thread overview]
Message-ID: <aW7xdw8mF8hkd/5O@intel.com> (raw)
In-Reply-To: <20260119195053.E0850F99@davehans-spike.ostc.intel.com>
On Mon, Jan 19, 2026 at 11:50:53AM -0800, Dave Hansen wrote:
>
>From: Dave Hansen <dave.hansen@linux.intel.com>
>
>The only code that cares about the platform ID is the microcode update
>code itself. To facilitate storing the platform ID in a more generic
>place and using it outside of the microcode update itself, put the
>enumeration into a helper function in a header. Mirror
>intel_get_microcode_revision()'s naming and location.
>
>But, moving away from intel_collect_cpu_info() means that the model
>and family information in CPUID is not readily available. Just call
>CPUID again.
>
>Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
>Cc: Thomas Gleixner <tglx@kernel.org>
>Cc: Ingo Molnar <mingo@redhat.com>
>Cc: Borislav Petkov <bp@alien8.de>
>Cc: Dave Hansen <dave.hansen@linux.intel.com>
>Cc: "H. Peter Anvin" <hpa@zytor.com>
>Cc: Tony Luck <tony.luck@intel.com>
>Cc: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
>Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
>Cc: x86@kernel.org
>Cc: Jon Kohler <jon@nutanix.com>
>---
>
> b/arch/x86/include/asm/microcode.h | 31 +++++++++++++++++++++++++++++++
> b/arch/x86/kernel/cpu/microcode/intel.c | 10 +---------
> 2 files changed, 32 insertions(+), 9 deletions(-)
>
>diff -puN arch/x86/include/asm/microcode.h~refactor-get-processor-flags arch/x86/include/asm/microcode.h
>--- a/arch/x86/include/asm/microcode.h~refactor-get-processor-flags 2026-01-19 11:38:08.775892390 -0800
>+++ b/arch/x86/include/asm/microcode.h 2026-01-19 11:38:08.783892696 -0800
>@@ -2,7 +2,9 @@
> #ifndef _ASM_X86_MICROCODE_H
> #define _ASM_X86_MICROCODE_H
>
>+#include <asm/cpu.h>
> #include <asm/msr.h>
>+#include <asm/intel-family.h>
nit: You may want to sort the header files alphabetically.
next prev parent reply other threads:[~2026-01-20 3:07 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 19:50 [PATCH 0/6] x86/cpu: Take Intel platform into account for old microcode checks Dave Hansen
2026-01-19 19:50 ` [PATCH 1/6] x86/cpu: Break Vendor/Family/Model macros into separate header Dave Hansen
2026-01-20 8:24 ` Andy Shevchenko
2026-01-20 15:03 ` Dave Hansen
2026-01-20 16:22 ` Andy Shevchenko
2026-01-20 16:34 ` Dave Hansen
2026-01-20 20:54 ` Andy Shevchenko
2026-01-20 16:48 ` Luck, Tony
2026-01-20 20:50 ` Shevchenko, Andriy
2026-01-19 19:50 ` [PATCH 2/6] x86/cpu: Add missing #include Dave Hansen
2026-01-19 23:33 ` kernel test robot
2026-01-20 0:26 ` Dave Hansen
2026-01-20 8:19 ` Andy Shevchenko
2026-01-20 15:35 ` Dave Hansen
2026-01-20 3:26 ` kernel test robot
2026-01-19 19:50 ` [PATCH 3/6] x86/microcode: Refactor platform ID enumeration into a helper Dave Hansen
2026-01-20 3:07 ` Chao Gao [this message]
2026-01-20 16:06 ` Dave Hansen
2026-01-20 20:59 ` Andy Shevchenko
2026-01-22 19:26 ` Sohil Mehta
2026-01-19 19:50 ` [PATCH 4/6] x86/cpu: Add platform ID to CPU info structure Dave Hansen
2026-01-20 3:14 ` Chao Gao
2026-01-20 15:22 ` Dave Hansen
2026-01-21 2:03 ` Chao Gao
2026-01-20 8:27 ` Andy Shevchenko
2026-01-20 15:06 ` Dave Hansen
2026-01-20 20:44 ` Andy Shevchenko
2026-01-20 20:48 ` Dave Hansen
2026-01-19 19:50 ` [PATCH 5/6] x86/cpu: Add platform ID to CPU matching structure Dave Hansen
2026-01-20 8:30 ` Andy Shevchenko
2026-01-20 15:09 ` Dave Hansen
2026-01-19 19:51 ` [PATCH 6/6] x86/microcode: Add platform mask to Intel microcode "old" list Dave Hansen
2026-01-20 14:33 ` Zhao Liu
2026-01-20 15:10 ` Dave Hansen
2026-01-29 21:23 ` Sohil Mehta
2026-01-20 18:18 ` [PATCH 0/6] x86/cpu: Take Intel platform into account for old microcode checks Dave Hansen
2026-01-22 13:56 ` Ricardo Neri
-- strict thread matches above, loose matches on Subject: below --
2026-02-06 23:14 [PATCH 0/6] [v2] " Dave Hansen
2026-02-06 23:14 ` [PATCH 3/6] x86/microcode: Refactor platform ID enumeration into a helper Dave Hansen
2026-02-10 23:20 ` Sohil Mehta
2026-02-10 23:23 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW7xdw8mF8hkd/5O@intel.com \
--to=chao.gao@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jon@nutanix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=sohil.mehta@intel.com \
--cc=tglx@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.