From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E92BD2ECF7 for ; Tue, 20 Jan 2026 08:54:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vi7Uv-0006ld-2t; Tue, 20 Jan 2026 03:54:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vi7Uq-0006jU-D2 for qemu-devel@nongnu.org; Tue, 20 Jan 2026 03:53:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vi7Uo-0007lT-N4 for qemu-devel@nongnu.org; Tue, 20 Jan 2026 03:53:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768899232; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=rrLOntbJsgjYEvO6mON7jZ85ryiit7ZpLgY5oLPPgaM=; b=UDv/9tc/QVmr1WElAbjjVQ2ERI6FCCnolA2yiQZLT0TEVc4DaJcZJKqf5fHqnwp8yjb0bl h3jBgWM17TyJbTql9ifXViEKr0ZoIpDudLuiro7Hd1b6tpgj+PBLm/2uxMa1IW6vFw3yT2 QtD6JY4WHfLOl2hr4ie/nFsRvYVmbI8= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-551-vckgGStdPZiKAG02WsJZsQ-1; Tue, 20 Jan 2026 03:53:49 -0500 X-MC-Unique: vckgGStdPZiKAG02WsJZsQ-1 X-Mimecast-MFC-AGG-ID: vckgGStdPZiKAG02WsJZsQ_1768899227 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4E5FD180044D; Tue, 20 Jan 2026 08:53:47 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.89]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1281F19560A2; Tue, 20 Jan 2026 08:53:40 +0000 (UTC) Date: Tue, 20 Jan 2026 08:53:37 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: John Snow Cc: qemu-devel@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Vladimir Sementsov-Ogievskiy , Kevin Wolf , Maksim Davydov , Li-Wen Hsu , Markus Armbruster , Thomas Huth , Mauro Carvalho Chehab , Hanna Reitz , Cleber Rosa , Michael Roth , Yonggang Luo , Ed Maste , Peter Xu , Fabiano Rosas , Paolo Bonzini , qemu-block@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH v4 05/17] meson, mkvenv: add functests custom target Message-ID: References: <20260119212744.1275455-1-jsnow@redhat.com> <20260119212744.1275455-6-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260119212744.1275455-6-jsnow@redhat.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.016, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Jan 19, 2026 at 04:27:31PM -0500, John Snow wrote: > add the "pyvenv_functests_group" target to meson. This target will > invoke mkvenv.py to install the associated dependency group to the > build/pyvenv directory. > > A "pyvenv_tooling_group" is not included here as it is the plan to > always install this group by default, so it will not need an on-demand > trigger. > > Signed-off-by: John Snow > --- > meson.build | 1 + > pyvenv/meson.build | 28 ++++++++++++++++++++++++++++ > 2 files changed, 29 insertions(+) > create mode 100644 pyvenv/meson.build > > diff --git a/meson.build b/meson.build > index 3108f01e887..245f1bc2ec9 100644 > --- a/meson.build > +++ b/meson.build > @@ -4551,6 +4551,7 @@ subdir('scripts') > subdir('tools') > subdir('pc-bios') > subdir('docs') > +subdir('pyvenv') > # Tests are disabled on emscripten because they rely on host features that aren't > # supported by emscripten (e.g. fork and unix socket). > if host_os != 'emscripten' > diff --git a/pyvenv/meson.build b/pyvenv/meson.build > new file mode 100644 > index 00000000000..2bfddeb4a52 > --- /dev/null > +++ b/pyvenv/meson.build > @@ -0,0 +1,28 @@ > +# Note that this file only controls "optional" dependency groups; groups > +# *required* for the build are handled directly in configure instead: > +# namely, meson and sphinx. > + > +# NB: This command may or may not include the "--online" flag, depending > +# on the results of configure. > +ensuregroup_cmd = config_host['MKVENV_ENSUREGROUP'].split() I'm confused because this implies that "ensuregroup_cmd" use of the --online flag is supposed to be controlled by configure > + > +pyvenv_common_deps = files( > + meson.project_source_root() + '/pythondeps.toml', > + meson.project_source_root() + '/python/scripts/mkvenv.py' > +) > +pyvenv_wheel_dir = meson.project_source_root() + '/python/wheels' > + > + > +# This group is allowed to rely on internet, to fetch from PyPI. > +# If --online was not passed to configure, this could fail. ...and this also suggests --online is supposed to be controlled by configure, but... > +pyvenv_functests_group = custom_target( > + 'pyvenv_functests_group', > + output: 'functests.group', > + input: pyvenv_common_deps, > + command: ensuregroup_cmd + [ > + '--online', now we just go ahead and hardcode use of --online regardless. > + '--dir', pyvenv_wheel_dir, > + '@INPUT0@', > + 'functests', > + ], > +) > -- > 2.52.0 > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|